Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp528794ybi; Wed, 19 Jun 2019 03:42:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqxUyxhzY3IgOf8m09s+zCEeaPBN/yynE49bEo+r6CpDIQd3YuG4bu7IAmT0wR3DJuRz/l31 X-Received: by 2002:a17:902:2a68:: with SMTP id i95mr120546574plb.167.1560940962228; Wed, 19 Jun 2019 03:42:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560940962; cv=none; d=google.com; s=arc-20160816; b=PlgupGANkhwYtfGHFi5ueycnPlDK7h9zyjs5HPCTPdDrgc5sduM+ygK9qd2nbjsnvv /XihjGzPGYVOhV/cYKtTe4xCXM3pJjvL+Cm9yfCR585oUA+LCflOs4/Ov6IhU1G8NYl1 A2t/zgWqX/sIi86GWBDUJhii+3GRbWEPXZSYZzCiAroklQho62CT+5fCr6M3OCcMOPUD W0oNva3aRcVtF8MpQCsdU2oYv1ofHSrffIdz9AzYEVKwHoPd+TexqQhMm2yXBM44Orhp 2RPaiP731RkoHy8saG0e8nhXnzDc60AjM+Js1Wzr0qG6FuqoGJrgvgyZJyWFZylUgzOe w8hg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=TT2nK9A47FLcAVPWjohBdM0YSA12JZIvgdjlygMunHY=; b=mvq4hAcyPQEg+tAAr/V1wKSjahAQbSFN9Tf9vMmBocnGUn05oZSx5nziZHnCYeaRo7 84YzdJegF/UH2GCSA2CZOBbKhfCBmluTsL5Q8yIcrDrhFFFsNcipie0TFhp766oVWtjg DT92gKt+lMc1F8NTTHbbQ8umYR2q3W0mdD9Rs+T9J6GdrbmrfjjYW6PwCDOOjbCe81VJ PiBEuw7BpRskFL2Z8DkpWPOR4Ch0jEN0yBpu5WSYRo6uV7+XPyaXjsL812ClUmnrCk1X UvPg8gup3i/FKs6qHd6Vt7AyVRv/DytYfVLtDr1GRmxhCM31vHB6Fj4HKShT6Q4DW10J dCVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=NyIsIIb+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f89si1119043pje.50.2019.06.19.03.42.25; Wed, 19 Jun 2019 03:42:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=NyIsIIb+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727134AbfFSKmV (ORCPT + 99 others); Wed, 19 Jun 2019 06:42:21 -0400 Received: from mail-wm1-f65.google.com ([209.85.128.65]:33396 "EHLO mail-wm1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726751AbfFSKmV (ORCPT ); Wed, 19 Jun 2019 06:42:21 -0400 Received: by mail-wm1-f65.google.com with SMTP id h19so4325256wme.0 for ; Wed, 19 Jun 2019 03:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=TT2nK9A47FLcAVPWjohBdM0YSA12JZIvgdjlygMunHY=; b=NyIsIIb+uVSx90RcZzFhDtYTjpvPlbj+hShSLfVTuJIpwMvZ/ktBguPb0h4gANFzoi hvLO9eK3+HcdDVGQqD4g6tfj30LVmL361dA7To7DiQGi0nM1Zm1pvX7plq+6FOH7NmAr /O+kiyQUl0JxHCQQcIUjmJvlZIDtqcyTcqHWD7j+mEn55FSdIUa+BgKm50iEvucQFs6s enAOJmxl4UVjU7zLox6+cqbLZeNCNPM24D74OHDh2chnsVpkFDOlc4Nn8zllc0AlalEC VdJcgCpHGQZ2WOKypxHA5wiou0C8wvRHblDGY4Y9c8KsQ+vcp7r5s5pobRcx7rLVlV03 1hZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=TT2nK9A47FLcAVPWjohBdM0YSA12JZIvgdjlygMunHY=; b=ECLTpIp7foOMvHfwKvmNAQUVVXtcDdSndLAnAa6E46POrsy7/pKP1CyI2uKwjZHEMc hhGYNabINHVi2AP+agp5B05ip+Er4hLhmIKitlYu58ASvWtkl/DM+dhfvaPbKvixGVba J2i+3UTLClLHp5bbjLMejqff8brH17USqRQyD6RTf7YcRrv75oy9ha1Xht7FMQ3gc1Tc On5xMwsAfV6nhhxbPdunMtItQKGX+Fvq0G+PmDe5p6yT2aEcj0NVs4IKHtAXjGM+4QVi B1bCLffgDU2uxNMlDRDBFq8mDtTH6piXXYU2EyZ5iqWwC5iH/pDfbiP1+FJpSfJKtuIb qxFQ== X-Gm-Message-State: APjAAAUgGdB0t4ajtUIWoMqyvBbSbLwG8p3X4iBqKF+qgSLeZWZqpPak ynQYNPmD5bFgtylioJ1h6rfeBHrE X-Received: by 2002:a1c:6c08:: with SMTP id h8mr8069991wmc.62.1560940939330; Wed, 19 Jun 2019 03:42:19 -0700 (PDT) Received: from arch-x1c3 ([2a00:5f00:102:0:9665:9cff:feee:aa4d]) by smtp.gmail.com with ESMTPSA id w2sm16821493wrr.31.2019.06.19.03.42.18 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 19 Jun 2019 03:42:18 -0700 (PDT) Date: Wed, 19 Jun 2019 11:40:14 +0100 From: Emil Velikov To: Gerd Hoffmann Cc: dri-devel@lists.freedesktop.org, David Airlie , "open list:VIRTIO GPU DRIVER" , open list Subject: Re: [PATCH v3 11/12] drm/virtio: switch from ttm to gem shmem helpers Message-ID: <20190619104014.GB1896@arch-x1c3> References: <20190619090420.6667-1-kraxel@redhat.com> <20190619090420.6667-12-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190619090420.6667-12-kraxel@redhat.com> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gerd, On 2019/06/19, Gerd Hoffmann wrote: > -static void virtio_gpu_init_ttm_placement(struct virtio_gpu_object *vgbo) > +static const struct drm_gem_object_funcs v3d_gem_funcs = { s/v3d/virtio/g Doubt I'll have the time for a proper review - just this and the 1/12 nits :-\ HTH Emil