Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp536718ybi; Wed, 19 Jun 2019 03:51:52 -0700 (PDT) X-Google-Smtp-Source: APXvYqwcx3C/O17xHCaxEMsypVOOr7ZOavPspslIpf0x8s2cuGWyJuSU0t5Q3A3WytFASavn59qr X-Received: by 2002:a63:4406:: with SMTP id r6mr7181631pga.250.1560941512334; Wed, 19 Jun 2019 03:51:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560941512; cv=none; d=google.com; s=arc-20160816; b=tQzFUZHIPUq6sLTv0twnzxnGSMiSm7q1JMBeUJ/QI5JGsHmdLeT6t8unSQg2yU+lZM 2RF+CfolVXHLa+O9IAD08S/VxrxuEZLcqyMyR1ZSxJN0fBpdyjnTeIbOSPnD0mhdubt/ ecSbkEYSP5YI4UeTOB3dSziDB79Dbg2ZmL65lpb+qrc7wk6ilEedTeZqIr4ykZJiK40+ D0QvpyntmINP/Q3yJAIrVUA63naZP2hycGwmOh6Hj8FpQyZ2blpUm54MHmdT2Sy2Ml2M qUrHT3qFG+ToIQIt57NYkB+2Xr9Qj2Y5c1qpBrlFflJWNI/XBnlrBdYAHr4kzZJenUaD ZWmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=g/9XHZg+XYR+3gb+YMkvmxZ20+jZPicb/uHCt9U0Wa4=; b=krqEdXZwoevrx7JzTnnlYU7Vmi9J4O9ApSPEGDmkLfmm9pdCcm5QB+V6NIzO6oNSPh 00sMozkAqpDPMoUsvG5ju+mBLKCpqCGWwtC4IBivv8XLh/+ZmEUSoI9/78NvIdevyiOD BgCnm2HZi85hlTxxIcAc2rh+0nnZKD0X1+kyn+LTEXg8TUmi/09Kduw4DapwNa2YHe1X HKOHsh12alO5rnHfbwApk5JnastroF/KNwXhTATsUNns62upf6tA4CQLQKh3HCno1i3e KjkoErq82xRg+0g8kpnPW7Cy/Cf5VIhrQFFSu+Fyj99uqNnzhmGb/JF/hv7xbpNCk5V9 bAmA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a5si2634391pgt.281.2019.06.19.03.51.36; Wed, 19 Jun 2019 03:51:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731510AbfFSKv2 (ORCPT + 99 others); Wed, 19 Jun 2019 06:51:28 -0400 Received: from mail.us.es ([193.147.175.20]:40978 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727552AbfFSKv1 (ORCPT ); Wed, 19 Jun 2019 06:51:27 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id D9F8867BA1 for ; Wed, 19 Jun 2019 12:51:25 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id CAA01DA712 for ; Wed, 19 Jun 2019 12:51:25 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id C6551DA715; Wed, 19 Jun 2019 12:51:25 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 5515BDA718; Wed, 19 Jun 2019 12:51:23 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Wed, 19 Jun 2019 12:51:23 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 1D9474265A32; Wed, 19 Jun 2019 12:51:23 +0200 (CEST) Date: Wed, 19 Jun 2019 12:51:22 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Colin King Cc: Jozsef Kadlecsik , Florian Westphal , "David S . Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][V2][next] netfilter: synproxy: ensure zero is returned on non-error return path Message-ID: <20190619105122.envwm53ew7isp4m2@salvia> References: <20190618142244.16463-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190618142244.16463-1-colin.king@canonical.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 18, 2019 at 03:22:44PM +0100, Colin King wrote: > From: Colin Ian King > > Currently functions nf_synproxy_{ipc4|ipv6}_init return an uninitialized > garbage value in variable ret on a successful return. Fix this by > returning zero on success. Applied, thanks Colin.