Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain;
        charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 11.1 \(3445.4.7\))
Subject: Re: [PATCH v2] KVM: x86: Modify struct kvm_nested_state to have
 explicit fields for data
From:   Liran Alon <liran.alon@oracle.com>
In-Reply-To: <e2800277-4d44-5caa-1122-c36487f6e6bb@redhat.com>
Date:   Wed, 19 Jun 2019 14:10:58 +0300
Cc:     linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <C8A35660-C78F-4EBB-BCAF-8C9BCC9D323C@oracle.com>
References: <1560875046-26279-1-git-send-email-pbonzini@redhat.com>
 <D2867F96-6B8D-4A1D-9F6F-CF0F171614BC@oracle.com>
 <e2800277-4d44-5caa-1122-c36487f6e6bb@redhat.com>
To:     Paolo Bonzini <pbonzini@redhat.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


> On 19 Jun 2019, at 13:45, Paolo Bonzini <pbonzini@redhat.com> wrote:
>=20
> On 19/06/19 00:36, Liran Alon wrote:
>>=20
>>=20
>>> On 18 Jun 2019, at 19:24, Paolo Bonzini <pbonzini@redhat.com> wrote:
>>>=20
>>> From: Liran Alon <liran.alon@oracle.com>
>>>=20
>>> Improve the KVM_{GET,SET}_NESTED_STATE structs by detailing the =
format
>>> of VMX nested state data in a struct.
>>>=20
>>> In order to avoid changing the ioctl values of
>>> KVM_{GET,SET}_NESTED_STATE, there is a need to preserve
>>> sizeof(struct kvm_nested_state). This is done by defining the data
>>> struct as "data.vmx[0]". It was the most elegant way I found to
>>> preserve struct size while still keeping struct readable and easy to
>>> maintain. It does have a misfortunate side-effect that now it has to =
be
>>> accessed as "data.vmx[0]" rather than just "data.vmx".
>>>=20
>>> Because we are already modifying these structs, I also modified the
>>> following:
>>> * Define the "format" field values as macros.
>>> * Rename vmcs_pa to vmcs12_pa for better readability.
>>>=20
>>> Signed-off-by: Liran Alon <liran.alon@oracle.com>
>>> [Remove SVM stubs, add KVM_STATE_NESTED_VMX_VMCS12_SIZE. - Paolo]
>>=20
>> 1) Why should we remove SVM stubs? I think it makes the interface =
intention more clear.
>> Do you see any disadvantage of having them?
>=20
> In its current state I think it would not require any state apart from
> the global flags, because MSRs can be extracted independent of
> KVM_GET_NESTED_STATE; this may change as things are cleaned up, but if
> that remains the case there would be no need for SVM structs at all.

Hmm yes I see your point. Ok I agree.

>=20
>> 2) What is the advantage of defining a separate =
KVM_STATE_NESTED_VMX_VMCS12_SIZE
>> rather than just moving VMCS12_SIZE to userspace header?
>=20
> It's just for namespace cleanliness.  I'm keeping VMCS12_SIZE for the
> arch/x86/kvm/vmx/ code because it's shorter and we're used to it, but
> userspace headers should use a more specific name.

Ok then.
I will submit my next version of QEMU patches according to this version =
of the headers.

Reviewed-by: Liran Alon <liran.alon@oracle.com>

>=20
> Paolo