Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp638790ybi; Wed, 19 Jun 2019 05:31:23 -0700 (PDT) X-Google-Smtp-Source: APXvYqzBHAVesbtaq/lo0RR7QvzjoDvHBlk+KfCXmpl90f7lHH/2UcV5V2XUyLDtDvQ1DB7DAzoZ X-Received: by 2002:a17:902:26c:: with SMTP id 99mr122488859plc.215.1560947483794; Wed, 19 Jun 2019 05:31:23 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560947483; cv=none; d=google.com; s=arc-20160816; b=RcHqSHr9eK9iksta9SjNqSooG1qCn3Acd9OC07jzdW7m44Ur4veWWc0HvFLIJCh4Sq dWGH/Y/l5kaS7sisYQws7HdY0qYFZH6irw+5g0iUDvKOQMVAB/U1PQqNi3gLdUJ14ri9 6vgrXg1WH9fN+a1NENRqPnTZ6cb4zhl7Y1NWjEXfiL0jZPvAQkMIq+v4IpoRHvzy8QRY CcpZNcM4aDXGSNHrAnjfrrf+qwkWByGyEeGC8GgsAwgcAoL9mtXWVW/gqikrCRPyETrw 2AmLh9IzDxHUqWcvAB5DFKDRcTHQlhkqSquw8bkA8Sc4xCiZxDvV+FNDORsTqc8U4UYZ jlFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=z4INWegdUTe8Q6ns0c8f39S93Wy18nSWojE+tUkgp2w=; b=j9MFA0q9h3WZiFXMX5RwJfmyVm6fGrCHy5TFYM72BZdydARDL8jU+FKW9o9DF26rh8 qRnTWHR3WyEquq4Ukhq8roKPTKLW2XPixjsMiRjbzGRFpLMkT0WavWED04Kqb5OG9l/a 5IpDkxPc3eJ5YZfKo1378k7a7C/g24AJaRKKdy4mj+Doig/m2n7i1y+pxvun5966cHPY B2Bp65Xc5MjW5TgYpz8qhw+IMUgJVoGsmNlPTxCrPs1iqV53eEfPo0piV1ZHus/eDdbx a8aWbGZZbIP0TdwaLSHWoy8GefaYeO7Rk3f9Er8tMrxeJXuhCgSybp2TTo+a4xyC7O5I lnEQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g22si170571pfh.219.2019.06.19.05.31.07; Wed, 19 Jun 2019 05:31:23 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731913AbfFSMar (ORCPT + 99 others); Wed, 19 Jun 2019 08:30:47 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:50840 "EHLO mail-wm1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731898AbfFSMaq (ORCPT ); Wed, 19 Jun 2019 08:30:46 -0400 Received: by mail-wm1-f68.google.com with SMTP id c66so1588649wmf.0 for ; Wed, 19 Jun 2019 05:30:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=z4INWegdUTe8Q6ns0c8f39S93Wy18nSWojE+tUkgp2w=; b=dmcHhDdGipAdmz/1MG7f4Ebjq8eJXFiz/14wjsDXSmoX1BRzeRdt2PJBya7G36QwlE GgdxlfaRJA6ch0awPlzHe3vlSQQemxVxaycr5VmZ53QovjDPjp2Qh41afFp33nliKWnr unmD2Hr2MBopJFayVifiKD+ApO/JGZGVjNwobfG0UhjWwPJM4D0R7uChYOqwkyDcotDQ jXRJHjslfR/hoWwX45TishLQ64c+QPmkbnyU1VF4o7bIb2Ms1zDof7vZmbNZx4APxq2Q /UznDeZ94T3iIqMF67xvHiBRLU3zPkWKoElEy3na0XpmlYMofx1Od269bBVcmV2i4aYN 7FqA== X-Gm-Message-State: APjAAAXzN7x1fX3WN/vbwH3t30u6jlXsFzGS+x8Ij0MsrNSdyDUb7Dxf xvQlOowWnkCC9vnqP5pnVNNexQ== X-Received: by 2002:a7b:c74a:: with SMTP id w10mr7804571wmk.99.1560947444548; Wed, 19 Jun 2019 05:30:44 -0700 (PDT) Received: from miu.piliscsaba.redhat.com (catv-212-96-48-140.catv.broadband.hu. [212.96.48.140]) by smtp.gmail.com with ESMTPSA id 11sm1837513wmd.23.2019.06.19.05.30.42 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 19 Jun 2019 05:30:43 -0700 (PDT) From: Miklos Szeredi To: David Howells Cc: Al Viro , Ian Kent , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/13] fusectl: don't ignore options Date: Wed, 19 Jun 2019 14:30:18 +0200 Message-Id: <20190619123019.30032-12-mszeredi@redhat.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190619123019.30032-1-mszeredi@redhat.com> References: <20190619123019.30032-1-mszeredi@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The options "sync", "async", "dirsync", "lazytime", "nolazytime", "mand" and "nomand" make no sense for the fusectl filesystem. If these options are supplied to fsconfig(FSCONFIG_SET_FLAG), then return -EINVAL instead of silently ignoring the option. Any implementation, such as mount(8) that needs to parse this option without failing should simply ignore the return value from fsconfig(). Signed-off-by: Miklos Szeredi --- fs/fuse/control.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fuse/control.c b/fs/fuse/control.c index c35013ed7f65..f3aab288929f 100644 --- a/fs/fuse/control.c +++ b/fs/fuse/control.c @@ -351,7 +351,7 @@ static int fuse_ctl_get_tree(struct fs_context *fc) static const struct fs_context_operations fuse_ctl_context_ops = { .get_tree = fuse_ctl_get_tree, - .parse_param = vfs_parse_fs_param, + .parse_param = vfs_parse_ro_rw, }; static int fuse_ctl_init_fs_context(struct fs_context *fc) -- 2.21.0