Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp639195ybi; Wed, 19 Jun 2019 05:31:45 -0700 (PDT) X-Google-Smtp-Source: APXvYqzzs+tMN3BtKCwXRwGxk0VBrSCy/qBeCwisiSzfUfO81gXVHXVFD2mj+XXhgiiCobM/mMA/ X-Received: by 2002:a63:1208:: with SMTP id h8mr7298758pgl.377.1560947505105; Wed, 19 Jun 2019 05:31:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560947505; cv=none; d=google.com; s=arc-20160816; b=JToZzrzoNUYy1mRJwDOfZbw89mVJSDisI95ghrjOwpYTXynXGwg9N+H2hsSIHNxv4J YThD0DFGTC8wgpCBA7VUVRQOY1AQqAblUsfJi4FRX4dzEb4uci5roUAmdsB8+kthz+aw Cf4ncXckyRJZhnyGbL2U74v8eyK2FVGym698OQV/eczfTSdbuv+cC4rhe1hubp9baP0H jc2F7xeMZA4B0JQX8vuynsuNhPv1iTPDx1UcPc22Rk1M0La+RDDGsKKOsQQSTsXUU9Hk SAIVFP7BEtavjxBltbvKgyzGzAjcXBilBbAUxJ9TbICaTWjT3vMwZhvKFpk0kaeo5OSQ 5p9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=1nQV+HbwwVC5JDcFHvgQnxZlAQ2DeroGpuSkk8jd0Tk=; b=xQCVXC1XgmfAr9uDuYmT+SJgGPNwENtv/Ie09IPQt1vkhLlcchexc3c5aWd18gfdfy DbPqzWMjd4Ex37N0PfOTAUf6c3Ytw7aq/vMKiEGPwxfYjX9y1fpaPyASoU+fY4cjEkuD 99qw1EPL06IFO5aonWgNl0odNiqwo8IThNMrha8XVyQw2AcFbVhbDwdqj6p7sK49ZhzD Zm5/XvbhPLwmBMt1rgKGkj6FgqjbgQpBI2uChAift3M4KvWNMfPt5H8JXsQKzmCHadS1 Ne7z+0Vr1UvFFSskT3Ax5l5hHJfcVwd36PTpyYg/+NsSgqk+PqVCh2bmw2phtqPcVLGj gYrA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b3si3218150pgn.324.2019.06.19.05.31.29; Wed, 19 Jun 2019 05:31:45 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731724AbfFSMa6 (ORCPT + 99 others); Wed, 19 Jun 2019 08:30:58 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:39806 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731859AbfFSMao (ORCPT ); Wed, 19 Jun 2019 08:30:44 -0400 Received: by mail-wr1-f66.google.com with SMTP id x4so3187659wrt.6 for ; Wed, 19 Jun 2019 05:30:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=1nQV+HbwwVC5JDcFHvgQnxZlAQ2DeroGpuSkk8jd0Tk=; b=JY+DN3K+8z6qR5EaaN4BIxFx9ZQ298uAIsuCNuiD6d/NzXy3lbNZPNFYmanSgN2ekv WulNdyCfsr6Y7lUELObOYb4G42SpjkWkqzBlDf06+9u6foaxXi3RlNoxYWIMCYBQdgGu J+rM63CsY3fsdtxzERsLnUeF9b8HOpFEQ5rWSX3TMEvpjFrGeB+qanMNMxaTGCXlbbT8 nN7h73l+vQrnd9/7/rJDC+NgxFLOtHDIhNMVd4byuwwKPGOXQhrnFPYpjtzg/uiaDuja 3jK+jDSYNfobUPLDVWeuPBMcoC8GGRUyGWXT7MD/Bq42/bKplidvvWsaFHzencF3Wt2D h5cA== X-Gm-Message-State: APjAAAUFSLTKhIUXrT0QKdApEUxGyOGGJVaQ0UMvxB4EA3/DHa36evHP 2HmWTLVnqb3pQi78l7eI3WWfYg== X-Received: by 2002:a5d:4908:: with SMTP id x8mr18266350wrq.290.1560947442583; Wed, 19 Jun 2019 05:30:42 -0700 (PDT) Received: from miu.piliscsaba.redhat.com (catv-212-96-48-140.catv.broadband.hu. [212.96.48.140]) by smtp.gmail.com with ESMTPSA id 11sm1837513wmd.23.2019.06.19.05.30.41 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Wed, 19 Jun 2019 05:30:42 -0700 (PDT) From: Miklos Szeredi To: David Howells Cc: Al Viro , Ian Kent , linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 11/13] cgroup: don't ignore options Date: Wed, 19 Jun 2019 14:30:17 +0200 Message-Id: <20190619123019.30032-11-mszeredi@redhat.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190619123019.30032-1-mszeredi@redhat.com> References: <20190619123019.30032-1-mszeredi@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The options "sync", "async", "dirsync", "lazytime", "nolazytime", "mand" and "nomand" make no sense for the cgroup filesystem. If these options are supplied to fsconfig(FSCONFIG_SET_FLAG), then return -EINVAL instead of silently ignoring the option. Any implementation, such as mount(8) that needs to parse this option without failing should simply ignore the return value from fsconfig(). Signed-off-by: Miklos Szeredi --- kernel/cgroup/cgroup-v1.c | 2 +- kernel/cgroup/cgroup.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/cgroup/cgroup-v1.c b/kernel/cgroup/cgroup-v1.c index f960e6149311..1f50d59f7f4e 100644 --- a/kernel/cgroup/cgroup-v1.c +++ b/kernel/cgroup/cgroup-v1.c @@ -929,7 +929,7 @@ int cgroup1_parse_param(struct fs_context *fc, struct fs_parameter *param) struct fs_parse_result result; int ret, opt, i; - ret = vfs_parse_sb_flag(fc, param); + ret = vfs_parse_ro_rw(fc, param); if (ret != -ENOPARAM) return ret; diff --git a/kernel/cgroup/cgroup.c b/kernel/cgroup/cgroup.c index 93890285b510..f2e86b3942b3 100644 --- a/kernel/cgroup/cgroup.c +++ b/kernel/cgroup/cgroup.c @@ -1836,7 +1836,7 @@ static int cgroup2_parse_param(struct fs_context *fc, struct fs_parameter *param struct fs_parse_result result; int ret, opt; - ret = vfs_parse_sb_flag(fc, param); + ret = vfs_parse_ro_rw(fc, param); if (ret != -ENOPARAM) return ret; -- 2.21.0