Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp760662ybi; Wed, 19 Jun 2019 07:26:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqzarqIHAbcnv7qcfyszZdtL3OKE2lGjrgnSuXKwN/K6bKhhzoNcNx26vBVR+kqDBYtclR8B X-Received: by 2002:a63:2258:: with SMTP id t24mr7946869pgm.236.1560954391041; Wed, 19 Jun 2019 07:26:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560954391; cv=none; d=google.com; s=arc-20160816; b=B85cJMMQ/zwootx9M5scT5uUnMqF1b2FzCRXuCN9cJrDnk0/P62MpttTaC/saWS4PW yXOPBZnmeMr4EB5JMYU+a/zBTIxTVUqIMv+/7RvhFp/2dadgLb8d1Dv3KyjJATQEC4zm 8iPx06YFsq2xQ80s873gO/CiWw4W9TktN0MZIHXApV+qdRma+v9X02esyvaopQj+lk51 iN35KT/q8cOVrfNiyNv9vfhTo0CJjx83bsRLWtkwaTDQAX9M3Hh4/+jBheY7ILAisbuj 8M55rhX51I5uzFyldfTg6mlxdX5K2dz1zUuAtFAT8z57McmtkBTEXkIVwVKXfoxkORfz 6zkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=JeujIqTTr6KagPfDXJ9g9Op0KliZVOudQ/dgTShgqWk=; b=Nsx4uxa5ltCTXYjAeZORMuFlpEk+0U3sWGKXBVl36w9g6XT2B0xC3AI1Wrd8FekqKi C7DqZ5i668cdwwTO5GglCT4wZAUdCWaBypuyy7QzZaWh/Dw4+y7nr2TpWaFr+kNEM+7i nj5JXQVoBfPQ3z6eiHQ0OxBW2M5TQKuq0C9hyH83HSuSHwSqeW2lBcORU6xwRV1IS4CN dFheb3QtMpnhkRo0kehp3IW1THNeaQ61XvEwT66VClvg+DO6BWaC2AbuuGr0uJWVT0c7 gZlfH+KKU0G5Td8NHXnNg9MPwtuxbNf1JiKUezukN5TgkrrfjVDOWwd9auBJYjPiXGRq avGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z7si3168803pgu.224.2019.06.19.07.26.15; Wed, 19 Jun 2019 07:26:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730357AbfFSOYX (ORCPT + 99 others); Wed, 19 Jun 2019 10:24:23 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:34892 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726238AbfFSOYX (ORCPT ); Wed, 19 Jun 2019 10:24:23 -0400 Received: from localhost (unknown [144.121.20.163]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 5F8A2152366BE; Wed, 19 Jun 2019 07:24:22 -0700 (PDT) Date: Wed, 19 Jun 2019 10:24:21 -0400 (EDT) Message-Id: <20190619.102421.1429386927501157217.davem@davemloft.net> To: rasmus.villemoes@prevas.dk Cc: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, Rasmus.Villemoes@prevas.se, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: dsa: mv88e6xxx: fix shift of FID bits in mv88e6185_g1_vtu_loadpurge() From: David Miller In-Reply-To: <20190619100203.11749-1-rasmus.villemoes@prevas.dk> References: <20190619100203.11749-1-rasmus.villemoes@prevas.dk> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 19 Jun 2019 07:24:23 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rasmus Villemoes Date: Wed, 19 Jun 2019 10:02:13 +0000 > The comment is correct, but the code ends up moving the bits four > places too far, into the VTUOp field. > > Fixes: 11ea809f1a74 (net: dsa: mv88e6xxx: support 256 databases) > Signed-off-by: Rasmus Villemoes Applied and queued up for -stable.