Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp761011ybi; Wed, 19 Jun 2019 07:26:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqxpZWp5LAIFK1AK/W7OW2PXQPkhvEKCfE+vIMzHd8cgGfrIqWe27fTunkYwfoA2HQqVGWZw X-Received: by 2002:a17:902:ea:: with SMTP id a97mr77987961pla.182.1560954414423; Wed, 19 Jun 2019 07:26:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1560954414; cv=none; d=google.com; s=arc-20160816; b=aOXzCgLaTWcE1M0Rip96Y7eZQ2fX9U13AVwyR9RVXVXol8dM9zE7WO8WygmZZi0XlY mFZ2xn1qn5GqJEW4kEUORHoJtBA6VbX/RO5Ea1L/OfwoDSki55UkXn9Eo05c+mzbyL4N 5aTMLkltwWSBlNMXMyUtonr/dPtx3ZXsrRsyxqcKtq7J+QeA7S9wtrYC0342zQr0N6Wq +nWUFiHXyN9WzANZt5ne+HyGSzZ73+0qXC5qvJRaR83rUBOarjjHqsnBWRbCVFSa6G2P AL2e6SPuw6KIMHNxH2F6S/X8OVeycg+RmNyac8g2tV97ZDn+0h+6JpRb/lGrV6Xc49ik T1vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=E/AgC/xa8oVf9H1UCCblHtb8H3y3wClrsdGA9oXk9Wo=; b=qa22013V7SwCNroeXMwkiFi2zRWDmlQM7hR+qrCflLA0Dusd95mt1Q4x6F2+tPDfPg NUlQlqJ1rabazVjjV65SqGmIDcUmoex6gs20bJd0sCr8QsvMXTVRbELATgCR12bojZlX ogXDV5K1fxLWFBs3aqsAxhDJZ3xixggERY2+TXY0YLPPoBOzu1v0Xuc+XHuFxn8XYTR1 xa38+0h1ViTJMolUu3+2tAi515XuivYiulmT0MndgwQsVTfLVRrlzdObrwFGyFShdCxu XXocXYfNJDXB9E5F0YInfHOjkjj9RAxr6ZA5o2hliMJA4RhYkQBuFt54ugUUvjl1vccb O1ew== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t7si3264972pgu.3.2019.06.19.07.26.39; Wed, 19 Jun 2019 07:26:54 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729179AbfFSO0W (ORCPT + 99 others); Wed, 19 Jun 2019 10:26:22 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:34940 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726238AbfFSO0V (ORCPT ); Wed, 19 Jun 2019 10:26:21 -0400 Received: from localhost (unknown [144.121.20.163]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id CC535152366DD; Wed, 19 Jun 2019 07:26:20 -0700 (PDT) Date: Wed, 19 Jun 2019 10:26:19 -0400 (EDT) Message-Id: <20190619.102619.618962498575895795.davem@davemloft.net> To: rasmus.villemoes@prevas.dk Cc: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, Rasmus.Villemoes@prevas.se, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: fix shift of FID bits in mv88e6250_g1_vtu_loadpurge() From: David Miller In-Reply-To: <20190619100224.11848-1-rasmus.villemoes@prevas.dk> References: <20190619100224.11848-1-rasmus.villemoes@prevas.dk> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 19 Jun 2019 07:26:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rasmus Villemoes Date: Wed, 19 Jun 2019 10:02:38 +0000 > The comment is correct, but the code ends up moving the bits four > places too far, into the VTUOp field. > > Fixes: bec8e5725281 (net: dsa: mv88e6xxx: implement vtu_getnext and vtu_loadpurge for mv88e6250) > Signed-off-by: Rasmus Villemoes Also applied, thank you.