Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1406572ybi; Wed, 19 Jun 2019 20:14:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqzPkNxFCAuFwRkcKTyH3cu/LNknVWDN/7Io84Pcp9PclvsWriqTcfP4n0zNH8zGOjGOsZoi X-Received: by 2002:a63:eb56:: with SMTP id b22mr10553967pgk.81.1561000495912; Wed, 19 Jun 2019 20:14:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561000495; cv=none; d=google.com; s=arc-20160816; b=ODmI5oQ3Ci+vSkj1Ihw1Scg5moEhA/4UnS2Kwrxl7CJ31HpuZND+vptX+z/hTR0OEq Jdixrfmei6RCEB1qwEDcYVIvs2pxBnYg/O5QkWex2PHhgtjiVIuth9elQp46Jsc0nURQ gzxf9vSLXT36t7rlbZVqy78uSqjOLmWzsr614YFAnvzXvC+j3yWcSxKqJSFcfGnEwhj2 Vo22DvOouq6BqsA6YFFIVEaR14GkxCyxKFyNSln+xwI6js8nVkqmarQvArTeSXznq0dM qaa7LHJ04JOQi09zlgqD3O7Ro8dMv/l5hVY3yo4JR0j4yVwCDrnL+cENOKZrf4b0AVs5 qcUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:content-transfer-encoding :dlp-reaction:dlp-version:dlp-product:content-language :accept-language:in-reply-to:references:message-id:date:thread-index :thread-topic:subject:cc:to:from; bh=JmyjpR/xTZ26o3nxMUbgZK4rQkdmyqPKouRYzAJJzzI=; b=rlqYy/oZeTE4IqeY5SlDImHIGnDi48hy9icGUrnc9ZRs/UtKMKeWeta+/3S8/KTOTg ZodDwIWu+6tWtaVe8wDMJKlLBgBX5sdw1OGYy5/WjbVMDptS5JQUu9rGPsAxG6+Lj3b3 Z3WJCr16FrhinyVQQ0BqktxEM+FkhH1Z4W84Zn1HbGVKswI1xTFNaADAb3tc/8L3b+oA cLtnAuSx/uYaj5dnrw1BNtuuJj6wEiYZQHfdnE153qFNF7y6MNiAnSf0Y4HMr88asAo4 wBtXIuWTYoypCmN0Jvnz+NoZ1F4efpTzM2NThVhUD9oUNdWkRmoQVrMCncsh0LYxL8/8 Rt/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a129si4667952pgc.79.2019.06.19.20.14.39; Wed, 19 Jun 2019 20:14:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731076AbfFTDOe convert rfc822-to-8bit (ORCPT + 99 others); Wed, 19 Jun 2019 23:14:34 -0400 Received: from mga03.intel.com ([134.134.136.65]:38947 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726370AbfFTDOe (ORCPT ); Wed, 19 Jun 2019 23:14:34 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jun 2019 20:14:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,395,1557212400"; d="scan'208";a="165197511" Received: from pgsmsx106.gar.corp.intel.com ([10.221.44.98]) by orsmga006.jf.intel.com with ESMTP; 19 Jun 2019 20:14:31 -0700 Received: from pgsmsx114.gar.corp.intel.com ([169.254.4.160]) by PGSMSX106.gar.corp.intel.com ([169.254.9.141]) with mapi id 14.03.0439.000; Thu, 20 Jun 2019 11:14:30 +0800 From: "Ong, Boon Leong" To: Andrew Lunn , "Voon, Weifeng" CC: "David S. Miller" , Maxime Coquelin , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Jose Abreu , "Giuseppe Cavallaro" , Florian Fainelli , Alexandre Torgue , "Gomes, Vinicius" Subject: RE: [RFC net-next 1/5] net: stmmac: introduce IEEE 802.1Qbv configuration functionalities Thread-Topic: [RFC net-next 1/5] net: stmmac: introduce IEEE 802.1Qbv configuration functionalities Thread-Index: AQHVJdrXUsdOVQF/k0iKWNkitFHiIaahxnCAgABfNgCAAEIFgIABeMbQ Date: Thu, 20 Jun 2019 03:14:29 +0000 Message-ID: References: <1560893778-6838-1-git-send-email-weifeng.voon@intel.com> <1560893778-6838-2-git-send-email-weifeng.voon@intel.com> <20190619030729.GA26784@lunn.ch> <20190619124433.GC26784@lunn.ch> In-Reply-To: <20190619124433.GC26784@lunn.ch> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzQ1NDcyOTYtNjI1MC00OWNkLTk5NjgtN2JhMGJhZWRlZjE1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRzEzckZXTVlOVEJ1OUE4b0Mzbk94NTcxTk9iQk1nTHUxNVVxQ29cLzZwWFpEWVNSa012UHZoRzdjNlNOczNVNm4ifQ== dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [172.30.20.206] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> > It looks like most o the TSN_WARN should actually be netdev_dbg(). >> > >> > Andrew >> >> Hi Andrew, >> This file is targeted for dual licensing which is GPL-2.0 OR BSD-3-Clause. >> This is the reason why we are using wrappers around the functions so that >> all the function call is generic. > >I don't see why dual licenses should require wrappers. Please explain. > > Thanks > Andrew Agree with the Andrew. We can change those wrapper functions that have serve the internal development needs for multiple OS scaling reason. We will update the kernel codes as suggsted.