Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1537459ybi; Wed, 19 Jun 2019 23:01:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqxRe5hqhxpcn5+zkuEr9Vt6vQLxG4nmnMGm5w6RwsOV+SMVZQBxfKhPcN+v699xZC/5BiMb X-Received: by 2002:a63:4553:: with SMTP id u19mr11319598pgk.420.1561010516026; Wed, 19 Jun 2019 23:01:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561010516; cv=none; d=google.com; s=arc-20160816; b=fjDWFw5aTsUsdJq2oQtTsKvLYVu2PD9Nt5E042w2FMGB+2KVr/VZLnjEM/sWzV+6l7 6GU7o/WQVWEVFWD7hpLSc1PcM8Z3GoyuaRQYPiU14iOnVMgi8ennTuC3K5X29Pt21l9a E3UT4/KTVZmMMqpv6IOYfZ8QQ4rb9hoxJd20vma1ubiLJHnoBMGmhZXYeT+YcZy0+IPI BGRKvO83pR6tDfTzmnfjfxPmKc91XtuSF2M1uTVj94EgqikuE++NSKfbNc4l8x6fSVn1 Qa1hgSg5abH5G7G8ZrBkXGih4LW+eqEZlKHmCGg8pNVQKQ2Az+eD0UfoOsYexs+C9QTa lI6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date; bh=BgyATbFUDV38RVOZYpGFVNcpUG1Zn+tRyeG8ElvQLRY=; b=EpPyzHxLRgcGJcbNlRRp/mZZT+VTYS8hPzko0QXIh9sCCc9E8x7F7kSFL2jasmup8e IESyGUAZjDqulsEU8fTSOvSzHbVCRQmHd7ZuZGeXz+1BZf3h01UgQgQvhx85xUvvHLGE I4UOJIvfe2TGLb0dIHN5+TIsWnJtRRNTPrbT9uM6FrDeoNIWLc1P6Yu0YBL7EPChcEfL Ez1CNk/ApS7vYfO2bPACRMehqghuIoc8KKRtdMRGRbpYoCRfdGvfSXG4iUxjOjeHlzIP YHkcKaXolROITH9DmuhmCMJlDHFHHCmk2JioMIMVBEBgxyyLff5g/KlX0+WgMgzu4cpI VRwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j14si18493860pfe.183.2019.06.19.23.01.38; Wed, 19 Jun 2019 23:01:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726246AbfFTGBV (ORCPT + 99 others); Thu, 20 Jun 2019 02:01:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40386 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725912AbfFTGBV (ORCPT ); Thu, 20 Jun 2019 02:01:21 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7461AC18B2DC; Thu, 20 Jun 2019 06:01:12 +0000 (UTC) Received: from sirius.home.kraxel.org (ovpn-116-212.ams2.redhat.com [10.36.116.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id E81CE1001DDC; Thu, 20 Jun 2019 06:01:08 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 3E0AE1750A; Thu, 20 Jun 2019 08:01:07 +0200 (CEST) Date: Thu, 20 Jun 2019 08:01:07 +0200 From: Gerd Hoffmann To: dri-devel@lists.freedesktop.org, Maarten Lankhorst , Maxime Ripard , Sean Paul , David Airlie , open list , "open list:VIRTIO GPU DRIVER" Subject: Re: [PATCH v3 08/12] drm/virtio: rework virtio_gpu_execbuffer_ioctl fencing Message-ID: <20190620060107.tdz3nrnsczkkv2a6@sirius.home.kraxel.org> References: <20190619090420.6667-1-kraxel@redhat.com> <20190619090420.6667-9-kraxel@redhat.com> <20190619110902.GO12905@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190619110902.GO12905@phenom.ffwll.local> User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 20 Jun 2019 06:01:21 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > Also, I strongly recommend you do a very basic igt to exercise this, i.e. > allocate some buffers, submit them in a dummby op, then close the entire > drmfd. The old version should at least have tripped over kasan, maybe even > oopses somewhere. Hmm, I suspect I have to extend igt for that (adding support for virtio ioctls), right? A quick and dirty test (run webgl demo in firefox, then kill -9 both firefox and Xorg) didn't show any nasty surprises. cheers, Gerd