Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Robert Richter <rrichter@marvell.com>
To:     James Morse <james.morse@arm.com>
CC:     Borislav Petkov <bp@alien8.de>, Tony Luck <tony.luck@intel.com>,
        "Mauro Carvalho Chehab" <mchehab@kernel.org>,
        "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 12/21] EDAC, ghes: Add support for legacy API counters
Thread-Topic: [PATCH 12/21] EDAC, ghes: Add support for legacy API counters
Thread-Index: AQHVJzUqmZqpUctEcEC0DRu/PJtCnQ==
Date:   Thu, 20 Jun 2019 06:55:37 +0000
Message-ID: <20190620065527.qqulgpk6k5wva4mj@rric.localdomain>
References: <20190529084344.28562-1-rrichter@marvell.com>
 <20190529084344.28562-13-rrichter@marvell.com>
 <92eda11f-dad9-bb2b-3a87-80b6c8d8e228@arm.com>
 <20190612184058.2plbdweri6bjmppr@rric.localdomain>
 <c08290d8-3690-efa9-3bc7-37f8b1fdbfd4@arm.com>
In-Reply-To: <c08290d8-3690-efa9-3bc7-37f8b1fdbfd4@arm.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [92.254.182.202]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 5537b901-991f-46be-9492-08d6f54c4c2f
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:MN2PR18MB2894;
x-ms-traffictypediagnostic: MN2PR18MB2894:
x-microsoft-antispam-prvs: <MN2PR18MB28940020696E8F0B02157059D9E40@MN2PR18MB2894.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:10000;
x-forefront-prvs: 0074BBE012
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39850400004)(346002)(366004)(396003)(376002)(136003)(189003)(199004)(73956011)(478600001)(6486002)(66556008)(64756008)(66446008)(66946007)(66476007)(7736002)(14454004)(54906003)(1076003)(5660300002)(86362001)(229853002)(102836004)(6436002)(14444005)(4326008)(256004)(66066001)(81166006)(8676002)(186003)(81156014)(486006)(305945005)(6246003)(26005)(8936002)(446003)(6916009)(53936002)(316002)(71200400001)(71190400001)(99286004)(6116002)(53546011)(6506007)(386003)(2906002)(52116002)(11346002)(68736007)(3846002)(76176011)(476003)(9686003)(25786009)(6512007);DIR:OUT;SFP:1101;SCL:1;SRVR:MN2PR18MB2894;H:MN2PR18MB3408.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 6sen6QRzZD3JjlZxLRlfGuQctKjwzprgqheM7XnLxDeoMYA7iJ7hQUoMaxo/esWJmJvHCNSR4QV1lHlSQkY9DAdr5fJxbFB/Z/m7qGWTGhRBu243iPWMKZWDvlMHedCSFMi0k2eOY9fo3iMNHxBCIMTh3l2IM0cPc2hHks4g4YHWSxQ1i1S2cYExAkJ8A5mfWlJK4ecoy+wstsw5k9RB6U2wiZUef/H/wr4Ujw65iKJC+wRT5Vl933Kq6gdVITWR1eyJPt7nqen/jvbOTrc7P1U7SnmVoFrdnVBOPoZOUIlpj+FznCPxajaXuXcF+unD5iSd2VrZ0HYhnN9c/B+hp0t6FDBNfW2nuYvxU8URoakso5BV0k3QzofYbJAlUB2MrN47G0gLgxd0Zk9N3KbGnIDxe3GhZrnN+Fpa2p6v21Y=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <88686D4A14A84447A87C3F7A393709FA@namprd18.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 5537b901-991f-46be-9492-08d6f54c4c2f
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Jun 2019 06:55:37.4763
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: rrichter@marvell.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR18MB2894
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-20_05:,,
 signatures=0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19.06.19 18:22:32, James Morse wrote:
> > In any case, this patch cleans up code as old API's counter code is
> > isolated and moved to common code. Making the counter's work for ghes
> > is actually a side-effect here. The cleanup is a prerequisit for
> > follow on patches.
>=20
> I'm all for removing/warning-its-broken it when ghes_edac is in use. But =
the convincing
> argument is debian ships a 'current' version of edac-utils that predates =
199747106934,
> (that made all this fake csrow stuff deprecated), and debian's popcon say=
s ~1000 people
> have it installed.

All arm64 distribution kernels that I have checked come with:

CONFIG_EDAC_SUPPORT=3Dy
CONFIG_EDAC=3Dy
CONFIG_EDAC_LEGACY_SYSFS=3Dy
# CONFIG_EDAC_DEBUG is not set
CONFIG_EDAC_GHES=3Dy
CONFIG_EDAC_LAYERSCAPE=3Dm
CONFIG_EDAC_THUNDERX=3Dm
CONFIG_EDAC_XGENE=3Dm

> If you want it fixed, please don't do it as a side effect of cleanup. Fix=
es need to be a
> small separate series that can be backported. (unless we're confident no-=
one uses it, in
> which case, why fix it?)

It is not that I am keen on fixing legacy edac sysfs. It just happens
while unifying the error handlers in ghes_edac and edac_mc. As I see
you are reluctant on just letting it go, let's just disable
EDAC_LEGACY_SYSFS for ARM64. Though, I don't agree with it as there
still could be some userland tools that use this interface that cannot
be used any longer after a transition from x86 to arm64. I leave that
decision up to you. Please just ACK a patch with the Kconfig change
which I will add to my v2 series.

Thanks,

-Robert