Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] KVM: vmx: Fix the broken usage of vmx_xsaves_supported
To:     Xiaoyao Li <xiaoyao.li@linux.intel.com>,
        Wanpeng Li <kernellwp@gmail.com>, Tao Xu <tao3.xu@intel.com>
Cc:     Radim Krcmar <rkrcmar@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        "H. Peter Anvin" <hpa@zytor.com>, kvm <kvm@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
References: <20190620050301.1149-1-tao3.xu@intel.com>
 <CANRm+Cwg7ogTN1w=xNyn+8CfxwofdxRykULFe217pXidzEhh6Q@mail.gmail.com>
 <f358c914-ae58-9889-a8ef-6ea9f3b2650e@linux.intel.com>
 <b3f76acd-cc7e-9cd7-d7f7-404ba756ab87@redhat.com>
 <2032f811-b583-eca1-3ece-d1e95738ff64@linux.intel.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <d9b3e4ff-e14b-1bc5-2a7e-c89b545bb2fc@redhat.com>
Date:   Thu, 20 Jun 2019 10:59:57 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <2032f811-b583-eca1-3ece-d1e95738ff64@linux.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 20/06/19 10:55, Xiaoyao Li wrote:
> 
>> However I may be wrong because I didn't review the code very closely:
>> the old code is obvious and so there is no point in changing it.
> 
> you mean this part about XSS_EXIT_BITMAP? how about the other part in
> vmx_set/get_msr() in this patch?

Yes, only the XSS_EXIT_BITMAP part.  The other is a bugfix, I didn't
understand Wanpeng's objection very well.

Paolo