Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v6 1/2] arm64: tegra: add ACONNECT, ADMA and AGIC nodes
To:     Thierry Reding <thierry.reding@gmail.com>,
        Sameer Pujar <spujar@nvidia.com>
CC:     <robh+dt@kernel.org>, <mark.rutland@arm.com>, <mkumard@nvidia.com>,
        <devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1560945082-24554-1-git-send-email-spujar@nvidia.com>
 <20190620093929.GI26689@ulmo>
From:   Jon Hunter <jonathanh@nvidia.com>
Message-ID: <5da5b498-cbc7-26dd-bd68-7f2376eb6b30@nvidia.com>
Date:   Thu, 20 Jun 2019 11:01:05 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.7.0
MIME-Version: 1.0
In-Reply-To: <20190620093929.GI26689@ulmo>
Content-Type: text/plain; charset="windows-1252"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 20/06/2019 10:39, Thierry Reding wrote:
> On Wed, Jun 19, 2019 at 05:21:21PM +0530, Sameer Pujar wrote:
>> Add DT nodes for following devices on Tegra186 and Tegra194
>>  * ACONNECT
>>  * ADMA
>>  * AGIC
>>
>> Signed-off-by: Sameer Pujar <spujar@nvidia.com>
>> ---
>>  changes in current revision
>>    * updated ranges property for aconnect
>>    * renamed agic node
>>
>>  arch/arm64/boot/dts/nvidia/tegra186.dtsi | 67 ++++++++++++++++++++++++++++++++
>>  arch/arm64/boot/dts/nvidia/tegra194.dtsi | 67 ++++++++++++++++++++++++++++++++
>>  2 files changed, 134 insertions(+)
> 
> Applied to for-5.3/arm64/dt, thanks.
> 
> I ended up deciding to put the aconnect node among the nodes with unit-
> addresses, in the numerical order that it would fit in if the top-level
> aconnect node didn't exist. I think that looks much more consistent in
> the end, even though it's slightly bending the rules that we have.

Thanks. Good point, I had not thought that bit through. Works for me,
especially as the aconnect bus has a ranges property and so is
associated with an address range.

Cheers
Jon

-- 
nvpublic