Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1561010100-14080-1-git-send-email-laoar.shao@gmail.com> <e5c695c9-2006-f2cb-e3e2-7ea8ee465817@i-love.sakura.ne.jp>
In-Reply-To: <e5c695c9-2006-f2cb-e3e2-7ea8ee465817@i-love.sakura.ne.jp>
From:   Yafang Shao <laoar.shao@gmail.com>
Date:   Thu, 20 Jun 2019 18:10:06 +0800
Message-ID: <CALOAHbCe9J0pOCW03dW+C4NK__amTKttAs=eNHXwvPPf5Lpwhw@mail.gmail.com>
Subject: Re: [PATCH] hung_task: recover hung task warnings in next check interval
To:     Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Dmitry Vyukov <dvyukov@google.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 20, 2019 at 6:03 PM Tetsuo Handa
<penguin-kernel@i-love.sakura.ne.jp> wrote:
>
> On 2019/06/20 14:55, Yafang Shao wrote:
> > When sys_hung_task_warnings reaches 0, the hang task messages will not
> > be reported any more.
>
> It is a common mistake that sys_hung_task_warnings is already 0 when
> a real problem which should be reported occurred.
>
> >
> > If the user want to get more hung task messages, he must reset
> > kernel.hung_task_warnings to a postive integer or -1 with sysctl.
>
> People are setting sys_hung_task_warnings to -1 in order to make sure
> that the messages are printed.
>
> > This is not a good way for the user.
>
> But I don't think we should reset automatically.
>
> > We'd better reset hung task warnings in the kernel, and then the user
> > don't need to pay attention to this value.
>
> I suggest changing the default value of sys_hung_task_warnings to -1.
>

Yes, that's what we have did now.

> >
> > With this patch, hung task warnings will be reset with
> > sys_hung_task_warnings setting in evenry check interval.
>
> Since it is uncommon that the messages are printed for more than 10
> times for one check_hung_uninterruptible_tasks() call, this patch is
> effectively changing to always print the messages (in other words,
> setting -1).

If sys_hung_task_warnings can't be recovered, does it make sense to exist?
In which case do we need this setting ?

Btw, why the default value of this setting is 10, instead of -1 ?

Thanks
Yafang