Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1760241ybi; Thu, 20 Jun 2019 03:20:54 -0700 (PDT) X-Google-Smtp-Source: APXvYqw0HJWCeoEmXWioAexyuUYDFvdEndAJ5ivOg5mnIhkYsKDzAaPZaibUc3cS7+rYEa5ZuOeY X-Received: by 2002:a17:90a:374f:: with SMTP id u73mr2339272pjb.4.1561026053911; Thu, 20 Jun 2019 03:20:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561026053; cv=none; d=google.com; s=arc-20160816; b=kFM4dZwxKLBdjQDKJ2E/mmBTkDohW49/NrxVWuPRymCD8viVeDMMim/6Y+2rHF+RJL i9YTIlXB6e4oNrLw5uR2SQdrXUIe+x+12q6fyPlAJq11gFTpFnAKVFkEmKfdnP3mxmeq C1G2J++G59siBNDa2CmjuldZW2S0T/8CHESrjDr2R78/GurMIn+fV5MzI8ljOwIYZ2+D 815/WYvV2SctYCCzCUA0hu1dzJJG13oaxwVT3v6oxAS4LANPcIKtHlaT0Apv4GWh9YKm bV3emEKM4PwHUfwo3X+1cNZuHQm2Zfaf8fU1D+cax/sQtw838Fstq7sahIqSCvkk94+f Ey8w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=D1P8K5/n5tdiQEfDoAnlZWz2tdtrmxTMIKbsHgFf5T8=; b=LDMwDhyMqv5yPS+BP/1U6zqW+N6G/nQsqkUOxB3uq4cvbBh59XBRlJmBef9F4wVLkP Y7S7YWZjo3bjhFQtKX4DLNT10sNKvzerq54v5GHfVC0pZuWzURjlYdvrrRorMw6+QtUZ NdWKAuKzC9u89k9Q4IAMZAWaHqDzKy3Dwa/PhOpy5RxNxr/oTrer3J+8H5rB4R1/pHNQ sVewgcJ6rpCb7CqUw7mYq9m7OmuugdDkOnH5gaJfA6aaDAMkrHzlQPO5fva0D10Ih3RV xMy6IccV8c34oUEX2FJ5UNF6Gdkx8Rw+r64NHCCyX++lhuhOu0kjqn+5NjxKH6MqODLH 8GfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z19si17465078pfa.260.2019.06.20.03.20.37; Thu, 20 Jun 2019 03:20:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726506AbfFTKUW (ORCPT + 99 others); Thu, 20 Jun 2019 06:20:22 -0400 Received: from mail.us.es ([193.147.175.20]:38796 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726268AbfFTKUW (ORCPT ); Thu, 20 Jun 2019 06:20:22 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 9FFDDEA477 for ; Thu, 20 Jun 2019 12:20:18 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 8A1FCDA70A for ; Thu, 20 Jun 2019 12:20:18 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 6C5B4DA704; Thu, 20 Jun 2019 12:20:18 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 3E125DA704; Thu, 20 Jun 2019 12:20:16 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Thu, 20 Jun 2019 12:20:16 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 12DDD4265A2F; Thu, 20 Jun 2019 12:20:16 +0200 (CEST) Date: Thu, 20 Jun 2019 12:20:15 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Arnd Bergmann Cc: Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , Fernando Fernandez Mancera , wenxu , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] netfilter: synproxy: fix building syncookie calls Message-ID: <20190620102015.gzanaci6aztfhv76@salvia> References: <20190619125500.1054426-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190619125500.1054426-1-arnd@arndb.de> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 19, 2019 at 02:54:36PM +0200, Arnd Bergmann wrote: > When either CONFIG_IPV6 or CONFIG_SYN_COOKIES are disabled, the kernel > fails to build: > > include/linux/netfilter_ipv6.h:180:9: error: implicit declaration of function '__cookie_v6_init_sequence' > [-Werror,-Wimplicit-function-declaration] > return __cookie_v6_init_sequence(iph, th, mssp); > include/linux/netfilter_ipv6.h:194:9: error: implicit declaration of function '__cookie_v6_check' > [-Werror,-Wimplicit-function-declaration] > return __cookie_v6_check(iph, th, cookie); > net/ipv6/netfilter.c:237:26: error: use of undeclared identifier '__cookie_v6_init_sequence'; did you mean 'cookie_init_sequence'? > net/ipv6/netfilter.c:238:21: error: use of undeclared identifier '__cookie_v6_check'; did you mean '__cookie_v4_check'? > > Fix the IS_ENABLED() checks to match the function declaration > and definitions for these. Applied, thanks Arnd.