Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030461AbVKWWqz (ORCPT ); Wed, 23 Nov 2005 17:46:55 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030460AbVKWWqz (ORCPT ); Wed, 23 Nov 2005 17:46:55 -0500 Received: from xenotime.net ([66.160.160.81]:17370 "HELO xenotime.net") by vger.kernel.org with SMTP id S1030454AbVKWWqw (ORCPT ); Wed, 23 Nov 2005 17:46:52 -0500 Date: Wed, 23 Nov 2005 14:46:51 -0800 (PST) From: "Randy.Dunlap" X-X-Sender: rddunlap@shark.he.net To: Adrian Bunk cc: Andrew Morton , Arjan van de Ven , linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static In-Reply-To: <20051123223505.GF3963@stusta.de> Message-ID: References: <20051123033550.00d6a6e8.akpm@osdl.org> <20051123223505.GF3963@stusta.de> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 833 Lines: 27 On Wed, 23 Nov 2005, Adrian Bunk wrote: > Every inline dummy function should be static. Please explain why it matters in this case. > Signed-off-by: Adrian Bunk > > --- linux-2.6.15-rc2-mm1-full/init/main.c.old 2005-11-23 16:50:45.000000000 +0100 > +++ linux-2.6.15-rc2-mm1-full/init/main.c 2005-11-23 16:50:55.000000000 +0100 > @@ -101,7 +101,7 @@ > static inline void acpi_early_init(void) { } > #endif > #ifndef CONFIG_DEBUG_RODATA > -inline void mark_rodata_ro(void) { } > +static inline void mark_rodata_ro(void) { } > #endif > > #ifdef CONFIG_TC -- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/