Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030465AbVKWWyo (ORCPT ); Wed, 23 Nov 2005 17:54:44 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030469AbVKWWyn (ORCPT ); Wed, 23 Nov 2005 17:54:43 -0500 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:21011 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S1030468AbVKWWyl (ORCPT ); Wed, 23 Nov 2005 17:54:41 -0500 Date: Wed, 23 Nov 2005 23:54:40 +0100 From: Adrian Bunk To: "Randy.Dunlap" Cc: Andrew Morton , Arjan van de Ven , linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static Message-ID: <20051123225440.GJ3963@stusta.de> References: <20051123033550.00d6a6e8.akpm@osdl.org> <20051123223505.GF3963@stusta.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.11 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1253 Lines: 41 On Wed, Nov 23, 2005 at 02:46:51PM -0800, Randy.Dunlap wrote: > On Wed, 23 Nov 2005, Adrian Bunk wrote: > > > Every inline dummy function should be static. > > Please explain why it matters in this case. We don't need an additional global copy of the function. > > Signed-off-by: Adrian Bunk > > > > --- linux-2.6.15-rc2-mm1-full/init/main.c.old 2005-11-23 16:50:45.000000000 +0100 > > +++ linux-2.6.15-rc2-mm1-full/init/main.c 2005-11-23 16:50:55.000000000 +0100 > > @@ -101,7 +101,7 @@ > > static inline void acpi_early_init(void) { } > > #endif > > #ifndef CONFIG_DEBUG_RODATA > > -inline void mark_rodata_ro(void) { } > > +static inline void mark_rodata_ro(void) { } > > #endif > > > > #ifdef CONFIG_TC > > -- > ~Randy cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/