Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1866594ybi; Thu, 20 Jun 2019 05:18:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqy103CjS5vH2ukmcrHzQ2rCSnbVBZqdklLnppn/VwbptQfuApiixMe8WY/+DrksjFCqZDd7 X-Received: by 2002:a65:638a:: with SMTP id h10mr13069787pgv.64.1561033117162; Thu, 20 Jun 2019 05:18:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561033117; cv=none; d=google.com; s=arc-20160816; b=faAgOnF/dnwDHIf0y/MNjebVn3JSSsIBX4d1IyPkRrVYJ+uQZD7rzFLxwSkCfbsYIP aqTffngr6Nq/TP0B4wPhFbAZDKTSD6y61frUZbULVgxyVJXqHGvYNIin7gDdZfuGpcxJ +6wELP7znV2RiyGj4rWcoL4MdsepCYTs62L+bVDe6vy9eXs2fd0kbscv9MJSHGkVCoQ/ ALJIbltJRUjnA3f9KRaGq9GTw89hp0tGkNIk4tD4hRKGGu5bilJ6IN8V7LA6rUhvreO0 trW/6eBX5Xe8CsSIBvVOmqONKsYDOs0jYycNARidH/JnonaULMRkttDjxR3dz8+wQAvr zh2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:subject:cc:to:from:date:dkim-signature; bh=4zAd6zvzq0nDhAcG0RWZmb/chIyTJOpxV0fMjTQPU7Q=; b=OG1trAu7H7vxBKiLf1RVuMICpy0cGOjaXkCdZNXJEoxfCmFQiwoBdXUMFaJbmFk4wH dX+LG7Q2lLGTDo3fXj2iB3EEbiQYd8fdls1eHvPXeBrFA9ssbqetaPP6ONql0Wz9XCzl eN/DrOsdDdJdp+7EpAxMqnppPYX1wJqwdOjmTbBbwqy9cKxgWL2jtnkImrS+POKMlN86 Gsi6+YkhsjjZf5EvPsnGsRfDpKY5McQt1A0BP2vYpPincIcNIcE8qlPFcuC7CyenT0HP sYGRs4qE8S5fJ+D20NwxcJTe9KLIU//nNVfUrQ0xaWjr00yRTAxam4Iai9jQapnz+7rq BCYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wWnIlZri; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 18si5675249pgw.101.2019.06.20.05.18.21; Thu, 20 Jun 2019 05:18:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=wWnIlZri; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731797AbfFTMRm (ORCPT + 99 others); Thu, 20 Jun 2019 08:17:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:43844 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730886AbfFTMRm (ORCPT ); Thu, 20 Jun 2019 08:17:42 -0400 Received: from devnote2 (NE2965lan1.rev.em-net.ne.jp [210.141.244.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6C4732080C; Thu, 20 Jun 2019 12:17:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561033061; bh=4HHw+Qp9H8V6fIHDzF9H81gSOxHTNJsMIKqmfY8FN5U=; h=Date:From:To:Cc:Subject:From; b=wWnIlZri2kxT/nVZV5on/30xs5MxQPQKduIZbSz+ZVepm9GPxHfB+ByXIoEp7twuA Gw0iqjZ7/1r7svIJ4PFNskjJDTa5Lm6YrYpyGIkGZF3BrHbnef7COwAnqg2u0rPkPV S13vc9/seZPKRGMkLHjOKNGZQV8GXBjy20WLrZDI= Date: Thu, 20 Jun 2019 21:17:37 +0900 From: Masami Hiramatsu To: Tom Zanussi Cc: linux-kernel@vger.kernel.org, Steven Rostedt Subject: No invalid histogram error Message-Id: <20190620211737.993b09619af1fc58222549b4@kernel.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Tom, I'm trying to use histogram on a synthetic event, but faced an odd situation. There is a synthetic event, which has foo and bar. /sys/kernel/debug/tracing # cat synthetic_events testevent int foo; int bar And when I tried to add hist on trigger, both foo and bar can be used as below. /sys/kernel/debug/tracing # echo "hist:keys=bar" > events/synthetic/testevent/trigger /sys/kernel/debug/tracing # echo "hist:keys=foo" > events/synthetic/testevent/trigger And, when I missed to specify the sort key, it failed /sys/kernel/debug/tracing # echo "hist:keys=foo:sort=bar" > events/synthetic/testevent/trigger sh: write error: Invalid argument But no error on error_log file. /sys/kernel/debug/tracing # cat error_log /sys/kernel/debug/tracing # Could you add some error message? What about below? [ 5422.134656] hist:synthetic:testevent: error: Sort key must be one of keys. Command: keys=foo;sort=bar ^ Thank you, -- Masami Hiramatsu