Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1888849ybi; Thu, 20 Jun 2019 05:42:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqw/O/lDXOeTrM/CgB7LPC3RYSZAdXEtNgpasLurRzKuM2XyS9pGqPkgAnf3oSr8fQbbboSg X-Received: by 2002:aa7:8203:: with SMTP id k3mr124782461pfi.124.1561034562778; Thu, 20 Jun 2019 05:42:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561034562; cv=none; d=google.com; s=arc-20160816; b=mJJuGqYlNNmccbk+hUMnjvjSdFSBVVXyQEPPvEabNScjZ9lov6wKtgaO8v1+Als0YI 1YbPJ674x64fpfj+HkNsgL2rxL77uRYeE799b6YZHZ5/cku68UMl7DBDjVKYP7lNhbnl PwYCr6spCWGEdhsHufkAknp9Ypm+jjsoneHOl8PP0E04sXSQqkl8p8lnidXQFHAp64ks klkynJbsrQ7SC2UVPJeAeAfM8C1zuX/Qer9grAI2nLprgkpu8hWRdkM6sNlJwHUHKCNp hLA0eijJPY/HxzIsFpdzrjE+9Btkpyqpw5gnzA/86pIczJQHZADpy4xYwGZkZzR+JVKE vqwg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=oEI7F/AbEhScv3JnMYlB7Pd/hzM4EXTzmC95auXuTwE=; b=aGbZNcxWinuLtYyoyfEIFEfdo0dktOK7s7SqCbRtQjf3USLQ8yPETrlm8lQ0sjUdyP Jkyuw+MoqpbvVva2a8MlkjYuxwNGoO4b1zVNR03LIjaFaC8E0gcQLQ02VNkznit1prJE PTG8Wicgqzc85ttAYoiQVMMGT5VMVZpdCnl0tdD83ve6X7uhs2695o/8/cDAf2EgpsBR G5hPOs5p46g8Z4nhLVNIELuAeArphzbffSgJd1+klkMIz9xsRlPITGoU0ka8pEQtt8tH J+CxVN1VMrTcy4KQzn7HUhNtzpCjihDeSnWqQBI/1/8IeDDzimnRjb/8W5IlLYTkek7Y 7Eqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@lixom-net.20150623.gappssmtp.com header.s=20150623 header.b=BWIZu1Wk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f62si18745212plf.88.2019.06.20.05.42.27; Thu, 20 Jun 2019 05:42:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@lixom-net.20150623.gappssmtp.com header.s=20150623 header.b=BWIZu1Wk; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731751AbfFTMmR (ORCPT + 99 others); Thu, 20 Jun 2019 08:42:17 -0400 Received: from mail-io1-f65.google.com ([209.85.166.65]:36490 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726874AbfFTMmR (ORCPT ); Thu, 20 Jun 2019 08:42:17 -0400 Received: by mail-io1-f65.google.com with SMTP id h6so1497401ioh.3 for ; Thu, 20 Jun 2019 05:42:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=lixom-net.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oEI7F/AbEhScv3JnMYlB7Pd/hzM4EXTzmC95auXuTwE=; b=BWIZu1WkOi4mG09pZuVLraenQ5r3WFzHz+rr+WaW3hWkxe0XX8c1yhGBpP2xGI+8VO g833PXYqSzTouCtTuOa0scSHSdZmcaG937NuYsZe1WZBNaXrhDrUrnfu2i0eAUJsK2Zz sDMrA2iux2hUIvQREc1CjSf50GBP8mljYmtkTohchCrNO410WVTBnGpxqpEi0/TSsRiw XOS/wb9mID5DzAkoYJ2DCMxiS0jcHNJ/KsfvAv1KSU7AaFcTQfFK7Af86qWindUttg0d NKz8LUkNAwMJSx9hLW5INTOHG3dvaW03ULFRXEDR3zImfXON4wZp3wG0UyoAR64Mui7Z G9BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oEI7F/AbEhScv3JnMYlB7Pd/hzM4EXTzmC95auXuTwE=; b=bx+xLHGlZVXWgS9DXBVs2h6v9Me8YWyfRCqpIGqz2qFF12qya8FGWUCorHotW0FVDz Yp1IPzlt+9wbhdQpimAiC09o5v7upU012l6rBlub9ZLabfd610fGyG0ppAZVJ8rNyBAc yn2CrXc5SLLHxSTcJxXSBv39jHmJySO+Tgy8cCa9I8+LBnUyEa2DmTs3+JkwovGAw/uS 38+UmFCtlJFAE8tb3dHHuCAPyu0tvfzODo8h0e6psDbi/PHmGeFD+HPm/3pfaJCaVhmM 1/Ucg1ljL3oCL9geRrMY+Ixd1esjHK+Q2KClr6IB3/ghSEfC6SFqYZD6Zb9hEz+m3xvR +Agg== X-Gm-Message-State: APjAAAWts75DZmiKGJFMecdPYVDVa4d3G5f1/sGV8HG2WuLonmv7TOZT FyOlm6lh73rg4RJq+ij8uuodvNAihaK2013sGQFn/Q== X-Received: by 2002:a02:394c:: with SMTP id w12mr154066jae.126.1561034534821; Thu, 20 Jun 2019 05:42:14 -0700 (PDT) MIME-Version: 1.0 References: <1561026716-140537-1-git-send-email-john.garry@huawei.com> In-Reply-To: <1561026716-140537-1-git-send-email-john.garry@huawei.com> From: Olof Johansson Date: Thu, 20 Jun 2019 13:42:03 +0100 Message-ID: Subject: Re: [PATCH 0/5] Fixes for HiSilicon LPC driver and logical PIO code To: John Garry Cc: xuwei5@huawei.com, Bjorn Helgaas , Linuxarm , ARM-SoC Maintainers , Linux Kernel Mailing List , linux-pci@vger.kernel.org, Joe Perches Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi John, For patches that go to a soc maintainer for merge, we're asking that people don't cc arm@kernel.org directly. We prefer to keep that alias mostly for pull requests from other maintainers and patches we might have a reason to apply directly. Otherwise we risk essentially getting all of linux-arm-kernel into this mailbox as well. Thanks! -Olof On Thu, Jun 20, 2019 at 11:33 AM John Garry wrote: > > As reported in [1], the hisi-lpc driver has certain issues in handling > logical PIO regions, specifically unregistering regions. > > This series add a method to unregister a logical PIO region, and fixes up > the driver to use them. > > RCU usage in logical PIO code looks to always have been broken, so that > is fixed also. This is not a major fix as the list which RCU protects is > very rarely modified. > > There is another patch to simplify logical PIO registration, made possible > by the fixes. > > At this point, there are still separate ongoing discussions about how to > stop the logical PIO and PCI host bridge code leaking ranges, as in [2]. > > Hopefully this series can go through the arm soc tree and the maintainers > have no issue with that. I'm talking specifically about the logical PIO > code, which went through PCI tree on only previous upstreaming. > > Cc. linux-pci@vger.kernel.org > > [1] https://lore.kernel.org/lkml/1560770148-57960-1-git-send-email-john.garry@huawei.com/ > [2] https://lore.kernel.org/lkml/4b24fd36-e716-7c5e-31cc-13da727802e7@huawei.com/ > > John Garry (5): > lib: logic_pio: Fix RCU usage > lib: logic_pio: Add logic_pio_unregister_range() > bus: hisi_lpc: Unregister logical PIO range to avoid potential > use-after-free > bus: hisi_lpc: Add .remove method to avoid driver unbind crash > lib: logic_pio: Enforce LOGIC_PIO_INDIRECT region ops are set at > registration > > drivers/bus/hisi_lpc.c | 43 ++++++++++++++++++--- > include/linux/logic_pio.h | 1 + > lib/logic_pio.c | 78 ++++++++++++++++++++++++++++----------- > 3 files changed, 95 insertions(+), 27 deletions(-) > > -- > 2.17.1 >