Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1959130ybi; Thu, 20 Jun 2019 06:52:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqyjpX2Se7QBF/SszYg4f4iM5RtPakq7ac0GQ1w7W5max5HPdmdg0hituDF0dButT/qvki7/ X-Received: by 2002:a62:2c8e:: with SMTP id s136mr86963748pfs.3.1561038770055; Thu, 20 Jun 2019 06:52:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561038770; cv=none; d=google.com; s=arc-20160816; b=Dw19ZzFYAepGCqDBia38idtWb2YZ13yvTXPR05ael3hB6Hq0rYo//Y5bKfS0qzExcN HPaun5tkxmCf9Nu6K6wBPNlDR2xmf27T90h88Z8Bc/AkO6vOnmDVfhmIaAWt/+mluuaC fMF5WaoWw7M8zNYplXLXu6PFZKwVccZUsdOX9KdbIW55XzhrAM1EMhSX7NLMFJuqJiDj vLMCMKG0P/RqgFV40vSYdxXQQJVQig7i/0neehzuHFSQYZHTTArIYtjw8nRkM0PJc/+N Fs97dcLTWVmfENxDxKIioGCiQg9mUcYx4FUVy2UDD/eVmN8BGbQ8ap1SDDdObYekGmhh HDBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=2IFwlqbKib7dWbeVbv8X2YweFdeF4XDbaSTOpsTFt9E=; b=dwPzHtF8Kckp3uzkYs2Lb1bVQDrHJvDqkWPKZ37xFXzd6wfIYr8iUvG/IngVsXK3Hv N1Bx4KFAmKMJLJF1CWHaqcDTV1MpsYxVZT4VPHi8UwX0oT/7R3TVsh6W/2v8Y132pYZZ WZY3+fMpVXKImLKpJm5yzT3VskJmcSkYlHMaSbTepHaDjuqI7fNM1Yi5Ou2hdHO3zwKF Yp3XEai++O7HBSAsnaZQzUGX2OY/keNgd8phs4sPjahVNtVqxB9s2RtHrSpLuN2bIIE5 +4UvehII3im+WsXotFbmVJtZn0tzkkrHHTFbXQ1oDS7EBecMaNH0rzWYIVqzCgksfk9i OE4g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cnBfFGGl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 205si5618637pgb.424.2019.06.20.06.52.34; Thu, 20 Jun 2019 06:52:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=cnBfFGGl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732112AbfFTNvF (ORCPT + 99 others); Thu, 20 Jun 2019 09:51:05 -0400 Received: from mail-ua1-f68.google.com ([209.85.222.68]:36347 "EHLO mail-ua1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732105AbfFTNvE (ORCPT ); Thu, 20 Jun 2019 09:51:04 -0400 Received: by mail-ua1-f68.google.com with SMTP id v20so1682359uao.3 for ; Thu, 20 Jun 2019 06:51:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2IFwlqbKib7dWbeVbv8X2YweFdeF4XDbaSTOpsTFt9E=; b=cnBfFGGl3pJdpKp1MmBsF47mWvkNWCygNpH36R5cENrnDyoojF55rqerYfDLfwbbTj RFNj58C5CUCULzDhnJhuuGUawX8GzXHIVIZhOz7jX/xVeIdC14e76z4ee9EhQzScRn3r yZyPrtDQwDjqyu6vqRuq4CLTKqp19vhLDP1kzyZlJral0qqZUmCvS5srHMy+sgfXo7OX 8J3/HDJJtVqUJPoO9R3c2uQaBqDPo5Hb8yFlY4a3lZNrdJXrZ2uvs7wDiEP1uZSr6Jfu RATefM9/IOvINHrRt3pDF9AMIZimpQikwZUjdX3vOvvUC0JBvtUIxqFbJK3SbyUB77sX swNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2IFwlqbKib7dWbeVbv8X2YweFdeF4XDbaSTOpsTFt9E=; b=iD0er6Kywd7CFhvH/O5XKooUN89xeof9bohyQYuAX4X83T3ILNZGu3RMSUNgWnkl06 dn03oBvfYE2jzub2C1rpMr+DUoqNgnzmai+o9ok1mshFi3e2ZKWUPlSwYP8FhR6oRQyL e/9/tQW/XHd/GxA5iuFKaP1w56XRABEXYdp6x5dOh3W57Tzq8mCy2YX64YC+esZ827M+ SoVhpsnbST14Eyf6FJvApByxjAiAnmj0PkmtNPnbk6w0Qa11EOAd80Jgecj0DOTMbp3Z gg3hXhxOfUXYMl9zgmmqS5UpF/TmVHIk+Zux5HJwi02K+vVjUdFOiY8asyee+Uqe6o6J U+SQ== X-Gm-Message-State: APjAAAUAEL5RozifVXmBaruxGq97W2oQLtSZpkfV+l8uZNqAz5lpGN7f L2jp6EaEUohSsMLEyALS9kV1PFbRK3hv4oVRevIwWg== X-Received: by 2002:a9f:242e:: with SMTP id 43mr8151929uaq.100.1561038663128; Thu, 20 Jun 2019 06:51:03 -0700 (PDT) MIME-Version: 1.0 References: <1559577325-19266-1-git-send-email-ludovic.Barre@st.com> <5b7e1ae5-c97e-5a21-fc3e-7cc328087f04@st.com> In-Reply-To: From: Ulf Hansson Date: Thu, 20 Jun 2019 15:50:26 +0200 Message-ID: Subject: Re: [PATCH V3 0/3] mmc: mmci: add busy detect for stm32 sdmmc variant To: Ludovic BARRE Cc: Rob Herring , Srinivas Kandagatla , Maxime Coquelin , Alexandre Torgue , Linux ARM , Linux Kernel Mailing List , DTML , "linux-mmc@vger.kernel.org" , linux-stm32@st-md-mailman.stormreply.com Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ludovic, On Thu, 13 Jun 2019 at 15:13, Ulf Hansson wrote: > > On Thu, 13 Jun 2019 at 15:02, Ludovic BARRE wrote: > > > > hi Ulf > > > > Just a "gentleman ping" about this series. > > I know you are busy, it's just to be sure you do not forget me :-) > > Thanks! I started briefly to review, but got distracted again. I will > come to it, but it just seems to take more time than it should, my > apologies. Alright, so I planned to review this this week - but failed. I have been overwhelmed with work lately (as usual when vacation is getting closer). I need to gently request to come back to this as of week 28, when I will give this the highest prio. Again apologize for the delays! Kind regards Uffe > > Br > Uffe > > > > > Regards > > Ludo > > > > On 6/3/19 5:55 PM, Ludovic Barre wrote: > > > From: Ludovic Barre > > > > > > This patch series adds busy detect for stm32 sdmmc variant. > > > Some adaptations are required: > > > -Clear busy status bit if busy_detect_flag and busy_detect_mask are > > > different. > > > -Add hardware busy timeout with MMCIDATATIMER register. > > > > > > V3: > > > -rebase on latest mmc next > > > -replace re-read by status parameter. > > > > > > V2: > > > -mmci_cmd_irq cleanup in separate patch. > > > -simplify the busy_detect_flag exclude > > > -replace sdmmc specific comment in > > > "mmc: mmci: avoid fake busy polling in mmci_irq" > > > to focus on common behavior > > > > > > Ludovic Barre (3): > > > mmc: mmci: fix read status for busy detect > > > mmc: mmci: add hardware busy timeout feature > > > mmc: mmci: add busy detect for stm32 sdmmc variant > > > > > > drivers/mmc/host/mmci.c | 49 +++++++++++++++++++++++++++++++++++++++++-------- > > > drivers/mmc/host/mmci.h | 3 +++ > > > 2 files changed, 44 insertions(+), 8 deletions(-) > > >