Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1972758ybi; Thu, 20 Jun 2019 07:05:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqxppVcwTsdMoYoxP2teZ3MKuuDcQ8cb1UNxR5qmbQ4uIfL0famS0VIYrWjUxaAou0JEIJIk X-Received: by 2002:a17:90a:b903:: with SMTP id p3mr3225068pjr.79.1561039553830; Thu, 20 Jun 2019 07:05:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561039553; cv=none; d=google.com; s=arc-20160816; b=JmuxRVPT7rQX6m1UK8leMeYaCML+qSiSDWQmB1rzT+njlaj9kr6C12LdUHRMeEQssw 2i+TemDV802DwR7+K2FUU8ritXaXRVa6Tlc76vtWKYZRoJ1t1DSKKQmFnS8UGROSOMX2 8zonScb7dlfBtjBTchK5gqKT2I6wmESCQxJHfHz+LbzbznnVtYZi2k7e8hqMQSeVZrrG ONstloMKE+ExLqQcZLQ8ifs9jtW1Yu6UtJrexH+aHlKR7Qw/Iwl8DmusV1x8Zkp9nxgm FM7Zxaz8MoLz356G2xzFY3XZSulcV42aqoih6O2cLnyQQS//wMvJlIRl7Ahr7mTfmVFW YzRw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject; bh=kk0iROuiBw86L8JMDa5UasFqeu4eaEGk4Y4zy76zYa0=; b=YMCOUWdyb8jfYA1bCDH4KihPA/e/m+mTLUr8zFTKF2VPTcXq2v5h+tHX05lXNS+a/d Yibx1eU3sN2tywvlGSCp2rvGx6rr8ndw+AmdrA3YP7u/brKGMfzqYy6TQFIvUyhaL4Nr cU9jhKMEHTX+B3JC09iSKUfE1G67xdudM4L7sf1lMPabGPjXXwLkW3jwaw71Oj2CfieJ EIRTN/K0lGWe6fkwveEavPEx1BEEvYlm2pySrTvT2+ozBRjUYU7x1jvte7ln4+X+bgbj JaxFciyN4UhUEPDxgShA2nzxNzqLm3Yk2YytzepMb/WhbXEJaNOhwKG4vxMzz0zoLk4S n1mQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=FMk4shXH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c5si5836784pgd.182.2019.06.20.07.05.36; Thu, 20 Jun 2019 07:05:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=FMk4shXH; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731956AbfFTOF3 (ORCPT + 99 others); Thu, 20 Jun 2019 10:05:29 -0400 Received: from hqemgate14.nvidia.com ([216.228.121.143]:11708 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726562AbfFTOF2 (ORCPT ); Thu, 20 Jun 2019 10:05:28 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 20 Jun 2019 07:05:25 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 20 Jun 2019 07:05:26 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 20 Jun 2019 07:05:26 -0700 Received: from [10.21.132.148] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 20 Jun 2019 14:05:24 +0000 Subject: Re: [PATCH net-next 3/3] net: stmmac: Convert to phylink and remove phylib logic From: Jon Hunter To: Jose Abreu , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" CC: Joao Pinto , "David S . Miller" , Giuseppe Cavallaro , Alexandre Torgue , Russell King , Andrew Lunn , Florian Fainelli , Heiner Kallweit , linux-tegra References: <6226d6a0de5929ed07d64b20472c52a86e71383d.1560266175.git.joabreu@synopsys.com> <78EB27739596EE489E55E81C33FEC33A0B9C8D6E@DE02WEMBXB.internal.synopsys.com> <26cfaeff-a310-3b79-5b57-fd9c93bd8929@nvidia.com> <78EB27739596EE489E55E81C33FEC33A0B9C8DD9@DE02WEMBXB.internal.synopsys.com>

<6f36b6b6-8209-ed98-e7e1-3dac0a92f6cd@nvidia.com> Message-ID: <7f0f2ed0-f47c-4670-d169-25f0413c1fd3@nvidia.com> Date: Thu, 20 Jun 2019 15:05:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <6f36b6b6-8209-ed98-e7e1-3dac0a92f6cd@nvidia.com> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL107.nvidia.com (172.20.187.13) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1561039525; bh=kk0iROuiBw86L8JMDa5UasFqeu4eaEGk4Y4zy76zYa0=; h=X-PGP-Universal:Subject:From:To:CC:References:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=FMk4shXHyUbeAy1dildJ33Lcn3gZ2iR/fQjUlgiuSdiiES3WHLIV9lz409RfTMOJ1 GtXnMNJB5cYBuyP9R24/pinO1sWsYrELeJiRFD0cQxHHguiE6fbLbuLES3oix3t92n F4eyUg9mbIyrLWFVdpBKvOOTqtffCQ7fwfcq57AhvVP7WxKmCppZvbifhTO7yBd2Tt 8YPZWiSDbZ3AkQkelKGq4TuYmv+wfI4o/Gy9fktBMcI+cW4yt0Rc3Euh+2K5XRiKEF J87DSIyAM6fZQlDOkJA8xeiEqL2R+/JvuSKyj6BornoIZ3E9T5bJz5veXRm/lUVsfB NVigdYX6UlNyQ== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 18/06/2019 20:44, Jon Hunter wrote: > > On 18/06/2019 16:20, Jon Hunter wrote: >> >> On 18/06/2019 11:18, Jon Hunter wrote: >>> >>> On 18/06/2019 10:46, Jose Abreu wrote: >>>> From: Jon Hunter >>>> >>>>> I am not certain but I don't believe so. We are using a static IP address >>>>> and mounting the root file-system via NFS when we see this ... >>>> >>>> Can you please add a call to napi_synchronize() before every >>>> napi_disable() calls, like this: >>>> >>>> if (queue < rx_queues_cnt) { >>>> napi_synchronize(&ch->rx_napi); >>>> napi_disable(&ch->rx_napi); >>>> } >>>> >>>> if (queue < tx_queues_cnt) { >>>> napi_synchronize(&ch->tx_napi); >>>> napi_disable(&ch->tx_napi); >>>> } >>>> >>>> [ I can send you a patch if you prefer ] >>> >>> Yes I can try this and for completeness you mean ... >>> >>> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >>> index 4ca46289a742..d4a12cb64d8e 100644 >>> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >>> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >>> @@ -146,10 +146,15 @@ static void stmmac_disable_all_queues(struct stmmac_priv *priv) >>> for (queue = 0; queue < maxq; queue++) { >>> struct stmmac_channel *ch = &priv->channel[queue]; >>> >>> - if (queue < rx_queues_cnt) >>> + if (queue < rx_queues_cnt) { >>> + napi_synchronize(&ch->rx_napi); >>> napi_disable(&ch->rx_napi); >>> - if (queue < tx_queues_cnt) >>> + } >>> + >>> + if (queue < tx_queues_cnt) { >>> + napi_synchronize(&ch->tx_napi); >>> napi_disable(&ch->tx_napi); >>> + } >>> } >>> } >> >> So good news and bad news ... >> >> The good news is that the above change does fix the initial crash >> I am seeing. However, even with this change applied on top of >> -next, it is still dying somewhere else and so there appears to >> be a second issue. > > Further testing has shown that actually this does NOT resolve the issue > and I am still seeing the crash. Sorry for the false-positive. Any further feedback? I am still seeing this issue on today's -next. Thanks Jon -- nvpublic