Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp1980389ybi; Thu, 20 Jun 2019 07:12:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqxT2tBKdjxk3McWeQedaOSnjWA1HtN5GjGHPaKhlOuOvh26IV5QsZjHAPdIS/oZ+ahDdMD7 X-Received: by 2002:a17:902:b110:: with SMTP id q16mr118337721plr.218.1561039955918; Thu, 20 Jun 2019 07:12:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561039955; cv=none; d=google.com; s=arc-20160816; b=ypW4YsYnHmJj8QjfYoXq5w6pgLn1lqJE0V5qjxVq0wdXjadwkz4d4l/Yzw6mIMmMpK 5akPCXtOJm9IVunSYntmSQ+kp85ke92TPKCrPHOxgErfbQft7F0Ad15pdQFzbVICX6PE 1Ohdz5HTdQy/O6KGw0INh55NPSj7fFmZNOnVjzIefNYdn6euLLABzxarqM7xlxn4CFsi nyjFcBvdr4u75fx4YfRYUT4LEfKOpw93Crc+1A+AwySCcP4R7l7Xsjd3TUgltZdxZ4So KgxHZ95NZQw9CA6kGxTkuu/xbo7i8QS/9iYjHeMlTlp94huG2C4O5mFxjQM58aBrVArd 2dtw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=syCSLdZUygR2irP3Dt4dkGth8Ul25f2kR+nZnXbK8DA=; b=lXffy0a6I/r5OBsOGqHtf82/VNcq7X0xUKmYkob6tJ9nKzyqQGZM13sgy0DWlJXfdF Nckz5ilOfh9BoQFNw5AvSPgkFSRMAsFwWxJ/uRPeEZm/a7zNVUAc9WVgJ3jaqe/fxLBa itLysSoIOW6z7C/XZ1DkoV4jQKZRmwEJLOz/UoyERf1ZBx8QLHW/ZiPmLZ4MD9uqSG+/ bNeVBUqgQJZnCdEZZoe3Dc0e09B9R3mJfBpqDA1cZ084KxPDkE8RKLejarOWJRUSWRjU M7zBtsZ9RKKlwdfod+fElzvyIGIAWbzPo/8g9SMXpZlCYo1594cgrWnUr/o/T5PA3xkJ /SsA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MA1ohhBK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q2si4273996pjq.89.2019.06.20.07.12.19; Thu, 20 Jun 2019 07:12:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=MA1ohhBK; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732152AbfFTOLU (ORCPT + 99 others); Thu, 20 Jun 2019 10:11:20 -0400 Received: from mail-lj1-f194.google.com ([209.85.208.194]:41165 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726740AbfFTOKz (ORCPT ); Thu, 20 Jun 2019 10:10:55 -0400 Received: by mail-lj1-f194.google.com with SMTP id s21so2838390lji.8 for ; Thu, 20 Jun 2019 07:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=syCSLdZUygR2irP3Dt4dkGth8Ul25f2kR+nZnXbK8DA=; b=MA1ohhBK8KGIAK25zr5NT0CRUv9NEBlh+hw9VLz4EC0nPWvQDWYigbmaXAuzVWTsaQ Y8D2PKdtEVw2rW2VMw4SMDFC2bmz23GGSj1SrKlVXB6jdcMrpZJHMTbobvEsYMdAhQoT KyCr1WL9VdbM9NvxMhdcehNSFX35yeLb5VXNjLr3h5KK4kiT4RXCWnM2sTPCUx5l7vIA CF2Q1Zm5Ex4xbDotcvEJF5fyQV0S6isPhQgT/9GpAy2VFYPzOPJCp9VKthme7f3r5tYA 7ZklfbpWgk7SOMPFUSA6br7/04OdplaedEE44//W5sggb5ZN2wPrMla5wj2s8KcGyx/O +LKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=syCSLdZUygR2irP3Dt4dkGth8Ul25f2kR+nZnXbK8DA=; b=iwQtCZEFRraJM4UiUs03RSHmP0tuLiiGmVjChO8i1w9r/H9j/uuPIZwC/P/BWWBdx1 66BEnJ53A1Q46qdZBLPXUXLb00dGUKSg7fKJCM6IKPcRF+YYLzOm+0c9PX1ITwnGjgha ZR9QBQqs6/Ntqs02BNwqq1o844AI/Z/7Pslz4r1jy96Ry5cyEyCa6/EzNfh3n+aOzWW2 iAhSNDGcQK9I7PYqRsM3dY5CPaxPy60JFb/uI7a6YAKJ5bl3CS9AiCbeD2idX9x58TOk VkB/TRwsvYl6cxc1z6pKuOCltcTR3cjgb7KDh3Dju/Ol++4Kk/9FJp6sDpZs7qvBLFSq 4aKw== X-Gm-Message-State: APjAAAXuGvJydlhk2t4es6eMhixcYyamZTfroERsxDSx02dsZbLnLhM1 8nQyooZ41PS6lt8qErjgR2xuzU3c X-Received: by 2002:a2e:5dc4:: with SMTP id v65mr60740590lje.138.1561039852768; Thu, 20 Jun 2019 07:10:52 -0700 (PDT) Received: from localhost.localdomain (v902-804.aalto.fi. [130.233.11.55]) by smtp.gmail.com with ESMTPSA id 27sm3524684ljw.97.2019.06.20.07.10.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Jun 2019 07:10:52 -0700 (PDT) From: Ferdinand Blomqvist To: linux-kernel@vger.kernel.org Cc: Thomas Gleixner Subject: [PATCH v2 3/7] rslib: decode_rs: Fix length parameter check Date: Thu, 20 Jun 2019 17:10:35 +0300 Message-Id: <20190620141039.9874-4-ferdinand.blomqvist@gmail.com> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190620141039.9874-1-ferdinand.blomqvist@gmail.com> References: <20190620141039.9874-1-ferdinand.blomqvist@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The length of the data load must be at least one. Or in other words, there must be room for at least 1 data and nroots parity symbols after shortening the RS code. Signed-off-by: Ferdinand Blomqvist --- lib/reed_solomon/decode_rs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/reed_solomon/decode_rs.c b/lib/reed_solomon/decode_rs.c index 3313bf944ff1..22006eaa41e6 100644 --- a/lib/reed_solomon/decode_rs.c +++ b/lib/reed_solomon/decode_rs.c @@ -39,7 +39,7 @@ /* Check length parameter for validity */ pad = nn - nroots - len; - BUG_ON(pad < 0 || pad >= nn); + BUG_ON(pad < 0 || pad >= nn - nroots); /* Does the caller provide the syndrome ? */ if (s != NULL) -- 2.17.2