Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1561042360-20480-1-git-send-email-cai@lca.pw>
In-Reply-To: <1561042360-20480-1-git-send-email-cai@lca.pw>
From:   Eric Dumazet <edumazet@google.com>
Date:   Thu, 20 Jun 2019 11:21:07 -0400
Message-ID: <CANn89iLBy+u3KTjjfvyc8-r4eUdL2b6VX=fNgqFg8f7t84EUNw@mail.gmail.com>
Subject: Re: [PATCH -next] inet: fix compilation warnings in fqdir_pre_exit()
To:     Qian Cai <cai@lca.pw>
Cc:     David Miller <davem@davemloft.net>,
        netdev <netdev@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Jun 20, 2019 at 10:52 AM Qian Cai <cai@lca.pw> wrote:
>
> The linux-next commit "inet: fix various use-after-free in defrags
> units" [1] introduced compilation warnings,
>
> ./include/net/inet_frag.h:117:1: warning: 'inline' is not at beginning
> of declaration [-Wold-style-declaration]
>  static void inline fqdir_pre_exit(struct fqdir *fqdir)
>  ^~~~~~

Interesting warning, this is kind of new compiler major feature I guess :/

BTW :

$ git grep -n "static void inline"  | wc -l
9