Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2301705ybi; Thu, 20 Jun 2019 12:36:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqyUSMGx2yuDc6hH7ZkHHS+uZEPU37lTPfTUj1yNvuyhQYdsz+Vq1XXa4dzSn4BTOVstxTTE X-Received: by 2002:a63:4d50:: with SMTP id n16mr14442089pgl.146.1561059361173; Thu, 20 Jun 2019 12:36:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561059361; cv=none; d=google.com; s=arc-20160816; b=N/L1EN+JU9z7rcFs3T8ze0sf7NAHedaCxC8L+xH+oSTMIXuwO/02RD4hLCRqxtG1vv 8hLHhGcn9JHELpAVd5bY4onJnAz6tzcv5pJv7FvW/kKY3Wr7an72Hn/PkTj7YeczJZqc XaUClwD39r/6ofvtD79d3+6/3x4SkSL3EMp1qOWmVYWVHdUmFYDrn0XuyuFYAw9v5gHm sHMPh3qIi/wK5YzkxcP/s5/S13mSf57apl2k+cCeo+GcQ6i1gNlxg9lzggmoiQmJcu9l JhocZtLvQq1yNOuJuuYAcINKeMHI3sheuK3pzkum/gjw2Knky/YCpchqvSgbnh3yG/67 Wujw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:openpgp:from:references:cc:to:subject :dkim-signature; bh=g/Q6tFGsegU5Zh0wz2cK248UTbiIMl27+R/SRCYh4wc=; b=p0HqzTCR+oTyQEpGGLam7ASPBTCRYoTXesVdtmlqUKwKrOg5NLMY/EcYcF7FTPEfYI OtJgyhBt8PCVhMfHD4SES+kYbwEX3cGpg0w3VCVsLdCPIRAE0nQPgoWQ4obGEG3PHibb 50FeecAewPWIXICO+V0vZjhIK6cDlzFzhfvmde7Aptx01VIQ8PgasOeIv7o7g0Z4HGkd 9y4b8TSQvbliZuLlE7pnymVTL0qG16oprUFIsrbjJ25L9ain4zgasNNaZb4nzXncpu13 ew2zoUY8QZKvmNm2Jf4pBfuD8j4N4TTdp96eicgWLKvMR7OplcGtGM6LwbqgEL0zFF3v 5mog== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=ACphQQij; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h12si337632pgr.325.2019.06.20.12.35.45; Thu, 20 Jun 2019 12:36:01 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@web.de header.s=dbaedf251592 header.b=ACphQQij; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726633AbfFTTf2 (ORCPT + 99 others); Thu, 20 Jun 2019 15:35:28 -0400 Received: from mout.web.de ([212.227.15.4]:60657 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726169AbfFTTf1 (ORCPT ); Thu, 20 Jun 2019 15:35:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1561059295; bh=g/Q6tFGsegU5Zh0wz2cK248UTbiIMl27+R/SRCYh4wc=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=ACphQQijeXHKdkQmjmXP6hCMU+Qr3w7E+UEDsomvro6lIy6Kqyp1ehgI5Mv8gNxSr IhtlT5LBQGHNw+aQ7hZDcXg0eYKc+lj4iLx/GLlP6V2CgPAWrlk+odk1/umiTEk6fG S4cuRDot655rkLmluAt9eH9+E3PJG6JrvdXSXD78= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.2] ([2.243.128.109]) by smtp.web.de (mrweb004 [213.165.67.108]) with ESMTPSA (Nemesis) id 0MLUDi-1hdUbN0YlO-000Yen; Thu, 20 Jun 2019 21:34:55 +0200 Subject: Re: Coccinelle: Add a SmPL script for the reconsideration of redundant dev_err() calls To: Julia Lawall , kernel-janitors@vger.kernel.org Cc: Gilles Muller , Masahiro Yamada , Michal Marek , Nicolas Palix , Coccinelle , LKML , Ding Xiang References: <05d85182-7ec3-8fc1-4bcd-fd2528de3a40@web.de> <34d528db-5582-5fe2-caeb-89bcb07a1d30@web.de> From: Markus Elfring Openpgp: preference=signencrypt Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <2cae7d27-c032-20bf-4ecc-66a4a85a77cc@web.de> Date: Thu, 20 Jun 2019 21:34:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:WPvLq5xghnJNk3iOktDfdeof1xI/J82wdYAEfSzeK58oA+ZOKA4 N39tHWtC9sc1su1XoMWJ2WLr5nQPj/6b3HepIytvQgrk0zAXQLu1LiMi0GeQrxH2Od3CkLW 5287i8rbh0cghYqtgsp5c6VW94ykOjGboac8z62JfMOx87FJqgsdtNZShPllRU6G5j5xE0D KooiuI9FjkeenKsbHpw7g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:I8PZgRiB4RQ=:bN6CsCxOXDpae5kyaUw/5p PK5cTW3iLK5lTTUgAJCv/OpWyZ8wQsxZZ30ZWlp7bIYHIwNrJRXGpDD4IwaH42ufqNG+W9Dhh Zb6P75I+EvhqbjyU62ajYyYSS8U52diIFdvNjMuH6oSw9QjKU0Fz7VJKQWCCUNagA4z+FEekn FdsNzmL5Oy8tBAVc/9d8T1aI0TkwqzxAEPEUFGlP6duC1sRrT9AtlQELEVmlgyRYmCzJ3hf37 WrZpWRP0AqI581oQIKDqqG3nBpi1B+LJFqfyy1rNpy5I3xc/UZ+y1Oh4AXQ+hm8Upai/O/zke YkGwYK6722gNKE9REzWNRhqFdOTPdJ9Zv66uOsxKmheY04ufHJl6Zv1YsbFwUiFfdtW/gqP3P 1PWY3U9+IZVAqGw71xytmiQfc61PXlbvIOY1mINOFos6APZ0pnhXN4TQ/zptHheoyzVH9HLFJ 5y/WJ1WvG1MVnx6xGF+6BR5MMFILsZssXu01s6GUsngJfUD0URKSRSTLUnECK891l/Woz7Lb+ 0nBv50NA5UrZ2yhnEzHdR2k0u81+CLqrL1Do6Pmyry2euugX8GvXjJUwjRoIwwdHcHHO+9W+E UBtldPpueepMinlCkk+Rui3qAC7HFlAhH92v0343MawSOfa9DtNDW5Dz5uiROdKHF+jM3EXei f35iZMaCFEresMpzlGxk/W/9K75CJIBW3hPFqVvzsQgSsy3fGz5T2ecIs+J7BSg8kLwpH+QsS KIEMWR7MTJl5oHsDjM99R6Cj8OUftLbKoyCFsy9ymSlR6Q1auVbHqFSX57JAdobP5TnWtVzzC v8aKTyYJxDIO1Y3RtHSlVb/d7E0Sp2ncJgytg6ElgCHRwQOlC1nmLKRftyHCTa6IHoEA9wmhF f2DoiYwp/Z7Yzx9feMECd58ew77cy3wgyByW8ZCOANa/1PfYln2FFtqiGU2a2Z57a6S57RYAT s7OzsRD/JjlHyYi2r/j0RVcCZiv4QGUL0Q0yq+9UyWNq6sIrf+2oe Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> Would you prefer to clarify a more advanced approach? > > I think that something like > > if (IS_ERR(e)) > { > <+... > *dev_err(...) > ...+> > } > > would be more appropriate. This SmPL construct can be more powerful. > Whether there is a return or not doesn't really matter. Such an adjustment can be helpful for a few operation modes. But the number of statements in the if branch will influence the possibili= ty for the deletion of curly braces together with redundant dev_err() calls by the SmPL patch mode. >> Would you like to get the relevant function name dynamically determined= ? > > I have no idea what you consider "the relevant function name" to be. > If it is always devm_ioremap_resource then it would seem that it does no= t > need to be dynamically determined. Do other functions share the same error reporting strategy so that any mor= e collateral software evolution can happen? Regards, Markus