Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2367090ybi; Thu, 20 Jun 2019 13:54:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqy3pHc0LHQHNQN/6a8kvuQvcxlag09TJEK9KTb7wiyq81DTlZ+bR1bvdVy0/w0H7wqYvESO X-Received: by 2002:a62:d45d:: with SMTP id u29mr68062519pfl.135.1561064095092; Thu, 20 Jun 2019 13:54:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561064095; cv=none; d=google.com; s=arc-20160816; b=JzZFI5Qvd0OBEjYgl9QWsnTmY2YUSoYqZDLoNXoc/YtpbsoXwbK0mKuh/9aiizSi2h 0Xhx1BBcX5R8jWqy9Rp/schlJhQBD2vPXeVOAp7KmPa/VVNzrvQ9dEdXTwyVdjXi6OTf DD+oKxwHe+g3KX1uIKc+nctaoY7XykYdLQtX5AoXissngSnMtCuWA8Az5BgAnHDAAbM+ vnGGkPHLm9wSpzzoiiBYuv9IlJ66hjrIfVvBpOuOKC/DfI/qWvQwgi7SEuzo0li1JODC Qsh3R35yjdKYe6uQaEaV5PTPva3KVe1y0qLcrrADalqHVF6amTYdtF924AZmSqxQaE1E 3z8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=FzM+nSzZADFLmLVhAQE5b18OebXV89v5MtutF00qYdI=; b=fTujwj6gkdpbro0KtJQOmalim9dOqwn/6zu3zhYzRSXsGZ4O1PZxdieka3y2ODoakT Xlw2QXi1MNDiXPDNWuYFk2rCGFGIxmEvb88qZ0Koz0gdi57H3PieU+hVLbl3FpOy/QKS 3j+J77qw5ubYMSeoVMIv9DKb1+T/hFFleLZg6APR6o5WVJI9oL6oE9zbrFoMj8qunWCM DKvKMxboOwKoS8y3HuyKK3RoOwvrPqKl6xJF2OUgONjRWhRCFz6PmDQQHj7SF719dEgF XgFIw0d5r+uXjbgI+deU/WKyfCMlg7cX2wn8gtJ6Hk4QMqPE+Uxt8ND7dw0LBg45XZCf 9y7g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=XeeY3ZRx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id j5si512813pgi.181.2019.06.20.13.54.39; Thu, 20 Jun 2019 13:54:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=XeeY3ZRx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727016AbfFTUyO (ORCPT + 99 others); Thu, 20 Jun 2019 16:54:14 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:34644 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726875AbfFTUyJ (ORCPT ); Thu, 20 Jun 2019 16:54:09 -0400 Received: by mail-pl1-f193.google.com with SMTP id i2so1878440plt.1 for ; Thu, 20 Jun 2019 13:54:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=FzM+nSzZADFLmLVhAQE5b18OebXV89v5MtutF00qYdI=; b=XeeY3ZRxKogcT3JJRz5OzSakGkmmClO1FZDE11x0BQ6G8i4mDSowUiYbaAcFe63yIZ Znu6lfUBiKHlHayosEjj06HKKe99m6CFoRtWbkvYNKciwBxh/7EKIZ+K3m0jV69C4AL+ ShFJ67Rpun7qnsh8gpiLwamceO3jyKINwA9cM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=FzM+nSzZADFLmLVhAQE5b18OebXV89v5MtutF00qYdI=; b=AGFx2bHFkaJmzQyAk3noqZmMGl8BPQns64JNjsf1hSbaf7Wpo4oAMjEWHeJF78gRVN MS9deVjotMeahQWTlJm0CF9vXMg6fdhxjVqeGAEP9W7+ICU7Sphqyxqudj7SFcgKgw8O ftan6YJ86LgBjrdjBa7exH9gBkFMOvU3QFlKpdC1CL5SYy9V/B7nBgPcTfAMRaG15/Ux ybj69kCzjpmeVwqw5AVs0kiToHzdAMw7iofnA8kNnE9ODZF5tY6THtJeEBEu7tPFWJSp xOYLJFk9qPKbY/bvOMk7tTJEejWu/r7rGhVDJViSFJVgTer7H54DLV9Q0Jg9sfJ4lC8A axKQ== X-Gm-Message-State: APjAAAU9PRJfwutkTIRHO7orTXt5Gpv/7B44RZLqtcQC4hV9/9i+Taef pMyBIngeqTC8f45m8iU95KTmFQ== X-Received: by 2002:a17:902:b18f:: with SMTP id s15mr130515351plr.44.1561064049388; Thu, 20 Jun 2019 13:54:09 -0700 (PDT) Received: from localhost ([2620:15c:202:1:75a:3f6e:21d:9374]) by smtp.gmail.com with ESMTPSA id a16sm385309pfd.68.2019.06.20.13.54.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 20 Jun 2019 13:54:08 -0700 (PDT) Date: Thu, 20 Jun 2019 13:54:06 -0700 From: Matthias Kaehlcke To: Nick Desaulniers Cc: Tom Roeder , Masahiro Yamada , LKML , Raul E Rangel , Tom Hughes , Douglas Anderson , Ryan Case , Yu Liu , Doug Anderson Subject: Re: [PATCH] gen_compile_command: Add support for separate KBUILD_OUTPUT directory Message-ID: <20190620205406.GY137143@google.com> References: <20190620184523.155756-1-mka@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 20, 2019 at 12:53:22PM -0700, Nick Desaulniers wrote: > On Thu, Jun 20, 2019 at 11:45 AM Matthias Kaehlcke wrote: > > > > gen_compile_command.py currently assumes that the .cmd files and the > > source code live in the same directory, which is not the case when > > a separate KBUILD_OUTPUT directory is used. > > Great point; android builds the kernel outside of the source dir > (`make O=/non-source/path ...`). Thanks for the patch! BTW if CrOS is > doing cool stuff with compile_commands.json; I'd like to know! > Particularly; I'm curious if it's possible to generate Ninja build > files from compile_commands.json; I do miss Doug's Kbuild caching > patches' speedup. > Acked-by: Nick Desaulniers At this point Chrome OS doesn't do anything with compile_commands.json for the kernel. I was just toying around a bit after a presentation from Tom Hughes about IDE integration and encountered this limitation.