Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2367294ybi; Thu, 20 Jun 2019 13:55:12 -0700 (PDT) X-Google-Smtp-Source: APXvYqwNc2v79I20oH7Ot7EamNwzlL1ISZpyMW8ydeYkG2OcZxfRPMYKtJv9rqnfFtWAV1jvA3Yx X-Received: by 2002:a63:1d10:: with SMTP id d16mr14326954pgd.446.1561064112381; Thu, 20 Jun 2019 13:55:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561064112; cv=none; d=google.com; s=arc-20160816; b=nG0cZnZx9XHEzlnQOdnYkKpuQvNtbXqyiOyOSHNu1eo9U/UiRId7TffmO5pFN++oX1 s1+Pt9kDtGmMv/kDAVxd0ifKZnZNrxBKRBwUZiP2Du+NhlWY2m0TK0iyx/DPd0XIDoEn tPSqkpT/aiXJNqI64ryXnu1MtwK0hvOf+1wmlNu7TEg3jH2InpM+x4U7TSZ4zjArMvhl 6t5bJtoGaNI9hXqDq9TU8s8dZ+zKpl64KItQn7AZIVzl4Cmg6/tTksGr5CHVH/vmGOLT O5iUSkeuiZY3phQenBGp5y+D8EZl2QYHEG1ZHYh6Z6cETkfK9UU+Zi4GF77OfRgJ3r5r Z77A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:references:in-reply-to :message-id:date:subject:smtp-origin-cluster:cc:to :smtp-origin-hostname:from:smtp-origin-hostprefix:dkim-signature; bh=EqtD9pgjSn3RpeCA8R1A7DD1Wom8eSWCEiXrtl71yV4=; b=rfjMAQrTJnNuhCRAIwXltda5tiTAZ4ufYRILm4Lzp3MAY9CazoaufK5IWT/JrtDdhD BBwbhe333TZ2Yo6qzye3hNu84YCX/x0rrcdEVeXzIUXF0jnT4SZXqzpT/jFkoeJlG6bz zk+y7n9KMTHAGvWH8TroVmEciAyg4vB0fQ880riLFm/qcsTISOMAziWFrLuoyMeotEMb /l8qrsBpbjDbV4nwrLbFvKvmJWrYMyesxqzVy2wKCNhevswA7IMOwjQZspLBLNCyLYd1 /sNxor1/0vd8AWcH1fE6d30a9fBMQytGi8ISYpT4GsGlEE/GPqdVc64DeloOPtF/KZyD B6jA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=LpDJTpfq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f15si533265pgi.56.2019.06.20.13.54.57; Thu, 20 Jun 2019 13:55:12 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@fb.com header.s=facebook header.b=LpDJTpfq; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=fb.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726037AbfFTUyJ (ORCPT + 99 others); Thu, 20 Jun 2019 16:54:09 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:21496 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726192AbfFTUx7 (ORCPT ); Thu, 20 Jun 2019 16:53:59 -0400 Received: from pps.filterd (m0044012.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5KKnocg005791 for ; Thu, 20 Jun 2019 13:53:58 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=facebook; bh=EqtD9pgjSn3RpeCA8R1A7DD1Wom8eSWCEiXrtl71yV4=; b=LpDJTpfqcAQZyhceb25XcDEeRRD76idUGMP2YCehfhWBdS6UgC5jlKKOaxVp8kKYkZvJ iQYqcb7yNzHAvf259bDRxivY5bQWyoJ82yfIN4bsvN1C0sFdbKbNm7GwYccgyHsskI/G ZjVOQcms0Zki8NUcysf2+xqYg30DxS1q9+M= Received: from mail.thefacebook.com (mailout.thefacebook.com [199.201.64.23]) by mx0a-00082601.pphosted.com with ESMTP id 2t867ftg0d-3 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Thu, 20 Jun 2019 13:53:58 -0700 Received: from mx-out.facebook.com (2620:10d:c081:10::13) by mail.thefacebook.com (2620:10d:c081:35::129) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA) id 15.1.1713.5; Thu, 20 Jun 2019 13:53:57 -0700 Received: by devbig006.ftw2.facebook.com (Postfix, from userid 4523) id E8D0762E2A35; Thu, 20 Jun 2019 13:53:55 -0700 (PDT) Smtp-Origin-Hostprefix: devbig From: Song Liu Smtp-Origin-Hostname: devbig006.ftw2.facebook.com To: , , CC: , , , , , Song Liu Smtp-Origin-Cluster: ftw2c04 Subject: [PATCH v5 1/6] filemap: check compound_head(page)->mapping in filemap_fault() Date: Thu, 20 Jun 2019 13:53:43 -0700 Message-ID: <20190620205348.3980213-2-songliubraving@fb.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190620205348.3980213-1-songliubraving@fb.com> References: <20190620205348.3980213-1-songliubraving@fb.com> X-FB-Internal: Safe MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-20_14:,, signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=929 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906200149 X-FB-Internal: deliver Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently, filemap_fault() avoids trace condition with truncate by checking page->mapping == mapping. This does not work for compound pages. This patch let it check compound_head(page)->mapping instead. Acked-by: Rik van Riel Signed-off-by: Song Liu --- mm/filemap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/filemap.c b/mm/filemap.c index df2006ba0cfa..f5b79a43946d 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2517,7 +2517,7 @@ vm_fault_t filemap_fault(struct vm_fault *vmf) goto out_retry; /* Did it get truncated? */ - if (unlikely(page->mapping != mapping)) { + if (unlikely(compound_head(page)->mapping != mapping)) { unlock_page(page); put_page(page); goto retry_find; -- 2.17.1