Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp2405359ybi; Thu, 20 Jun 2019 14:40:22 -0700 (PDT) X-Google-Smtp-Source: APXvYqxkDFVmq1eP1mMs4K0EQpENSIwlDKeqw5UXPV9dwTwibZ7blzKipUALiHrpSm9xRI8JX3Cb X-Received: by 2002:a62:386:: with SMTP id 128mr136268794pfd.10.1561066822129; Thu, 20 Jun 2019 14:40:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561066822; cv=none; d=google.com; s=arc-20160816; b=OwUEIQRcq49QtoSiqhrVRJuKhuUta1+cze0UfPugv13U3jsufgPVYAW41LVq50cPdW YIBFuDE6k+hiCWWSLzv7f2gu18EpMZ2xGl42U7X4lJsz3SZMSXIccX16S6JF47L9S0JN Gx3h2TCmZ7jg+a/pCi1A7BdyZMyxeQWmb3degchTng8brHCNQJ8+qKxgVN8x0148GjOb GmxXA/GUZcaEDgMZBrDNSMamNGwQkdqh5BcJJVFrb3dC6doNhPlzTJaorMPuV2XEkWoa 8nRjt040/cK2EoXqhtQw8Ovoa+Pc4cJ7HJidOe/pr/rpCXdVqLvm8EvmYS7mjPEajeJU youw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=FRa+FTYrUwE5FnAqArVG6ocbHw5r29drxK/7hoYzZjo=; b=B8FFQRwAKZtmllJ2R3+Htn+4PzLMTH8Ct2/qQD10257myNcMFhun3DSm+7tMdkSI6w BSD7nfTHQFFY+d0efg8NERubo4vkWjW8hmLVdzi+LRf0UgWl3AhEuumWA2QCuAEXQ9a3 hIm99CArXWyDIAFwAUFBr92fpXBZY7f/nOz38IsFCcFwB8f4H1SYcdVbLOXw2A8kVm/T Qtsbp7Wo45D/kVHBX3dTT09YZnTxLhZlCeSu2NbiGs5eCtf5KvQDenAmZNzXLpsJL1LM k8EU7Dnn4arRgH/jRjBs+BBKlks+lbbozp5lNFhr4Pn5SBGVBmjmgOlmgDoF63QA2lc1 VtPw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=HR7QDXLF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 206si637969pga.414.2019.06.20.14.40.06; Thu, 20 Jun 2019 14:40:22 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=HR7QDXLF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726339AbfFTViq (ORCPT + 99 others); Thu, 20 Jun 2019 17:38:46 -0400 Received: from mail-pg1-f193.google.com ([209.85.215.193]:35458 "EHLO mail-pg1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726034AbfFTVip (ORCPT ); Thu, 20 Jun 2019 17:38:45 -0400 Received: by mail-pg1-f193.google.com with SMTP id s27so2265019pgl.2 for ; Thu, 20 Jun 2019 14:38:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=FRa+FTYrUwE5FnAqArVG6ocbHw5r29drxK/7hoYzZjo=; b=HR7QDXLF7YhGpHGL9vIVq+IKHpppE33n8uKbIEm8UdnyiHhFldKWoErbW86WxynVZB 4i4L4LrzxDFCh7MvTNJvhtiMin58jW986U/8DoROWF4VPVnPfevCtaZQt8Uzvz6/6rO/ Hk1K2d4TVRL6un9PVsnjAGfyCrNnmX2DfItpG9GMkMTr5x4akX/6PGZw4KnwFnPL+ZYV wjxcI1mC04550rE3GTltks17N66DE4Ys6GexAO14YEFtKdKK0dcZDvOBQa7WLRy/TeoC sttTGsNi7ZMpS+09IYY/opogZcAnSmRWR5Cr1Fcm78Cas4Ro+hh/gbHmTxdNE8P3RsvA cSiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=FRa+FTYrUwE5FnAqArVG6ocbHw5r29drxK/7hoYzZjo=; b=IIudg1bChceunUzRqzezhsbhiIUeSuO6unMy2GwVqKnZ2s6SFS6pLiXa6JfV0J135q 8S+PKMxu0/rD320OVNiqgJWpNXhUMA4mvbCAL79uiERO7/eJ4EjlDo+TNo8e8cktXCxP UOhEVawInbH5X9mT5EgqvZUlmGdmuHgHnlgh1KMrrPC1qOkyqW0dHZWAipj/AlBBh9+F NRn+MRELMHKqrWuqOASg0fau95wW4ogPvTBUklJodClNFjDoI+1fv6rVleBnwW5tEEsr 7GADbWS9SUqghIusgatlgFE0FtWsvqkgqQphu4BZSPCHDMFKQGcjvTWDFyaOHIu7wO0b NvyQ== X-Gm-Message-State: APjAAAXy3W6VrHy1zcs8qy105sZa2stKLxVvQhT1q1w1Keo0exMWhkfw XkVBVbtfuDLztSAfLP/+lc0DvA== X-Received: by 2002:a62:7d13:: with SMTP id y19mr74181464pfc.62.1561066724568; Thu, 20 Jun 2019 14:38:44 -0700 (PDT) Received: from localhost (c-71-197-186-152.hsd1.wa.comcast.net. [71.197.186.152]) by smtp.googlemail.com with ESMTPSA id r9sm542327pgv.24.2019.06.20.14.38.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Jun 2019 14:38:44 -0700 (PDT) From: Kevin Hilman To: Neil Armstrong , thierry.reding@gmail.com Cc: Neil Armstrong , linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org, martin.blumenstingl@googlemail.com Subject: Re: [PATCH] pwm: meson: fix the G12A AO clock parents order In-Reply-To: <20190620144655.2142-1-narmstrong@baylibre.com> References: <20190620144655.2142-1-narmstrong@baylibre.com> Date: Thu, 20 Jun 2019 14:38:43 -0700 Message-ID: <7hy31wdjj0.fsf@baylibre.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Neil Armstrong writes: > The Amlogic G12A and G12B Documentation is wrong, the AO xtal and clk81 > clock source order is reversed, and validated when adding DVFS support by > using the PWM AO D output to control the CPU supply voltage. > > The vendor tree also uses the reversed xtal and clk81 order at [1]. > > [1] https://github.com/hardkernel/linux/blob/odroidn2-4.9.y/drivers/amlogic/pwm/pwm_meson.c#L462 > > Fixes: f41efceb46e6 ("pwm: meson: Add clock source configuration for Meson G12A") > Signed-off-by: Neil Armstrong Acked-by: Kevin Hilman