Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750897AbVKXEXq (ORCPT ); Wed, 23 Nov 2005 23:23:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751334AbVKXEXq (ORCPT ); Wed, 23 Nov 2005 23:23:46 -0500 Received: from mx1.redhat.com ([66.187.233.31]:21416 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S1750897AbVKXEXp (ORCPT ); Wed, 23 Nov 2005 23:23:45 -0500 Date: Wed, 23 Nov 2005 23:21:50 -0500 From: Dave Jones To: Adrian Bunk Cc: "Randy.Dunlap" , Andrew Morton , Arjan van de Ven , linux-kernel@vger.kernel.org, Ingo Molnar Subject: Re: [-mm patch] init/main.c: dummy mark_rodata_ro() should be static Message-ID: <20051124042150.GC30849@redhat.com> Mail-Followup-To: Dave Jones , Adrian Bunk , "Randy.Dunlap" , Andrew Morton , Arjan van de Ven , linux-kernel@vger.kernel.org, Ingo Molnar References: <20051123033550.00d6a6e8.akpm@osdl.org> <20051123223505.GF3963@stusta.de> <20051123225440.GJ3963@stusta.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20051123225440.GJ3963@stusta.de> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 666 Lines: 19 On Wed, Nov 23, 2005 at 11:54:40PM +0100, Adrian Bunk wrote: > On Wed, Nov 23, 2005 at 02:46:51PM -0800, Randy.Dunlap wrote: > > On Wed, 23 Nov 2005, Adrian Bunk wrote: > > > > > Every inline dummy function should be static. > > > > Please explain why it matters in this case. > > We don't need an additional global copy of the function. it's an empty body, surely the compiler will compile it away ? Dave - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/