Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp373657ybi; Fri, 21 Jun 2019 00:58:14 -0700 (PDT) X-Google-Smtp-Source: APXvYqyeFl3VY84tnEKX9jhP9ixAiw/na5twhwDz0vPNPJKiD06CX+G+kGrDCNqisBcEREQZYu3h X-Received: by 2002:a17:90a:ae12:: with SMTP id t18mr4979150pjq.32.1561103894207; Fri, 21 Jun 2019 00:58:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561103894; cv=none; d=google.com; s=arc-20160816; b=rcr6XUkTq3kE7uYZdOSFXrsy1buDz/u+o96ZtCQivYdwF+2o8zBFOyADK+tJdVfWZl P0MF5aA0IzPB7b06+XY86vlAPKEit9TdI+CR54KXstYmoHRrzLWKQXQ28oMHbHAsIvKq G1GDpFIgglV2vU6ZmbYj7fmepUNAbPDhW5gjt59lpO6/pGmEjAKVA9JstSUAPUz3yDOt p6wa56gfkPsqtYqwGsTdq1uaejyFlA8NIO08+J/pjK2HnAGgz9WpKwJ90aOrervlrRNU 0uM1dxt3IhHbc1vVd2V6oi1uBRzkMLV0Uc13m4QaVsPNK3XKxlkuVCF+P52YswciD6fg 5ixQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=1c5gL1nvNHdHQ5BkpLdgJdzuOwoAU/kbh+UdoysTyXM=; b=W31vJ9Lf4ci2ndRVfQr4bMR6nHHfNPrUKXaYSG0eQIkN9d+UXNwTNXZ6LPqv51v8rs J1kolyQtPtOqBW49vfCKUqP1K978Cviiu8A+QvOJ9Uk4mTLbGikXaUrjBqVr9S/ZLaPo Zi+SkDyK9GKVnwNjzVHshEXsT+yM03Hrtv443yCo0MvGrBf/TOK3HT/RSs5sTidrP2Uh 62DvaelYWm1ogiBSlFQ1zsAl2OgC6mipCMO2GMXlthPiHXZGqNY8PPSJaHQe4XtXJLKp kG21g3ZYsA+PHsLqFq6tJdYefbpMpO7JxBeZsNuJdIjrWLbwuRFYaRG82Wv5y/bhxUFq aW+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b="pAu/wPwQ"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u19si1888976pgm.471.2019.06.21.00.57.59; Fri, 21 Jun 2019 00:58:14 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b="pAu/wPwQ"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726369AbfFUH5m (ORCPT + 99 others); Fri, 21 Jun 2019 03:57:42 -0400 Received: from pandora.armlinux.org.uk ([78.32.30.218]:37362 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726339AbfFUH5l (ORCPT ); Fri, 21 Jun 2019 03:57:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=1c5gL1nvNHdHQ5BkpLdgJdzuOwoAU/kbh+UdoysTyXM=; b=pAu/wPwQ/la+CpsmO0Um0wwWL MEJh1NFiNDmqiSzyVJWg9d305xmNqaHFsPj4UswwuyIGxOBO89gneWJeATAM6I3vDLzJPJi6i9pfM ZDuSssM/NtoWzXqBEcFkSzqYACyj4rl6nRXfQrvBEI/YP7fcVgyp9cNIiwlo2jHpwKddkFlplNe+N /jSnVzNV75x3KIrljhpMGmfAx9P29U3UlH1pElOvJkLEw1PK2Is3/IzXk0AZq4WeHaBNFLEu8Ehxq v4myVYpdpQZ3uENoFIlpUUzDr9CjnWvWu+nPa/VQ9wDC8oU2VQesEnJjTCTk+iX9K26D1bMoAcDeB g8AXpfLaw==; Received: from shell.armlinux.org.uk ([2002:4e20:1eda:1:5054:ff:fe00:4ec]:58940) by pandora.armlinux.org.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1heEQQ-0003oX-Eh; Fri, 21 Jun 2019 08:57:34 +0100 Received: from linux by shell.armlinux.org.uk with local (Exim 4.89) (envelope-from ) id 1heEQN-00035c-5P; Fri, 21 Jun 2019 08:57:31 +0100 Date: Fri, 21 Jun 2019 08:57:31 +0100 From: Russell King - ARM Linux admin To: Florian Fainelli Cc: linux-arm-kernel@lists.infradead.org, Catalin Marinas , Will Deacon , open list , Shaokun Zhang Subject: Re: [PATCH v2 2/2] ARM: smp: Moved cpu_logical_map[] to smp.h Message-ID: <20190621075730.nubg7657nwlkmmmk@shell.armlinux.org.uk> References: <20190603231830.24129-1-f.fainelli@gmail.com> <20190603231830.24129-3-f.fainelli@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190603231830.24129-3-f.fainelli@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 03, 2019 at 04:18:30PM -0700, Florian Fainelli wrote: > asm/smp.h is included by linux/smp.h and some drivers, in particular > irqchip drivers can access cpu_logical_map[] in order to perform SMP > affinity tasks. Make arm64 consistent with other architectures here. > > Signed-off-by: Florian Fainelli I merged this last night, and it causes ojn's builder to fail 98 defconfigs with errors like: arch/arm/include/asm/smp_plat.h:79:7: error: implicit declaration of function 'cpu_logical_map' [-Werror=implicit-function-declaration] arch/arm/kernel/setup.c:594:21: error: lvalue required as left operand of assignment arch/arm/kernel/setup.c:596:22: error: lvalue required as left operand of assignment Dropping this patch. Also, you may wish to make the patch description refer to the correct architecture. > --- > arch/arm/include/asm/smp.h | 6 ++++++ > arch/arm/include/asm/smp_plat.h | 5 ----- > 2 files changed, 6 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/include/asm/smp.h b/arch/arm/include/asm/smp.h > index 451ae684aaf4..112d78e82f35 100644 > --- a/arch/arm/include/asm/smp.h > +++ b/arch/arm/include/asm/smp.h > @@ -20,6 +20,12 @@ > > #define raw_smp_processor_id() (current_thread_info()->cpu) > > +/* > + * Logical CPU mapping. > + */ > +extern u32 __cpu_logical_map[]; > +#define cpu_logical_map(cpu) __cpu_logical_map[cpu] > + > struct seq_file; > > /* > diff --git a/arch/arm/include/asm/smp_plat.h b/arch/arm/include/asm/smp_plat.h > index f2c36acf9886..ca6b91d400cf 100644 > --- a/arch/arm/include/asm/smp_plat.h > +++ b/arch/arm/include/asm/smp_plat.h > @@ -66,11 +66,6 @@ static inline int cache_ops_need_broadcast(void) > } > #endif > > -/* > - * Logical CPU mapping. > - */ > -extern u32 __cpu_logical_map[]; > -#define cpu_logical_map(cpu) __cpu_logical_map[cpu] > /* > * Retrieve logical cpu index corresponding to a given MPIDR[23:0] > * - mpidr: MPIDR[23:0] to be used for the look-up > -- > 2.17.1 > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel > -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up According to speedtest.net: 11.9Mbps down 500kbps up