Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1561121145.3149.7.camel@pengutronix.de>
Subject: Re: linux-next: Fixes tags need some work in the drm-fixes tree
From:   Philipp Zabel <p.zabel@pengutronix.de>
To:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Dave Airlie <airlied@linux.ie>,
        DRI <dri-devel@lists.freedesktop.org>
Cc:     Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Steve Longerbeam <slongerbeam@gmail.com>
Date:   Fri, 21 Jun 2019 14:45:45 +0200
In-Reply-To: <20190621214125.6fb68eee@canb.auug.org.au>
References: <20190621214125.6fb68eee@canb.auug.org.au>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, 2019-06-21 at 21:41 +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   912bbf7e9ca4 ("gpu: ipu-v3: image-convert: Fix image downsize coefficients")
> 
> Fixes tag
> 
>   Fixes: 70b9b6b3bcb21 ("gpu: ipu-v3: image-convert: calculate per-tile
> 
> has these problem(s):
> 
>   - Please don't split Fixes tags across more than one line
> 
> In commit
> 
>   bca4d70cf1b8 ("gpu: ipu-v3: image-convert: Fix input bytesperline for packed formats")
> 
> Fixes tag
> 
>   Fixes: d966e23d61a2c ("gpu: ipu-v3: image-convert: fix bytesperline
> 
> has these problem(s):
> 
>   - Please don't split Fixes tags across more than one line
> 
> In commit
> 
>   ff391ecd65a1 ("gpu: ipu-v3: image-convert: Fix input bytesperline width/height align")
> 
> Fixes tag
> 
>   Fixes: d966e23d61a2c ("gpu: ipu-v3: image-convert: fix bytesperline
> 
> has these problem(s):
> 
>   - Please don't split Fixes tags across more than one line
> 

I was under the impression that dim would have found those, but I only
just realized that "dim checkpatch" doesn't actually do any additional
checks beyond scripts/checkpatch.pl. Fixes tags are checked only as a
part of "dim push". I wonder if this could be changed [1].

[1] https://gitlab.freedesktop.org/drm/maintainer-tools/merge_requests/5

regards
Philipp