Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Song Liu <songliubraving@fb.com>
To:     "Kirill A. Shutemov" <kirill@shutemov.name>
CC:     Linux-MM <linux-mm@kvack.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        "matthew.wilcox@oracle.com" <matthew.wilcox@oracle.com>,
        "kirill.shutemov@linux.intel.com" <kirill.shutemov@linux.intel.com>,
        "Kernel Team" <Kernel-team@fb.com>,
        "william.kucharski@oracle.com" <william.kucharski@oracle.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>
Subject: Re: [PATCH v5 6/6] mm,thp: avoid writes to file with THP in pagecache
Thread-Topic: [PATCH v5 6/6] mm,thp: avoid writes to file with THP in
 pagecache
Thread-Index: AQHVJ6piUxjnrZaN9U27pEvDQgjQg6amFUcAgAAA5oCAAAgUAIAAARcA
Date:   Fri, 21 Jun 2019 13:43:42 +0000
Message-ID: <FA332FEC-B64D-4E60-A591-AD04311F21FF@fb.com>
References: <20190620205348.3980213-1-songliubraving@fb.com>
 <20190620205348.3980213-7-songliubraving@fb.com>
 <20190621130740.ehobvjjj7gjiazjw@box>
 <ABE906A7-719A-4AFF-8683-B413397C9865@fb.com>
 <20190621133948.2pvagzfwpwwk6rho@box>
In-Reply-To: <20190621133948.2pvagzfwpwwk6rho@box>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <429167CCB0708345806FE238F1E5CCDF@namprd15.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: e89474d5-4912-41c8-3f42-08d6f64e79b4
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2019 13:43:42.7309
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: songliubraving@fb.com
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1119
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-21_10:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 priorityscore=1501
 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0
 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0
 mlxlogscore=779 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.0.1-1810050000 definitions=main-1906210115
X-FB-Internal: deliver
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> On Jun 21, 2019, at 6:39 AM, Kirill A. Shutemov <kirill@shutemov.name> wr=
ote:
>=20
> On Fri, Jun 21, 2019 at 01:10:54PM +0000, Song Liu wrote:
>>=20
>>=20
>>> On Jun 21, 2019, at 6:07 AM, Kirill A. Shutemov <kirill@shutemov.name> =
wrote:
>>>=20
>>> On Thu, Jun 20, 2019 at 01:53:48PM -0700, Song Liu wrote:
>>>> In previous patch, an application could put part of its text section i=
n
>>>> THP via madvise(). These THPs will be protected from writes when the
>>>> application is still running (TXTBSY). However, after the application
>>>> exits, the file is available for writes.
>>>>=20
>>>> This patch avoids writes to file THP by dropping page cache for the fi=
le
>>>> when the file is open for write. A new counter nr_thps is added to str=
uct
>>>> address_space. In do_last(), if the file is open for write and nr_thps
>>>> is non-zero, we drop page cache for the whole file.
>>>>=20
>>>> Signed-off-by: Song Liu <songliubraving@fb.com>
>>>> ---
>>>> fs/inode.c         |  3 +++
>>>> fs/namei.c         | 22 +++++++++++++++++++++-
>>>> include/linux/fs.h | 31 +++++++++++++++++++++++++++++++
>>>> mm/filemap.c       |  1 +
>>>> mm/khugepaged.c    |  4 +++-
>>>> 5 files changed, 59 insertions(+), 2 deletions(-)
>>>>=20
>>>> diff --git a/fs/inode.c b/fs/inode.c
>>>> index df6542ec3b88..518113a4e219 100644
>>>> --- a/fs/inode.c
>>>> +++ b/fs/inode.c
>>>> @@ -181,6 +181,9 @@ int inode_init_always(struct super_block *sb, stru=
ct inode *inode)
>>>> 	mapping->flags =3D 0;
>>>> 	mapping->wb_err =3D 0;
>>>> 	atomic_set(&mapping->i_mmap_writable, 0);
>>>> +#ifdef CONFIG_READ_ONLY_THP_FOR_FS
>>>> +	atomic_set(&mapping->nr_thps, 0);
>>>> +#endif
>>>> 	mapping_set_gfp_mask(mapping, GFP_HIGHUSER_MOVABLE);
>>>> 	mapping->private_data =3D NULL;
>>>> 	mapping->writeback_index =3D 0;
>>>> diff --git a/fs/namei.c b/fs/namei.c
>>>> index 20831c2fbb34..de64f24b58e9 100644
>>>> --- a/fs/namei.c
>>>> +++ b/fs/namei.c
>>>> @@ -3249,6 +3249,22 @@ static int lookup_open(struct nameidata *nd, st=
ruct path *path,
>>>> 	return error;
>>>> }
>>>>=20
>>>> +/*
>>>> + * The file is open for write, so it is not mmapped with VM_DENYWRITE=
. If
>>>> + * it still has THP in page cache, drop the whole file from pagecache
>>>> + * before processing writes. This helps us avoid handling write back =
of
>>>> + * THP for now.
>>>> + */
>>>> +static inline void release_file_thp(struct file *file)
>>>> +{
>>>> +#ifdef CONFIG_READ_ONLY_THP_FOR_FS
>>>> +	struct inode *inode =3D file_inode(file);
>>>> +
>>>> +	if (inode_is_open_for_write(inode) && filemap_nr_thps(inode->i_mappi=
ng))
>>>> +		truncate_pagecache(inode, 0);
>>>> +#endif
>>>> +}
>>>> +
>>>> /*
>>>> * Handle the last step of open()
>>>> */
>>>> @@ -3418,7 +3434,11 @@ static int do_last(struct nameidata *nd,
>>>> 		goto out;
>>>> opened:
>>>> 	error =3D ima_file_check(file, op->acc_mode);
>>>> -	if (!error && will_truncate)
>>>> +	if (error)
>>>> +		goto out;
>>>> +
>>>> +	release_file_thp(file);
>>>=20
>>> What protects against re-fill the file with THP in parallel?
>>=20
>> khugepaged would only process vma with VM_DENYWRITE. So once the
>> file is open for write (i_write_count > 0), khugepage will not=20
>> collapse the pages.=20
>=20
> I have not look at the patch very closely. Do you only create THP by
> khugepaged? Not in fault path?

Right. My set only creates THP in khugepaged. William Kucharski is
working on the fault path.=20

Thanks,
Song