Received: by 2002:a17:90a:37a3:0:0:0:0 with SMTP id v32csp745279pjb; Fri, 21 Jun 2019 07:56:27 -0700 (PDT) X-Google-Smtp-Source: APXvYqwvNbBTItcyIS744+i9tEG9UPQiogoge+dbWky+Rkz+udiLlpp6ihYB6BtEuzFt1gRj96+F X-Received: by 2002:a63:e001:: with SMTP id e1mr19097942pgh.306.1561128987257; Fri, 21 Jun 2019 07:56:27 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561128987; cv=none; d=google.com; s=arc-20160816; b=xb6W7jmH0gYyvvfcck4VIiWdJAKeBVhVwxDI6PulKeqx0lg3DhLFUDeNEASwiSYzGE i374eB8Mu+D0H5QeFQ+oWYjiDyhmhwmYaKI3K19+Gd7wkaJO+4QqXjNm6bzxC/7AcmTx kxS2oC+zXrgaXKDf4L5RkmQ0C0Auu4naHacwR8ODhyM+EDGpkAFE9m8CsSoYfgvZ5bXq bcPkNjCtgS2ujsbiLJ/0OUlNJ/x5m+49Q0LqIHi5uBY6kXLvb87Y7Rfce+3othdkYmbW WbALwuZlcw3UCgR4UjR9HY4qXjbs2tipzOai78faXab0A6NYuIUYg3W4DR31qmhAVAd+ V3UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=McASa29lxjZpj0oJ3ZfQEaOaFXbUU/UG3+m1x1GG8co=; b=xpALyQScgrJpYsRZf372wJUMj8e7ieTMyTU/KWm2edSA4l/noqV4/I65+jn5h5uQl0 qEEsCubgYclMe02+5TmfsXNx/fPlJY+l3O5R2zuIJEvv6jtnYNro/uH6IxRFM5ueOYAN aqmmV1JwB3YzsIOyPyaT3kzDa/ZswiFBA5YhPZwDnZhS1r1kiU/QJLpUJ6P91r6eJJwA UvSGXNvzYlEf59V6dm0JvwtuTey7fh5BJyPORmY62o1RYsYufJg0ypYqHecwvsqktnHG qEMjHv42ooilE9RuJve8fBCOotjWOKHjb1EkQ/JJj3kQ57zZJVsV5IRCJVcO2ZHpxnim xbqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=X3xAV4Ny; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u16si3030132pjb.15.2019.06.21.07.56.12; Fri, 21 Jun 2019 07:56:27 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=X3xAV4Ny; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726323AbfFUOzv (ORCPT + 99 others); Fri, 21 Jun 2019 10:55:51 -0400 Received: from mail-vk1-f194.google.com ([209.85.221.194]:43063 "EHLO mail-vk1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725985AbfFUOzv (ORCPT ); Fri, 21 Jun 2019 10:55:51 -0400 Received: by mail-vk1-f194.google.com with SMTP id m193so1342856vke.10 for ; Fri, 21 Jun 2019 07:55:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=McASa29lxjZpj0oJ3ZfQEaOaFXbUU/UG3+m1x1GG8co=; b=X3xAV4NyA3y9UzA2IA/Mk+qrbdrPKZIojhR+endGbpMJCR38xtZNqJ9k22djG6EF8T lgeu4QQxt/tsghp0XWw3YgkSmM36uLQez2tVp4MN+NadgIHC0T2hblyRbSo9szBtCly7 Wl/mDoc9QOORA8aKlSOXdTAQ2mVhqtKyuShPZOn9t5BGSWAGAHhGSbwIAFb5WEVoeR7E kP+EjwXcBAkzjawd196Z/h9+budQycSYG4WoqpHICVdO3OTu0jmpgEthvef+K46SvBJp k+whefb30M+1PGYlpvNw5ZQWAt4m/unHVMNLGpia4S28NYrHiRibidO0Ao1/uRPdY6o9 rBaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=McASa29lxjZpj0oJ3ZfQEaOaFXbUU/UG3+m1x1GG8co=; b=mSqIUyPOsJZYcK/iem99k+FHrMmFHhYxmUYlO5x+Fr0CqaonCO34kAJE9wIyv0NB8r 9GO4Wnt4nFQ5iH8An+3qgd7ACu7Mv/R7alSnKwxHDO3qNoeItNeWRqV9sWhRweiczMMM q77SGs6oJV/RJJxPIqHKQ250fNeiem8y7iLvaXIMo2RsHYO9Exb9Gb53901a18QDWYUs eymMvQKWdWCWK0LIkao1PGQ5bG6wK/4MdnQNiPPgL4ihV3fKTSiMf7123nVQtJLG4oJ5 GSAqBcTD4c2Nou1k9zkQIMHbCGYC+UpODrXKntqJQ7NEnWvpAHsuxu1wHeH7gT0Qw/E/ /RdQ== X-Gm-Message-State: APjAAAVKNRUIVG/sjpGEMBMmAIrcwdFtJ27W/gNdkP/Pm3oVVZLssdzi OLAx2+Q8U/vpLhARTnWfFwDQPeal2LTi/SAtZ3w= X-Received: by 2002:a1f:14c1:: with SMTP id 184mr9771787vku.69.1561128950035; Fri, 21 Jun 2019 07:55:50 -0700 (PDT) MIME-Version: 1.0 References: <1560755897-5002-1-git-send-email-yannick.fertre@st.com> <2c169739-febb-12a9-0fa1-d5da053ded67@st.com> In-Reply-To: <2c169739-febb-12a9-0fa1-d5da053ded67@st.com> From: Emil Velikov Date: Fri, 21 Jun 2019 15:53:32 +0100 Message-ID: Subject: Re: [PATCH 1/3] drm/stm: drv: fix suspend/resume To: Yannick FERTRE Cc: Philippe CORNU , Benjamin GAIGNARD , Vincent ABRIOU , David Airlie , Daniel Vetter , Maxime Coquelin , Alexandre TORGUE , ML dri-devel , "linux-stm32@st-md-mailman.stormreply.com" , LAKML , "Linux-Kernel@Vger. Kernel. Org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Jun 2019 at 15:01, Yannick FERTRE wrote: > > Hi Emil, > > The msm driver tests the return value & set state to NULL if no error is > detected. > > the ltdc driver tests the return value & force to suspend if an error is > detected. > > It's not exactly the same. > D'oh I've misread that patch as pm_runtime_force_suspend() being called when the atomic helper succeeds. Thanks for the correction :-) Emil