Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp801964ybi; Fri, 21 Jun 2019 08:23:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqyTLCoxgsyM7Ikb8fFVmgcHPisrjT2w5eeHcjX2IZHkPOjy8sZ/q4Gs+bcEvDzqPb84ZTXR X-Received: by 2002:a17:902:a60d:: with SMTP id u13mr63783243plq.144.1561130613246; Fri, 21 Jun 2019 08:23:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561130613; cv=none; d=google.com; s=arc-20160816; b=v2Qpaxwm0TgTMmR8UAjEwVjWDB2m05pT3IxIVWKy1gbLkMCT5Z1u10jhMmgLTOtY9Z h6L+nnn9vRXZMRhkY0UW5zZRTs8+zKOXkS/U72gIIfq/Ba23MTit6ZmRPhJz1CkDTXFA 5Ic0BSXqnmWn1L8/a9Tg1OrZ9EEYqi/OEKyG2O4ayqrttghSoM0nDqhah3vZ1sFpW+jx tJKk9UUtxJJ7YbaaJB2qG1/a4vRp+CkB9xwMee7Gvr/dIPrBjZpiOdzJHgFhqyGMms0/ ntSBK2cPWBtoheUygnIUGXV+d5I1trdGWYQWq3kPD5/It5g/a7EFPTuXA69NfuSRis6Y hpaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=pIRJHjrIF8IaCjSTV3y65uJ8oWcRKZStHuEd4dXwi10=; b=0pkPqCIU0v63R3R9CzeOpEPc9Y36KVMjR6bEOb9RlYuumwvMGg/wI9TVkXIlapw12Y ocX4s50wGK5/m+gDBNlq8q3EXUS7UVzHaRCUU+dwbyCJn9ArLeD8zuAbTAZhgkTIXfuk A8jx75gqwSsxoM8xBDaFmll6sIZibRMwl9xmOZkIVTKKdUWjwzqeueLU7q8l2Y+lpHK0 0ttrKibFWbRgLW8OMuFdkXIld657wKcy1vrlJ35dazvN+Oe2fVZYLAa4ziFh0AOSy9L7 /ly2wq955UU5wSB1XHB25GqbUviy8wQPNvIqlwqiH2Xsdmj5rhjv7LVID+2jInd6YdEc O8Ng== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y10si2777712pgq.173.2019.06.21.08.23.17; Fri, 21 Jun 2019 08:23:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726451AbfFUPVF (ORCPT + 99 others); Fri, 21 Jun 2019 11:21:05 -0400 Received: from mail.us.es ([193.147.175.20]:47052 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726429AbfFUPVE (ORCPT ); Fri, 21 Jun 2019 11:21:04 -0400 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 1D81EEDB07 for ; Fri, 21 Jun 2019 17:21:03 +0200 (CEST) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 0F414DA710 for ; Fri, 21 Jun 2019 17:21:03 +0200 (CEST) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 04EB0DA709; Fri, 21 Jun 2019 17:21:03 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 0692FDA704; Fri, 21 Jun 2019 17:21:01 +0200 (CEST) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Fri, 21 Jun 2019 17:21:01 +0200 (CEST) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id D9A184265A2F; Fri, 21 Jun 2019 17:21:00 +0200 (CEST) Date: Fri, 21 Jun 2019 17:21:00 +0200 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Arnd Bergmann Cc: Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , wenxu , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] netfilter: fix nf_conntrack_bridge/ipv6 link error Message-ID: <20190621152100.ljm25njdzaq2ek7i@salvia> References: <20190617131515.2334941-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190617131515.2334941-1-arnd@arndb.de> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 17, 2019 at 03:15:04PM +0200, Arnd Bergmann wrote: > When CONFIG_IPV6 is disabled, the bridge netfilter code > produces a link error: > > ERROR: "br_ip6_fragment" [net/bridge/netfilter/nf_conntrack_bridge.ko] undefined! > ERROR: "nf_ct_frag6_gather" [net/bridge/netfilter/nf_conntrack_bridge.ko] undefined! > > The problem is that it assumes that whenever IPV6 is not a loadable > module, we can call the functions direction. This is clearly > not true when IPV6 is disabled. > > There are two other functions defined like this in linux/netfilter_ipv6.h, > so change them all the same way. Applied, thanks Arnd.