Received: by 2002:a25:ab43:0:0:0:0:0 with SMTP id u61csp884066ybi; Fri, 21 Jun 2019 09:44:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqzR3jCzvXPNlO852IEuGpdJalYroVTXyWIDzWdVjATXD3WsDB941el/fCS5UK3JpzG1cTmo X-Received: by 2002:a65:40cb:: with SMTP id u11mr20331942pgp.333.1561135493534; Fri, 21 Jun 2019 09:44:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561135493; cv=none; d=google.com; s=arc-20160816; b=tZY1SCIH3Zenve3ZmUVqVTcnJoRBvFqeablxZdr/aXhsGiK6hyOEoHnmyqLftWXkNF fkbWKiMqw+bXfkK+SVkFTRQG/cHoMmreJ0lP7rQ/NPty+3TyQ1L+pM5iNNmJ4hVHaPEl XTypVoGZWTQuhxdn72wylRz4OJV78O7WtEcNRdO2YGchxk42oBUhO44quM1C2N7O+TUC nWUgyjrgEOjtlvL282UV8eqWnRoafdgus8dVWM90nQ03dai3Fi4MrR6N7ZR/EoxV2WlK jT3YOoA4Tt0nlgqgUP9vaw5zAXNOU2lnQHoE4Zhr2P0GD1dkZ70vEVW5q6ALF6uk/Tfs 8rHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Dlh4C862rt7Zv2v7jtwbWxXUUcsRvE5OaF+TRNUabuk=; b=vNX8R2b/kt0afPBhkGIEMPDpTp24tZKR4u31XpDlYmaqOfMmfQZECVN21M4O9LTMB9 MttO9a3+WHZTn++krgpTccIBHJmCxmcoeI5zdjsn4XN1mArSGsAahUjtADklQJGVWsJL PeWXG3PsfC0BECKRq0p7OMDundZPyQLJI6l80lcrvK70guYY81V+3VnQsa/YYqDEvLTR N23uw3ghdHnKrN7Exu+w//noLKMfX17wHr3rRQEZPFeg8xIe02QlBSgAYQFSGSKG0Bkd ZINW9vpbbv/CRlJKBgWS/+5jfPn6o/NiwSEX73/feP8GL36LMMARqMsYQfsk/GB2vEmP cr6A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=edhSQJno; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f19si3226940pfd.137.2019.06.21.09.44.37; Fri, 21 Jun 2019 09:44:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=edhSQJno; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726079AbfFUQoc (ORCPT + 99 others); Fri, 21 Jun 2019 12:44:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:34422 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725985AbfFUQoc (ORCPT ); Fri, 21 Jun 2019 12:44:32 -0400 Received: from localhost (unknown [69.71.4.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2599920665; Fri, 21 Jun 2019 16:44:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561135471; bh=m33EIjjXIG8VQjpoiuplC1PQdv27MnbGyWxYvzJb5iU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=edhSQJnoaE2M7HPSpl01zi1vEtEhmwOmlCV0ykFpyZQG5VE2zNsgNeeX9l26kpK/O ZO8r1GMrygTMMQ4BoZ/jXGQeC0bZQ+63UD5uJNe9J19Ud7q20fKYRhuSgrnbV8YnYr qZhG27ydBquwpLnQgwXYJGdiDokvJ4YE5w5SAe+0= Date: Fri, 21 Jun 2019 11:44:29 -0500 From: Bjorn Helgaas To: Alan Cox Cc: Puranjay Mohan , Shuah Khan , Bjorn Helgaas , netdev , Linux Kernel Mailing List , linux-kernel-mentees@lists.linuxfoundation.org, linux-pci@vger.kernel.org Subject: Re: [PATCH v3 0/3] net: fddi: skfp: Use PCI generic definitions instead of private duplicates Message-ID: <20190621164429.GA187016@google.com> References: <20190621094607.15011-1-puranjay12@gmail.com> <20190621162024.53620dd9@alans-desktop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190621162024.53620dd9@alans-desktop> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 21, 2019 at 04:20:24PM +0100, Alan Cox wrote: > On Fri, 21 Jun 2019 15:16:04 +0530 > Puranjay Mohan wrote: > > > This patch series removes the private duplicates of PCI definitions in > > favour of generic definitions defined in pci_regs.h. > > Why bother ? It's an ancient obsolete card ? That's a fair question. Is there anything that would indicate that "this file is obsolete and problems shouldn't be fixed"? Nobody wants to waste time on things that don't need to be fixed, but I don't know how to tell if something is obsolete. My naive assumption is that if something is in the tree, it's fair game for fixes and cleanups. Bjorn