Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp250735ybd; Sat, 22 Jun 2019 02:33:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqwuKmVBiEIJXVuetza3XriIikL9PFGzbyxVG+XnGY3GQnIM9gV7BA62Tqc8AdvWefQR7/R1 X-Received: by 2002:a17:90a:f98a:: with SMTP id cq10mr9280221pjb.43.1561196030706; Sat, 22 Jun 2019 02:33:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561196030; cv=none; d=google.com; s=arc-20160816; b=nOa7JEld6LNUVMX8Yt8Ry2tNFl/Nky8UVKhEW//0W8YMTdQ+6S/33SQ8OU65Evh0AR Quk3YElq4uWgQx3g2XNsUkROTUUxOTmTaVLD6nhyqujsvhd/MHT7GCSpK/1o0tL6y5AN pMLnNdT0K2QFc4UVglqx40JtCaAH4Yg/Uy5oXlVNKgkbvcuQz8RJA4e/o+ryNwtoE8tK Vzf9ktR/G8cEgMudpdZZYqsS5bv1aTu504Yt6C/be0fMpKaUNcmSt+tu7RzNZCm9WRuN A99f+wFfBRWam9E/8A8eg/j1CLRdFhA/3ZnbIbN39n3xkVe04dhTPvvzerRjE3ii9xwb iLng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=OE7+NbMXxNhf0YHBATp2SUFZDudDU4CEv+UT8JfRrA0=; b=FYe31FKkAj2DKEHQt/4r9CyAh05JGn8few2Mro+3nOQtSvdcNYXcLIyz5dT+peeNKP ty05N6ZF4FDZv4jxgh61mGo403p1gc3EVw7IqJniyhqIVNo0QTlKO1BW2vJ6khJIEb/j QKVAAwFTNJ2dn8FD7cziEdgHQ2LFoXvqGeZAu0zWIguHprwu0FSq7AYGZglNUwE32/W/ 0fBzgY9KMNw2URoKpiWOHN4I20iXBys8SG2xcEI8m6/S9gZzGIWkRePl++d1my2K9ogF AKyB4wxtuGPKRzmXyGtXWEUS0it6SEfyh625/z43TNlYFkYM6PhP+B9jYeEhxmxFUhvk KFOw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fjYvZv6S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w185si5293550pfb.170.2019.06.22.02.33.35; Sat, 22 Jun 2019 02:33:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fjYvZv6S; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726362AbfFVJdO (ORCPT + 99 others); Sat, 22 Jun 2019 05:33:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:46350 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726187AbfFVJdO (ORCPT ); Sat, 22 Jun 2019 05:33:14 -0400 Received: from archlinux (cpc149474-cmbg20-2-0-cust94.5-4.cable.virginm.net [82.4.196.95]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1FF7B2075E; Sat, 22 Jun 2019 09:33:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561195993; bh=I0NwKMdM7grA72wdghATYuLC9S2scyeIRrURUSdnpWc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=fjYvZv6SCiSgFIbOvVkdSfPQMb3qP+hXn19RP8kVFsA+lDN0AXzmkMQhD7MlJOTjg ZkYP+qzVkxjnbrhWrqB/kjGwGGIn/h/kadTwkoc2V+ouCWMCHhhbEr73mbQ7KKrY1a yWlr8ul5/WMbgUn74wcqKyiNNfBqiaCvoi1GYyJc= Date: Sat, 22 Jun 2019 10:33:07 +0100 From: Jonathan Cameron To: Olivier Moysan Cc: , , , , , , , , , , Subject: Re: [PATCH 5/5] iio: adc: stm32-dfsdm: add comment for 16 bits record Message-ID: <20190622103307.50ba052b@archlinux> In-Reply-To: <1560949431-22948-6-git-send-email-olivier.moysan@st.com> References: <1560949431-22948-1-git-send-email-olivier.moysan@st.com> <1560949431-22948-6-git-send-email-olivier.moysan@st.com> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 19 Jun 2019 15:03:51 +0200 Olivier Moysan wrote: > Add a comment on DMA configuration for 16 bits record. > > Signed-off-by: Olivier Moysan Applied. Thanks, Jonathan > --- > drivers/iio/adc/stm32-dfsdm-adc.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/iio/adc/stm32-dfsdm-adc.c b/drivers/iio/adc/stm32-dfsdm-adc.c > index d855a605eab6..ee1e0569d0e1 100644 > --- a/drivers/iio/adc/stm32-dfsdm-adc.c > +++ b/drivers/iio/adc/stm32-dfsdm-adc.c > @@ -918,6 +918,11 @@ static void stm32_dfsdm_dma_buffer_done(void *data) > static int stm32_dfsdm_adc_dma_start(struct iio_dev *indio_dev) > { > struct stm32_dfsdm_adc *adc = iio_priv(indio_dev); > + /* > + * The DFSDM supports half-word transfers. However, for 16 bits record, > + * 4 bytes buswidth is kept, to avoid losing samples LSBs when left > + * shift is required. > + */ > struct dma_slave_config config = { > .src_addr = (dma_addr_t)adc->dfsdm->phys_base, > .src_addr_width = DMA_SLAVE_BUSWIDTH_4_BYTES,