Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp522768ybd; Sat, 22 Jun 2019 08:26:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqy9BNPcRw68hQHBsrOlKc14yIM+cokSDLVVsjY4VxhDqd6LnuM9FYlaiDVgkuROo+7VS9DE X-Received: by 2002:a17:90a:fa07:: with SMTP id cm7mr13758812pjb.115.1561217185283; Sat, 22 Jun 2019 08:26:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561217185; cv=none; d=google.com; s=arc-20160816; b=c5cewxoP+xu7UVUxZ6FJdHv+/cF76iOiwsH9VUXREID+MX7eHv13I0/8N7HyKDqZKO K+FhJb5BU01mIKuMJ82HzldobhCGt7BEVv8F0+U3s8iWVCtYB+MdptshvjFP6Pd1YjGy UUE0XvjcNvYBavkQSgcWHzEfZ7kAl/LriEpEbXQjfGYARgtVUEXQBxWV2+QB3L0ALHAS YWU/s7nWHAJHlyBZv98tDJVKGs9e34d/S9QaQgQsxEo9BRTV5E/k1GIygSs7xzFBsGf7 /CT98haqlcggRQYtG/aE+JmX642xrP5DCjlNhjfXIkiaRdlbyZ/WlzULJCJnbKEFOs4/ Zbxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:references :in-reply-to:message-id:date:subject:cc:to:from:dkim-signature; bh=h80AaTSFvhmc0YkZ0rkDk0PBqR1tQ1utYB0+pTg7hDo=; b=P0Ee+z8aohcswduLVj/0y4xV/UL6a7XDPIFy3KEua6UlSHoZ9xAkhiAVrPAz3dfbcm 6nQrU/xaM2/NqbsmRlqDxjs4vU3F0FWu6LqntmEMg+4l8NWCN1P4alwbwRkNMggvht/I Yw1+AIfeuUl9t0HagcFMwpr6uSaV53rwl45LD8mF8ZpGq9S9isnd5o4vGNFfCgHBe2VE GmmG4TCfTGjGOiA/SOzK2+1JsCi8pRR1b1bAVejcSxHYquIX00NsReveM/Snu/c3hrXg qKDwWTjEGVToUlUVD0MLkOXNR0pSKMcidrPMM4bTl5eJ4S7k5TEPhSzcdxi8c2bsUb3K v2yw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FRDkeEcJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f8si5079183pgo.380.2019.06.22.08.26.09; Sat, 22 Jun 2019 08:26:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=FRDkeEcJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726395AbfFVPX5 (ORCPT + 99 others); Sat, 22 Jun 2019 11:23:57 -0400 Received: from mail-pf1-f193.google.com ([209.85.210.193]:34794 "EHLO mail-pf1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726138AbfFVPX5 (ORCPT ); Sat, 22 Jun 2019 11:23:57 -0400 Received: by mail-pf1-f193.google.com with SMTP id c85so5091622pfc.1 for ; Sat, 22 Jun 2019 08:23:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=h80AaTSFvhmc0YkZ0rkDk0PBqR1tQ1utYB0+pTg7hDo=; b=FRDkeEcJbWKXNWXyNJaoCwbsKvdAGm7euu1rEsCxGLOqmdX4hKy1xJBO3AFM4PvQsZ Xyx/e+jpRM+PX3Jmh+e8zcEZVyAs6FSMaE+zgwDT08BtrIBs2p5oDW4PbBLx47QQIKup ELgRwW9xtlpCw0dYYVyFiQaJLncYkWZQNRTntyeV15Ndw2iBcjox3/DKrmJRtZh841sW ba9Ddq3Xh2rNuI4zNDZzNsRezUbkOv/CS6PkeOogrdyroQQ8+M4HpGCOGk4baIoWYEVF Yjr8R39iVSmq7SEqiBxz/oM+TuUZGGb0wSasrs4pZ6bG0oGi+4kBz5trGluFJmvIjR2b 6Cqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=h80AaTSFvhmc0YkZ0rkDk0PBqR1tQ1utYB0+pTg7hDo=; b=TKKQerf/Ik9cTdE0PXpNXxRlq/KQJ62Gz6GpihocoxRjpLSPKSwt99ciTRyq8emmVp 7e4yHuyciXMudWFEmx1pTzuQNgBzrfu9mpqIf0jaiv8aqR8oWtJcipY1L0myJniMGpS+ 9Faw41UODqkdUNzNrZ/okslws/dSVPvz/VC+aZbRvH38bQQoc1XfP1j5pDZKZ/u1jXjN lsp6Ub/zEl2cH1pZP/EkKIk6XnHlUSRTKygN+cMYrhWyzLf0RdMujiAiGTEaM4Cp56dr CnwbC3CfS9JLBvDmDynpernjIthkf7pVJgOvbIQsEpKfC7rXtNh8nlxFYqPpWaVdgmvz i7+Q== X-Gm-Message-State: APjAAAUTBEiYhhPna8ClKoaYjDZYWqGnb6uCMUfTAUENLEqZMSQlVoFW jN6W0ftCN0bYI46KtX8b0hA= X-Received: by 2002:a65:6495:: with SMTP id e21mr23505403pgv.383.1561217036566; Sat, 22 Jun 2019 08:23:56 -0700 (PDT) Received: from localhost.localdomain (c-98-210-58-162.hsd1.ca.comcast.net. [98.210.58.162]) by smtp.gmail.com with ESMTPSA id l44sm12496777pje.29.2019.06.22.08.23.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sat, 22 Jun 2019 08:23:55 -0700 (PDT) From: Shobhit Kukreti To: Greg Kroah-Hartman , Bastien Nocera , Hans de Goede , Larry Finger Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Shobhit Kukreti Subject: [PATCH 2/2] staging: rtl8723bs: os_dep: Modify return type of function rtw_reset_drv_sw() to void. Date: Sat, 22 Jun 2019 08:23:08 -0700 Message-Id: X-Mailer: git-send-email 2.7.4 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The function rtw_reset_drv_sw() return value is set to _SUCCESS. The return value is never checked when the function is called. Modified the return value to void to remove "Unneeded Variable warning of coccicheck. Signed-off-by: Shobhit Kukreti --- drivers/staging/rtl8723bs/include/osdep_intf.h | 2 +- drivers/staging/rtl8723bs/os_dep/os_intfs.c | 4 +--- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/include/osdep_intf.h b/drivers/staging/rtl8723bs/include/osdep_intf.h index 0ea91a1..40313d1 100644 --- a/drivers/staging/rtl8723bs/include/osdep_intf.h +++ b/drivers/staging/rtl8723bs/include/osdep_intf.h @@ -46,7 +46,7 @@ void devobj_deinit(struct dvobj_priv *pdvobj); u8 rtw_init_drv_sw(struct adapter *padapter); u8 rtw_free_drv_sw(struct adapter *padapter); -u8 rtw_reset_drv_sw(struct adapter *padapter); +void rtw_reset_drv_sw(struct adapter *padapter); void rtw_dev_unload(struct adapter *padapter); u32 rtw_start_drv_threads(struct adapter *padapter); diff --git a/drivers/staging/rtl8723bs/os_dep/os_intfs.c b/drivers/staging/rtl8723bs/os_dep/os_intfs.c index bd8e316..79d073e 100644 --- a/drivers/staging/rtl8723bs/os_dep/os_intfs.c +++ b/drivers/staging/rtl8723bs/os_dep/os_intfs.c @@ -705,9 +705,8 @@ void devobj_deinit(struct dvobj_priv *pdvobj) kfree(pdvobj); } -u8 rtw_reset_drv_sw(struct adapter *padapter) +void rtw_reset_drv_sw(struct adapter *padapter) { - u8 ret8 = _SUCCESS; struct mlme_priv *pmlmepriv = &padapter->mlmepriv; struct pwrctrl_priv *pwrctrlpriv = adapter_to_pwrctl(padapter); @@ -737,7 +736,6 @@ u8 rtw_reset_drv_sw(struct adapter *padapter) rtw_set_signal_stat_timer(&padapter->recvpriv); - return ret8; } -- 2.7.4