Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <7ec724a310a710e6415320ff530daba0e1d30505.camel@perches.com>
Subject: Re: [tip:x86/cpu] x86/cpu: Create Zhaoxin processors architecture
 support file
From:   Joe Perches <joe@perches.com>
To:     HerryYang@zhaoxin.com, CooperYan@zhaoxin.com,
        linux-kernel@vger.kernel.org, hpa@zytor.com, lenb@kernel.org,
        gregkh@linuxfoundation.org, QiyuanWang@zhaoxin.com,
        mingo@kernel.org, DavidWang@zhaoxin.com, tglx@linutronix.de,
        rjw@rjwysocki.net, TonyWWang-oc@zhaoxin.com,
        linux-tip-commits@vger.kernel.org
Date:   Sat, 22 Jun 2019 11:01:17 -0700
In-Reply-To: <tip-761fdd5e3327db6c646a09bab5ad48cd42680cd2@git.kernel.org>
References: <01042674b2f741b2aed1f797359bdffb@zhaoxin.com>
         <tip-761fdd5e3327db6c646a09bab5ad48cd42680cd2@git.kernel.org>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.5-0ubuntu0.18.10.1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 2019-06-22 at 03:16 -0700, tip-bot for Tony W Wang-oc wrote:
> Commit-ID:  761fdd5e3327db6c646a09bab5ad48cd42680cd2
> Gitweb:     https://git.kernel.org/tip/761fdd5e3327db6c646a09bab5ad48cd42680cd2
> Author:     Tony W Wang-oc <TonyWWang-oc@zhaoxin.com>
> AuthorDate: Tue, 18 Jun 2019 08:37:05 +0000
> Committer:  Thomas Gleixner <tglx@linutronix.de>
> CommitDate: Sat, 22 Jun 2019 11:45:57 +0200
> 
> x86/cpu: Create Zhaoxin processors architecture support file
> 
[]
> diff --git a/arch/x86/kernel/cpu/zhaoxin.c b/arch/x86/kernel/cpu/zhaoxin.c
[]
> +static void init_zhaoxin_cap(struct cpuinfo_x86 *c)
> +{
> +	u32  lo, hi;
> +
> +	/* Test for Extended Feature Flags presence */
> +	if (cpuid_eax(0xC0000000) >= 0xC0000001) {
> +		u32 tmp = cpuid_edx(0xC0000001);
> +
> +		/* Enable ACE unit, if present and disabled */
> +		if ((tmp & (ACE_PRESENT | ACE_ENABLED)) == ACE_PRESENT) {

trivia:

Perhaps this is more intelligible for humans to read
and it deduplicates the comment as:

		if ((tmp & ACE_PRESENT) && !(tmp & ACE_ENABLED))

The compiler produces the same object code.