Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp1264940ybd; Sun, 23 Jun 2019 03:51:42 -0700 (PDT) X-Google-Smtp-Source: APXvYqxpeI27aGvpUcDNbDQ4UvSu6PJ2KUHcw8561cYkpzalqUbf1RNkz1OCC3CTPNLFMzOds+rP X-Received: by 2002:a17:902:222:: with SMTP id 31mr88914054plc.55.1561287102610; Sun, 23 Jun 2019 03:51:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561287102; cv=none; d=google.com; s=arc-20160816; b=GNuWegRJTL5xka8wzT6Jf87U5Yp2vTNCJbcTRy5LYIpqKD21o7ETILMqiRt5CBbsqP wSbscvb9csVQ2RULQ1zBlfNNPB0TESHpycNHQx1uWB/H6pGNVBsD62GWBppLUecDd6Ok Gzx5q5E0pBKvfSzBFQEjVU8vezIAmxnyYdRqJ+zK+hO0FXw0gw8ZVA4eTqhY+o0ZU50n vKz73JVA8LYmKs9XkKT9F3d6GvEBRzEjgK7r9yvaX1WiJ9MxQf4ipti210ZpxrhyJNI1 loY2Qt0HWO/p4jby64IEAxmDtKffECqKDZ+7vfZs/ywGpWRRZi1yed8U9vFOQ0nvhGNH c6ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=f+gqDi9sMco9yVXTveVj/lqYEVj52La0mYUA+vf4efg=; b=abvYZeQmlQoPJEfjn07lWYX8OlEEOx+qre8xxLnWTWz1vHk5xe6iVXF33qcvB0nyDl 3JwUhvHgHU/NCZmPIOUccn1N/uIiDL6RFCKF3+sI3VOCkOvcnob59fCygB4vLAT7p3MU rJLddPG8FUzg2pHEKo6Qgn9YVardftzM89EW9NFfzUB/2O+xZZQecI6XQQs8TollHDVl KYW9tiqFmMEW67rQ+UmaARMf4QFnOAOVZgH3W4k5nPMG4gb/89A077d8tb8osQd1Nmvo s6Y+s7QVQcqHN0f9adc44fZH1DRoUEfKtJ7mjW3Nhg7CHbMvLnuh0Nk5hHzwL0kW698U DE6w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w18si7411715pga.125.2019.06.23.03.51.17; Sun, 23 Jun 2019 03:51:42 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726505AbfFWKqv (ORCPT + 99 others); Sun, 23 Jun 2019 06:46:51 -0400 Received: from Galois.linutronix.de ([193.142.43.55]:33188 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726350AbfFWKqu (ORCPT ); Sun, 23 Jun 2019 06:46:50 -0400 Received: from p5b06daab.dip0.t-ipconnect.de ([91.6.218.171] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1hf01B-0007hi-S8; Sun, 23 Jun 2019 12:46:42 +0200 Date: Sun, 23 Jun 2019 12:46:40 +0200 (CEST) From: Thomas Gleixner To: Anson.Huang@nxp.com cc: daniel.lezcano@linaro.org, robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, l.stach@pengutronix.de, abel.vesa@nxp.com, ccaione@baylibre.com, angus@akkea.ca, andrew.smirnov@gmail.com, agx@sigxcpu.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linux-imx@nxp.com Subject: Re: [PATCH 1/3] clocksource/drivers/sysctr: Add an optional property In-Reply-To: <20190621082838.12630-1-Anson.Huang@nxp.com> Message-ID: References: <20190621082838.12630-1-Anson.Huang@nxp.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Anson, On Fri, 21 Jun 2019, Anson.Huang@nxp.com wrote: > Subject : [PATCH 1/3] clocksource/drivers/sysctr: Add an optional property That subject line is not really informative. From Documentation: The ``summary phrase`` in the email's Subject should concisely describe the patch which that email contains. That means that it should tell which property it adds so it's immediately clear what this is about. Something like: Subject: clocksource/drivers/sysctr: Add optional clock-frequency property Hmm? > From: Anson Huang > > This patch adds an optional property "clock-frequency" to pass Please read Documentation/process/submitting-patches.rst and search for 'This patch' > the system counter frequency value to kernel system counter > driver and indicate the driver to skip of_clk operations, this > is to support those platforms using platform driver model for > clock driver. That sentence does not parse. Please structure your changelog in the following order: 1) Context or problem 2) Detailed analysis (if applicable and necessary) 3) Short description of the solution (the rest is obvious from the patch itself). So something like this (assumed I decoded the above correctly): Systems which use the system counter with the platform driver model require the clock frequency to be supplied via device tree. This is necessary as in the platform driver model the of_clk operations do not work correctly because LENGHTY EXPLANATION WHY ... Add the optinal clock-frequency to the device tree bindings of the NXP system counter so the frequency can be handed in and the of_clk operations can be skipped. The important part is the missing LENGTHY EXPLANATION WHY. I can't fill that in because you did not provide that information. Thanks, tglx