Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Sun, 23 Jun 2019 22:03:42 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Christian Lamparter <chunkeey@gmail.com>
Cc:     Mathias Nyman <mathias.nyman@intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-arm-msm@vger.kernel.org,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Christian Lamparter <chunkeey@googlemail.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/5] usb: xhci: add firmware loader for uPD720201 and
 uPD720202 w/o ROM
Message-ID: <20190623163342.GR2962@vkoul-mobl>
References: <20190621085913.8722-1-vkoul@kernel.org>
 <20190621085913.8722-2-vkoul@kernel.org>
 <1897697.zOhlaAKarQ@debian64>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1897697.zOhlaAKarQ@debian64>
User-Agent: Mutt/1.11.3 (2019-02-01)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 21-06-19, 21:59, Christian Lamparter wrote:
> On Friday, June 21, 2019 10:59:09 AM CEST Vinod Koul wrote:
> > +	/*
> > +	 * The Firmware's Data Format is describe in
> > +	 * "6.3 Data Format" R19UH0078EJ0500 Rev.5.00 page 124
> > +	 */
> > +
> > +	/* "Each row is 8 bytes". => firmware size must be a multiple of 8. */
> > +	if (length % 8 != 0)
> > +		dev_warn(&dev->dev, "firmware size is not a multiple of 8.");
> 
> It doesn't look like this holds true for the newer K2026090.mem which
> arguably fixes a lot of bugs over K2013080.mem. I think we should remove
> this check and message.

The documentation still says so, that is why I changed error return and
this to warning. Yeah lets remove to not confuse folks :)

-- 
~Vinod