Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp1598863ybd; Sun, 23 Jun 2019 11:26:58 -0700 (PDT) X-Google-Smtp-Source: APXvYqxESqN3v1R6oVmj84eGS44qd/euubJrh8k3UgdVfA43tFeI8aVp/iKSMpfMvpMDCFLXzuRD X-Received: by 2002:a17:90a:e397:: with SMTP id b23mr19774635pjz.140.1561314418859; Sun, 23 Jun 2019 11:26:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561314418; cv=none; d=google.com; s=arc-20160816; b=tuwpryVDGAiRwWdn8+gFJYkRwVYTOAyG+tDTMV8wW6roYRiXkNAPLkAPqJtsDyvNXC 0XWe787x/wfXfIezZ4+TuG2sNnFPTXgCeMyZE+WVwXRvIGkUdVQ4aKprEi0TO8nREnPK qVX3nZoshMKN5hAnRMCCIgukk4HYBKvzPptOoYs8ZxW6kxJ72KlcXblBoASzIY7l5568 gU/HMVz/EGwrF4GMwyt5+Gr7bV/5NEDpNF8wixeu9i0n4YomIGOq3vnH+U1gnHkJIQvB HsDUJFe+acvIKuSoPp+LqBVnpTkFvD7pPjFdpZ/c1VRcnYiGtNLlrhXrzWpuq/Q2N7gr 8Ffw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=ZVFaUmPWy/LEYs/nTPv5DwLPZ+6PY1GZRxu/DMJaceU=; b=X5RzCbI8PsHd0CiSEwxFFGOk1QkupMd51b+AW/P4JtwzQHC+yYiPhJ1iBcYE5r5J17 NGVHEa+/AFcQVh3r63OKnIx8K+zM4CR2GlihPRMrkrH4VcrtPBwtCq+VoqXFg5Z8aT0E T8p5rTTHaJ1j7n2BuNgeBbLRhPkmU12xOJuygDA1VaowDFhW5i09GPECAcyCIRDX2AjR U/IOYGFf2EphqCrfqj4rAzD+sgBBmEE7rReEoPtuqGovvnUnMHkHbBJSrjEi4u4odHKQ GYNgQzNqmM08N/J7wBhjf/fZ+fzAT/EXdBJZpSFc6rK53dzs2gNthiqMZ8BMoDkJG1z4 bFHw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s19si4252083pgs.124.2019.06.23.11.26.43; Sun, 23 Jun 2019 11:26:58 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726874AbfFWSZi (ORCPT + 99 others); Sun, 23 Jun 2019 14:25:38 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:43498 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726677AbfFWSZh (ORCPT ); Sun, 23 Jun 2019 14:25:37 -0400 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::d71]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 70AA0126A1260; Sun, 23 Jun 2019 11:25:37 -0700 (PDT) Date: Sun, 23 Jun 2019 11:25:37 -0700 (PDT) Message-Id: <20190623.112537.2211302797354603091.davem@davemloft.net> To: rasmus.villemoes@prevas.dk Cc: andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, Rasmus.Villemoes@prevas.se, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: dsa: mv88e6xxx: introduce helpers for handling chip->reg_lock From: David Miller In-Reply-To: <20190620135034.24986-1-rasmus.villemoes@prevas.dk> References: <20190620135034.24986-1-rasmus.villemoes@prevas.dk> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 23 Jun 2019 11:25:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Rasmus Villemoes Date: Thu, 20 Jun 2019 13:50:42 +0000 > This is a no-op that simply moves all locking and unlocking of > ->reg_lock into trivial helpers. I did that to be able to easily add > some ad hoc instrumentation to those helpers to get some information > on contention and hold times of the mutex. Perhaps others want to do > something similar at some point, so this frees them from doing the > 'sed -i' yoga, and have a much smaller 'git diff' while fiddling. > > Signed-off-by: Rasmus Villemoes Applied.