Date: Thu, 24 Nov 2005 08:26:12 -0800
From: Matt Mackall <mpm@selenic.com>
To: Muli Ben-Yehuda <mulix@mulix.org>
Cc: Hugh Dickins <hugh@veritas.com>, Russell King <rmk@arm.linux.org.uk>,
       akpm@osdl.org, manfred@colorfullife.com, linux-kernel@vger.kernel.org
Subject: Re: + shut-up-warnings-in-ipc-shmc.patch added to -mm tree
Message-ID: <20051124162612.GS31287@waste.org>
References: <200511230413.jAN4DboR013036@shell0.pdx.osdl.net> <Pine.LNX.4.61.0511241235450.3504@goblin.wat.veritas.com> <20051124160012.GQ31287@waste.org> <20051124160725.GA11863@granada.merseine.nu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20051124160725.GA11863@granada.merseine.nu>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 784
Lines: 23

On Thu, Nov 24, 2005 at 06:07:25PM +0200, Muli Ben-Yehuda wrote:
> On Thu, Nov 24, 2005 at 08:00:12AM -0800, Matt Mackall wrote:
> > If we're going to start converting such things, I'd almost rather do
> > something like:
> > 
> > kernel.h:
> > static inline void empty_void(void) {}
> > static inline void empty_int(void) { return 0; }
>                 ^^^^
> 
> surely if it's returning an int it should be declared as
> static inline int empty_int(void) { return 0; }
> ?

Surely.

-- 
Mathematics is the supreme nostalgia of our time.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/