Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp1870229ybd; Sun, 23 Jun 2019 18:50:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqxDWCCI+S4KHzvjWEfPcYIPvsAgKWQfpPtBwNhdYqPsHoRl/PECVSl9HToc6S/4y2AvyvtU X-Received: by 2002:a63:213:: with SMTP id 19mr26789424pgc.341.1561341004883; Sun, 23 Jun 2019 18:50:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561341004; cv=none; d=google.com; s=arc-20160816; b=g5Of0Fp0wWvjjans6ZK/PeQlJtxQDrjpH4JEGVmhhZxA9ASHSUgD3ENUCOXn7LzTxl comKHRTbTaN1zsV6SdX6p56gjQ6QVXcMbj++ARWwvByqRmDdujgXKEwMzBEF2sQXHubp 5IF7nJEqHS4vqm2GkPt8yOzcXuDaHzde3JQVYsRmsMFsWG+iiR+HcPZnWueXp96hWfej jn0hlif581NI1Q9+McMLbeAYR4KyviCePF2eZ/Iutpvvv2AoXI4qOv5IdkBs0RbZ7kbh R4Lv2yiT17uXtNh1RDiMl2uTsKVnQwMR6bLw84OBgjYJDCIReEhBGRRjzyPZun5DB0X6 5y9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=KoQYiQrMBAoPwcouH5zLkPtiukwZNYdGgxBPjr/sF88=; b=qOW8qJn0S8fYCdew3IyWHx7l3z5MwuoC5zYKyNWrD8/GH2aCLr4w2PtBCUkvvFxc17 ski9ps5KBsSmvHrrrK+RMxZK47a6ykL21xkJm88/wDMjYid/TsyPTR8UzlVgF+oo2IFa yUuO7xid32728hQXKmeNztucM+o1w3hnNewgUGvcZ14cxvBfvjpGJJdUt6dA1snBRLm1 lvXYCPwi3k316L10/NU7MnT1d5IZGWVji6rTin8VxMCBaMeBhX9ZCwz+4ctbIWOgb6zN 43KEA/pJahOFARIaljMOQvzyx6curOS9nde7oqa+pu599CPXPDDhfFFY2xvfZHG9bph9 216w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@android.com header.s=20161025 header.b=aYkg+TE3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=android.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w23si8953010ply.230.2019.06.23.18.49.49; Sun, 23 Jun 2019 18:50:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@android.com header.s=20161025 header.b=aYkg+TE3; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=android.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726527AbfFXBs4 (ORCPT + 99 others); Sun, 23 Jun 2019 21:48:56 -0400 Received: from mail-ot1-f66.google.com ([209.85.210.66]:33689 "EHLO mail-ot1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726323AbfFXBs4 (ORCPT ); Sun, 23 Jun 2019 21:48:56 -0400 Received: by mail-ot1-f66.google.com with SMTP id i4so12083012otk.0 for ; Sun, 23 Jun 2019 18:48:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=android.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=KoQYiQrMBAoPwcouH5zLkPtiukwZNYdGgxBPjr/sF88=; b=aYkg+TE39brESepUpYvudC15qXREldRUSMU/512F+I3btn18W+Xyfqt6LgqaLTPCkh vCiVE2NlKC1hkzVZQPazcAnCKBWcQ56W8WagWpEk5ys8BlKUE8Tti5E4ZaCMNNgKYpGM MsJCrSidc4ZdUr0WbczMxSGC8q3qfuxN9gHvUsNU/IRlKcdg7NcG/cBP9kWp0ZZM4AQd 4ix6Wuk06EKbD7SsXf7AWQrjeWS/JMdohdjDev0BJ5XI/c1gmGhRnKg2GmyCbWj0FLzb 02XeKxEDDNRRW0+Xg44AIg6KcDbGzWU1YaXJnupcpQ18Kg5Ez8NhzflUYscbN98fUctm UGOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KoQYiQrMBAoPwcouH5zLkPtiukwZNYdGgxBPjr/sF88=; b=DWo1L/7bB1RWyvHmsulLGh2jViQKn2GfUvohog01OZqQYMKlikyZlPY+dWm41V/rAQ k2O8zurj8sF49iC3mC4qOfrSgcHhcqyH60v0vWqc3OV9PMaTYp7jzYoZMqf9hoyEDQsb zva7nUBDKYOAM3zMcwt6mbyEAyqy/x8aXEBli8wzpy7QRy7ozOITdp7+DGJkjuzsW6ky tXAcR+YILFeOeSawiYNUp9J56wtwlVuCOGKFptVfH2KdqZZc1uPJ9hC1vTIzr2L/chWC viZ8r9peZ6c4/puLanvNs6ePckMtyqYhjSnkbaT0NBhuCUIA3Yc1SAlkrUmUkLzQNYJC N3XA== X-Gm-Message-State: APjAAAWpndj2IgassgItqHTaJdelYuHO0vpJDd28AG7tl4/WTo71BIre sYY5Q9IreqXkaHINClUERgLcoXj4TsuCbX3dB9ZYrA== X-Received: by 2002:a9d:450a:: with SMTP id w10mr43913762ote.148.1561340935025; Sun, 23 Jun 2019 18:48:55 -0700 (PDT) MIME-Version: 1.0 References: <20190618182502.GC203031@google.com> <4587569.x9DSL43cXO@kreacher> In-Reply-To: From: Tri Vo Date: Sun, 23 Jun 2019 18:48:43 -0700 Message-ID: Subject: Re: Alternatives to /sys/kernel/debug/wakeup_sources To: "Rafael J. Wysocki" Cc: Joel Fernandes , "Rafael J. Wysocki" , Sandeep Patil , Viresh Kumar , Hridya Valsaraju , Linux PM , "Cc: Android Kernel" , Greg Kroah-Hartman , LKML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 19, 2019 at 1:35 AM Rafael J. Wysocki wrote: > > On Wed, Jun 19, 2019 at 1:52 AM Joel Fernandes wrote: > > > > On Tue, Jun 18, 2019 at 7:15 PM Tri Vo wrote: > > [snip] > > > > > > > > > > > > > > Android userspace reading wakeup_sources is not ideal because: > > > > > > > - Debugfs API is not stable, i.e. Android tools built on top of it are > > > > > > > not guaranteed to be backward/forward compatible. > > > > > > > - This file requires debugfs to be mounted, which itself is > > > > > > > undesirable for security reasons. > > > > > > > > > > > > > > To address these problems, we want to contribute a way to expose these > > > > > > > statistics that doesn't depend on debugfs. > > > > > > > > > > > > > > Some initial thoughts/questions: Should we expose the stats in sysfs? > > > > > > > Or maybe implement eBPF-based solution? What do you think? > > > > > > > > > > We are going through Android's out-of-tree kernel dependencies along with > > > > > userspace APIs that are not necessarily considered "stable and forever > > > > > supported" upstream. The debugfs dependencies showed up on our radar as a > > > > > result and so we are wondering if we should worry about changes in debugfs > > > > > interface and hence the question(s) below. > > > > > > > > > > So, can we rely on /d/wakeup_sources to be considered a userspace API and > > > > > hence maintained stable as we do for other /proc and /sys entries? > > > > > > > > > > If yes, then we will go ahead and add tests for this in LTP or > > > > > somewhere else suitable. > > > > > > > > No, debugfs is not ABI. > > > > > > > > > If no, then we would love to hear suggestions for any changes that need to be > > > > > made or we simply just move the debugfs entry into somewhere like > > > > > /sys/power/ ? > > > > > > > > No, moving that entire file from debugfs into sysfs is not an option either. > > > > > > > > The statistics for the wakeup sources associated with devices are already there > > > > under /sys/devices/.../power/ , but I guess you want all wakeup sources? > > > > > > > > That would require adding a kobject to struct wakeup_source and exposing > > > > all of the statistics as separate attributes under it. In which case it would be > > > > good to replace the existing wakeup statistics under /sys/devices/.../power/ > > > > with symbolic links to the attributes under the wakeup_source kobject. > > > > > > Thanks for your input, Rafael! Your suggestion makes sense. I'll work > > > on a patch for this. > > > > Does that entail making each wake up source, a new sysfs node under a > > particular device, and then adding stats under that new node? > > Not under a device, because there are wakeup source objects without > associated devices. > > It is conceivable to have a "wakeup_sources" directory under > /sys/power/ and sysfs nodes for all wakeup sources in there. > > Then, instead of exposing wakeup statistics directly under > /sys/devices/.../power/, there can be symbolic links from there to the > new wakeup source nodes under "wakeup_sources" (so as to avoid > exposing the same data in two different places in sysfs, which may be > confusing). This may be a dumb question. Is it appropriate to make symbolic links in sysfs from one attribute to another attribute? For example, /sys/devices/.../power/wakeup_count -> /sys/power/wakeup_sources/.../wakeup_count. I only see kobject to kobject symlinks around. And I don't think we can make /sys/devices/.../power/ directory a symlink to where our new wakeup stats will be, since the former contains attributes other than wakeup ones. Thanks!