Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190621180208.25361-7-krzk@kernel.org> <20190622191838.29850-1-krzk@kernel.org>
 <CAGTfZH2g6E2pCEtqjfCd+PjEzjwc2AB75LXJfCeO+PcYLiLTUw@mail.gmail.com>
 <CGME20190623192007epcas4p2a3995bb00091b436562828fceb6ff790@epcas4p2.samsung.com>
 <CAJKOXPcFFY08R1H-DrrzX2BC3L8x4NPJTP7nDn9yixAvmaiF9Q@mail.gmail.com> <6edbe882-314c-85e1-4109-7c3b324dc7ab@samsung.com>
In-Reply-To: <6edbe882-314c-85e1-4109-7c3b324dc7ab@samsung.com>
From:   Krzysztof Kozlowski <krzk@kernel.org>
Date:   Mon, 24 Jun 2019 08:56:43 +0200
Message-ID: <CAJKOXPd6BRm+Hz363BhP8xr9dZ6jZxMQmaT7KuiEHAyZz-hDoQ@mail.gmail.com>
Subject: Re: [PATCH v3] arm64: defconfig: Enable Panfrost and Lima drivers
To:     Chanwoo Choi <cw00.choi@samsung.com>
Cc:     cwchoi00@gmail.com, Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
        Maxime Ripard <maxime.ripard@bootlin.com>,
        Olof Johansson <olof@lixom.net>,
        Jagan Teki <jagan@amarulasolutions.com>,
        Simon Horman <horms+renesas@verge.net.au>,
        Leonard Crestez <leonard.crestez@nxp.com>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Dinh Nguyen <dinguyen@kernel.org>,
        Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Vasily Khoruzhick <anarsoul@gmail.com>,
        Marek Szyprowski <m.szyprowski@samsung.com>,
        linux-samsung-soc <linux-samsung-soc@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 24 Jun 2019 at 01:36, Chanwoo Choi <cw00.choi@samsung.com> wrote:
>
> On 19. 6. 24. =EC=98=A4=EC=A0=84 4:16, Krzysztof Kozlowski wrote:
> > On Sun, 23 Jun 2019 at 06:31, Chanwoo Choi <cwchoi00@gmail.com> wrote:
> >>
> >> Hi Krzysztof,
> >>
> >> 2019=EB=85=84 6=EC=9B=94 23=EC=9D=BC (=EC=9D=BC) =EC=98=A4=EC=A0=84 4:=
20, Krzysztof Kozlowski <krzk@kernel.org>=EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=
=B1:
> >>>
> >>> Enable support for Mali GPU with Panfrost and Lima drivers for:
> >>> 1. Samsung Exynos5433 and Exynos7 (having Mali T760),
> >>> 2. Allwiner A64 and H5 (Mali 400/450).
> >>>
> >>> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> >>>
> >>> ---
> >>>
> >>> Changes since v1:
> >>> 1. Enable Lima driver
> >>> ---
> >>>  arch/arm64/configs/defconfig | 3 ++-
> >>>  1 file changed, 2 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/arch/arm64/configs/defconfig b/arch/arm64/configs/defcon=
fig
> >>> index fbbc065415d4..3d31611368af 100644
> >>> --- a/arch/arm64/configs/defconfig
> >>> +++ b/arch/arm64/configs/defconfig
> >>> @@ -518,6 +518,8 @@ CONFIG_DRM_HISI_HIBMC=3Dm
> >>>  CONFIG_DRM_HISI_KIRIN=3Dm
> >>>  CONFIG_DRM_MESON=3Dm
> >>>  CONFIG_DRM_PL111=3Dm
> >>> +CONFIG_DRM_LIMA=3Dm
> >>> +CONFIG_DRM_PANFROST=3Dm
> >>>  CONFIG_FB=3Dy
> >>>  CONFIG_FB_MODE_HELPERS=3Dy
> >>>  CONFIG_BACKLIGHT_GENERIC=3Dm
> >>> @@ -718,7 +720,6 @@ CONFIG_ARCH_TEGRA_194_SOC=3Dy
> >>>  CONFIG_ARCH_K3_AM6_SOC=3Dy
> >>>  CONFIG_SOC_TI=3Dy
> >>>  CONFIG_TI_SCI_PM_DOMAINS=3Dy
> >>> -CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND=3Dy
> >>
> >> Exynos5433-tm2 board support the exynos-bus device which
> >> used the simple_ondmenad governor of devfreq.
> >> Why do you remove this configuration from the defconfig?
> >
> > It is selected by default by DRM_PANFROST. The difference is that
> > PANFROST selects it as module. The 'y' is chosen because of:
> >   SCSI_UFSHCD [=3Dy] && SCSI_LOWLEVEL [=3Dy] && SCSI [=3Dy] && SCSI_DMA=
 [=3Dy]
>
> When I tried to find the history of CONFIG_DEVFREQ_GOV_SIMPLE_ONDEMAND
> for defconfig, the following patch[1] added this configuration.
> [1] b972ff75f2938c39e2205c23ea0e531d36b27f86
> - "arm64: defconfig: Enable UFS on msm8996"
>
> I think that this patch will affect the opration of 'USF on msm8998'.

Hi Chanwoo,

Thanks for the feedback. Unfortunately I do not see how removing a
dependency will affect that SCSI_UFSHCD. The
DEVFREQ_GOV_SIMPLE_ONDEMAND is still built in, exactly the same as
before...

Best regards,
Krzysztof