Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp2166809ybd; Mon, 24 Jun 2019 01:49:33 -0700 (PDT) X-Google-Smtp-Source: APXvYqxKdDWyIUyBWSScb4ksT3pkeVhEQu6+C2AT7FOUaVjKqWNiks6fsdzZi9ny5C6n9Fkgpd6C X-Received: by 2002:a65:5a0a:: with SMTP id y10mr4223615pgs.369.1561366173283; Mon, 24 Jun 2019 01:49:33 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561366173; cv=none; d=google.com; s=arc-20160816; b=zkAtWyDxdZNfMoBc5Vu+/QEHyeck3yZkLRaXX3EuxAtzSe7FSlai58DzrP6gYRAVSU egGAYEiRGIUzvpxEunr+76j4gJ/sb08p7x8IJWVgIkPbiIrKeOHOjo/uQuaqBv0HRQ9S X4uS3sar7PmrA4A1cVefDGt0dguUm1kVazXMcp6WUQiAkFvrK1tazWCvYeCm2hggn98/ 1lKaHmCy4xScBfvCjl9yvdgTwHgCRAjiaXGqwstimUYHmi+Nrb286IaoMoTQ4bx3wZjB ZT+UtWfujqwxWb8bqN7pbI0nAPHi7Ku9d3TyDtFiV6NmnITKYe+jWIIYdVFN3yAeeVfJ 4VYA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=ko8aLEfz7VyLjGG2Rud4lWnzC784JMvOo3wvqWrCylY=; b=bfSWgTateWqapuFo8pSjbZnaJOW8xNWg7cKXYI+Sx9LyR5i8SRRYxhRFvHDCkd0Z6R 5yTwQqzTTNr+8RR0KlR9beK73oF5UgLGX/CH9mmeUYCUSkwxVeNOEnvRT8pJgtldh0UD GD3lzNU5/T0l8KqIF9nAm+cHyQiDUFloaxESW5K1OfIFhfq31V7vwNqDAo1zUaxUp405 CdfGNFcG5ZVjk79Gd5DOEVxtatK1PTdYyflx9uf8L+BovYhBKMDfZC9M3x9RIDyCWSHj 9ml22vlpJGZdd/F41NIViJVei8pw6I9y167ZVQuTZbgKTRVx3NEtXs2PJg3IYwRA2vxW uoSA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=O27JYQHj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u10si9746520pgh.83.2019.06.24.01.49.16; Mon, 24 Jun 2019 01:49:33 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=O27JYQHj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727934AbfFXI3r (ORCPT + 99 others); Mon, 24 Jun 2019 04:29:47 -0400 Received: from mail-ot1-f65.google.com ([209.85.210.65]:39514 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726612AbfFXI3r (ORCPT ); Mon, 24 Jun 2019 04:29:47 -0400 Received: by mail-ot1-f65.google.com with SMTP id r21so12685841otq.6 for ; Mon, 24 Jun 2019 01:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=ko8aLEfz7VyLjGG2Rud4lWnzC784JMvOo3wvqWrCylY=; b=O27JYQHjrIVYtYPY96KP6/xDcPJQgEaFAHlXqjg5fywCA5MavXzZsPvV4g/C96xkrp u1113gVP75+1RepfG5TcDqwYMHtYYYaUOz8HYL5rsvLX9ka2UI9dPqkCf4WQ/XUqDNrH 03oTYPII0Gm/Dr9s6Yt9whFrHb1nXUBdx0+kF7k6tC78MXC/Vabo+KZCByPIFoETRLZW TufrwEcpb5nF6inzvhBK0f6T9bNDbctr9r2KdzkW/4t/brO134v7819BJWt+wOLVJWTx 6b63YjzgWyLQ/3WQ6hfZU0RSthxVTZT6H+fI49zO4gZZOOL3zWQRx179ba7Bg1D2TiO7 1gwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=ko8aLEfz7VyLjGG2Rud4lWnzC784JMvOo3wvqWrCylY=; b=t8Cdopjbvi6ge7fqa5s0aygBHX1tIqrHfs2n9l1wzGquQgoGqwdBk+sXid5rWdQEgY JGrQREWl/JuJvX9VGjlC8dHiCKxWwnztnDK4mJxFKs+kb7+l1ENyjTX+mPUtQSIjLIVt VnZrT/rwVFlvoXov3zOQ035Pl/HGzNF/QeUNfguUDdj3vcWROZMri4VvenG+Lacg+5WI 4bpayccXM+TuqDEMq293cOZ2DYJkJTawPF1TmhCrUNvqbrMaK+l0UC8WHKGOuTK8dRvT sAfPx51fDGxeqq014R6ey0WZ+ciXHMBfOZjtMyQnLeLDMrLfN70D9WoKPUZJ50f916w8 OYeg== X-Gm-Message-State: APjAAAWV4VzugEfAR4KxNd5kPa1PgEa7DCi/CCzv+LxyK2OtNUgHW8tQ aauu9AtcI240FqJpclTslfkuM03L1KoTVy0nzD/25OgE X-Received: by 2002:a9d:7352:: with SMTP id l18mr16004836otk.292.1561364986392; Mon, 24 Jun 2019 01:29:46 -0700 (PDT) MIME-Version: 1.0 References: <20190221162627.3476-1-brgl@bgdev.pl> <9efcbce2-4d49-7197-a3d8-0e83850892d5@web.de> In-Reply-To: <9efcbce2-4d49-7197-a3d8-0e83850892d5@web.de> From: Bartosz Golaszewski Date: Mon, 24 Jun 2019 10:29:35 +0200 Message-ID: Subject: Re: [PATCH] drivers: Adjust scope for CONFIG_HAS_IOMEM before devm_platform_ioremap_resource() To: Markus Elfring Cc: Bartosz Golaszewski , Andy Shevchenko , Greg Kroah-Hartman , Keerthy , Linus Walleij , "Rafael J. Wysocki" , linux-gpio , kernel-janitors@vger.kernel.org, LKML Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org pt., 14 cze 2019 o 18:50 Markus Elfring napisa=C5= =82(a): > > From: Markus Elfring > Date: Fri, 14 Jun 2019 17:45:13 +0200 > > Move the preprocessor statement =E2=80=9C#ifdef CONFIG_HAS_IOMEM=E2=80=9D= so that > the corresponding scope for conditional compilation includes also comment= s > for this function implementation. > > Signed-off-by: Markus Elfring > --- > drivers/base/platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/base/platform.c b/drivers/base/platform.c > index 4d1729853d1a..a5f40974a6ef 100644 > --- a/drivers/base/platform.c > +++ b/drivers/base/platform.c > @@ -78,6 +78,7 @@ struct resource *platform_get_resource(struct platform_= device *dev, > return NULL; > } > EXPORT_SYMBOL_GPL(platform_get_resource); > +#ifdef CONFIG_HAS_IOMEM > > /** > * devm_platform_ioremap_resource - call devm_ioremap_resource() for a p= latform > @@ -87,7 +88,6 @@ EXPORT_SYMBOL_GPL(platform_get_resource); > * resource management > * @index: resource index > */ > -#ifdef CONFIG_HAS_IOMEM > void __iomem *devm_platform_ioremap_resource(struct platform_device *pde= v, > unsigned int index) > { > -- > 2.22.0 > And what is the purpose of that? Bart