Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH RFC] kvm: x86: Expose AVX512_BF16 feature to guest
To:     Jing Liu <jing2.liu@linux.intel.com>, kvm@vger.kernel.org
Cc:     linux-kernel@vger.kernel.org, jing2.liu@intel.com
References: <1561029712-11848-1-git-send-email-jing2.liu@linux.intel.com>
 <1561029712-11848-2-git-send-email-jing2.liu@linux.intel.com>
 <fd861e94-3ea5-3976-9855-05375f869f00@redhat.com>
 <384bc07d-6105-d380-cd44-4518870c15f1@linux.intel.com>
 <fb749626-1d9e-138f-c673-14b52fe7170c@linux.intel.com>
From:   Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <7d304ae7-73c0-d2a9-cd3e-975941a91266@redhat.com>
Date:   Mon, 24 Jun 2019 10:33:37 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.1
MIME-Version: 1.0
In-Reply-To: <fb749626-1d9e-138f-c673-14b52fe7170c@linux.intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 24/06/19 05:10, Jing Liu wrote:
>> What do you think about @index in current function? Does it mean, we
>> need put cpuid from index to max subleaf to @entry[i]? If so, the logic
>> seems as follows,
>>
>> if (index == 0) {
>>      // Put subleaf 0 into @entry
>>      // Put subleaf 1 into @entry[1]
>> } else if (index < entry->eax) {
>>      // Put subleaf 1 into @entry
>> } else {
>>      // Put all zero into @entry
>> }
>>
>> But this seems not identical with other cases, for current caller
>> function. Or we can simply ignore @index in 0x07 and just put all
>> possible subleaf info back?

There are indeed quite some cleanups to be made there.  Let me post a
series as soon as possible, and you can base your work on it.

Paolo