Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190624050937.6977-1-houweitaoo@gmail.com>
In-Reply-To: <20190624050937.6977-1-houweitaoo@gmail.com>
From:   Uladzislau Rezki <urezki@gmail.com>
Date:   Mon, 24 Jun 2019 11:41:28 +0200
Message-ID: <CA+KHdyWTst1GFUC3JqHAieuV19UdR67LEPhvDKYZ569u2L1qbA@mail.gmail.com>
Subject: Re: [PATCH] mm/vmalloc: fix a compile warning in mm
To:     Weitao Hou <houweitaoo@gmail.com>
Cc:     Andrew Morton <akpm@linux-foundation.org>,
        Roman Penyaev <rpenyaev@suse.de>, Roman Gushchin <guro@fb.com>,
        Rick Edgecombe <rick.p.edgecombe@intel.com>,
        Mike Rapoport <rppt@linux.ibm.com>,
        Andrey Ryabinin <aryabinin@virtuozzo.com>,
        Linux Memory Management List <linux-mm@kvack.org>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello, Hou.

It has already been fixed. Please have a look at:

https://ozlabs.org/~akpm/mmotm/broken-out/mm-vmalloc-avoid-bogus-wmaybe-uni=
nitialized-warning.patch
https://ozlabs.org/~akpm/mmotm/broken-out/mm-vmalloc-avoid-bogus-wmaybe-uni=
nitialized-warning-fix.patch

--
Vlad Rezki

On Mon, Jun 24, 2019 at 7:09 AM Weitao Hou <houweitaoo@gmail.com> wrote:
>
> mm/vmalloc.c: In function =E2=80=98pcpu_get_vm_areas=E2=80=99:
> mm/vmalloc.c:976:4: warning: =E2=80=98lva=E2=80=99 may be used uninitiali=
zed in
> this function [-Wmaybe-uninitialized]
> insert_vmap_area_augment(lva, &va->rb_node,
>
> Signed-off-by: Weitao Hou <houweitaoo@gmail.com>
> ---
>  mm/vmalloc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/vmalloc.c b/mm/vmalloc.c
> index 4c9e150e5ad3..78c5617fdf3f 100644
> --- a/mm/vmalloc.c
> +++ b/mm/vmalloc.c
> @@ -913,7 +913,7 @@ adjust_va_to_fit_type(struct vmap_area *va,
>         unsigned long nva_start_addr, unsigned long size,
>         enum fit_type type)
>  {
> -       struct vmap_area *lva;
> +       struct vmap_area *lva =3D NULL;
>
>         if (type =3D=3D FL_FIT_TYPE) {
>                 /*
> --
> 2.18.0
>


--=20
Uladzislau Rezki