Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp2244861ybd; Mon, 24 Jun 2019 03:12:47 -0700 (PDT) X-Google-Smtp-Source: APXvYqzCJfEHLse1Utc/1z8k6o3FxOYDfKqMn0BkPAaUNRi9HBD4CEEny3Lx5QaO2IzkqLqBreqA X-Received: by 2002:a63:3383:: with SMTP id z125mr18351443pgz.8.1561371167605; Mon, 24 Jun 2019 03:12:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561371167; cv=none; d=google.com; s=arc-20160816; b=tQSo7As4mUYLqyz49DulcLW77eTfVpdcuQqlMFgA47CcMiRgl2hboUTuLUQLsMeYK2 4X2TaybPC0/2QqglvVn1faPLHkRWxQsgeYjJoVrnDBN9Xvx0pBk8dVmTtvolgcGqrhng +gYF2CpShDuA4xuJbOOT839NLQX6dTEp4zH9qU2JWn2MP0brNiyhSph8Zh56EP9JKp/3 CMKNjhI+75KYjFCcpVMIrljhcwabqb8BDU4xkpa++xhUNe8n9ZCrl7X7GET09duoytY3 kbh4EZ213f1+y56ix2JUQfmY2XtxvLdfwSQE93jM7qMtDCaALKZISaJ2EQ4Y/+8dhyIl KN4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dL9eRigdjokT/LvAtgSxzAUo0+KJpXt50hrDdGqS8vc=; b=zmW6oYWROHaoZOLY5xzEBdaN3KiivsD69IpG0W676mx7X4mKiiq0MQgJgQybSqFbZ4 UVD+1kUrY2yF+te72iqOBzkddMzghweJmt/sKCppcN1f9sjgjjx8Sdz8YnrHM5PBg6bs +6o4cMQCFfxHNJQcIImPHxTaNQpxRwVUtGm3ffDMxvzcYIP4izAXQT0couRCCZTZNpLP 3z/HJbBjzm4AtTC7P61CxZEDkU9OvWg668ugYw+ztd1gB6jWx9Sk5Ws7HeXmbwtO5hGt C1ZngIL6meckIZpSz2LMrhXYpytlDvPj11rvty38Gnckz/GJevF+e18m1ZSVz4odnfnE gaiw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uV7KPdos; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c1si7920036pgp.45.2019.06.24.03.12.32; Mon, 24 Jun 2019 03:12:47 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=uV7KPdos; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729525AbfFXKGe (ORCPT + 99 others); Mon, 24 Jun 2019 06:06:34 -0400 Received: from mail.kernel.org ([198.145.29.99]:38706 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730123AbfFXKGb (ORCPT ); Mon, 24 Jun 2019 06:06:31 -0400 Received: from localhost (f4.8f.5177.ip4.static.sl-reverse.com [119.81.143.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AC1272145D; Mon, 24 Jun 2019 10:06:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561370790; bh=lboz67gfjqTkNmYwfDdk7GOXes25CUDfRX6XNlkjwkA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uV7KPdoshHoLch/dz0qPJFSQtKgQM95kk18TUWnjOJXJfvrlk7kLLpYoYXG0J0H30 0CjkHADufIzFsbcnvBrQ1ZUvG//ksXnYoUVipCbSa51hNxiPr6EeXnv+XorgXoYsb4 b6WPeSnUIBHKgJbkztoihuXqsrVWCAYOD+AYmrL4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Johannes Berg Subject: [PATCH 4.19 85/90] mac80211: drop robust management frames from unknown TA Date: Mon, 24 Jun 2019 17:57:15 +0800 Message-Id: <20190624092319.468650239@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190624092313.788773607@linuxfoundation.org> References: <20190624092313.788773607@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Johannes Berg commit 588f7d39b3592a36fb7702ae3b8bdd9be4621e2f upstream. When receiving a robust management frame, drop it if we don't have rx->sta since then we don't have a security association and thus couldn't possibly validate the frame. Cc: stable@vger.kernel.org Signed-off-by: Johannes Berg Signed-off-by: Greg Kroah-Hartman --- net/mac80211/rx.c | 2 ++ 1 file changed, 2 insertions(+) --- a/net/mac80211/rx.c +++ b/net/mac80211/rx.c @@ -3752,6 +3752,8 @@ static bool ieee80211_accept_frame(struc case NL80211_IFTYPE_STATION: if (!bssid && !sdata->u.mgd.use_4addr) return false; + if (ieee80211_is_robust_mgmt_frame(skb) && !rx->sta) + return false; if (multicast) return true; return ether_addr_equal(sdata->vif.addr, hdr->addr1);