Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp2248728ybd; Mon, 24 Jun 2019 03:16:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqwE6i7i+jSeIs+F1AhsQ8eK5cFU0sAiyZ1qBdu62YcCYaUAQVje2vnjr//xV0U/LotsGZRA X-Received: by 2002:a17:90a:af8e:: with SMTP id w14mr24323620pjq.89.1561371397245; Mon, 24 Jun 2019 03:16:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561371397; cv=none; d=google.com; s=arc-20160816; b=mFuN3XGLTa6porhcyOwGJ5KCScxVAa5DQeXLgeIvG0k5evI6gF0+mx9OfKHLyMztEB H3iGgNwg2sjcPnBPgRCTSxI+cxc+zPYJYX3PsDLrPEh7eaXp0qJX+oy8AZXikom75D3C kzAuFP5G4ecs3KHChqn8dbkLLT6k8+BBCa/zxvv8gt0W7/y+znquHxh4nV7uhjz809ZJ 0GClBzXnqQF3/eWMmiPia9+8ukkbZDsykRqs4HslYFm0Vg5AQVQFOH8AuirsJLus5uoi aRF8XTcK4kzeSxB5JBfvtvy4jP8MtinPBZdsvxI8kGgP+jFV5szo9502lCPAUg60gYQG oEiw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=TaPMqaHUV1NX0CJo+inQCxpZkBPJj/mbz2QhpEpSDYA=; b=YESM04ck4q4WooexTx7xtIMp6oIcZJoTyclyxdWTBzR2mWrgkS3hZudMbnmJkWTtea K1vyAa5z9QroYWTBB7kouECvWJfq0laeZrXSmbDmiuNsW1h/wbvjHnagO9LQeVRehjBd tL6BAkw3EYETLYccgy0fh+GuB7ySO0cZWkRT1MrabGO/9p2kusFAuj4RlhXatxwov7Qr +c75pVa0o0T/RZ+qJFNR4QS5H7DVUD9D3L30LUk9nhfLVZIZbssa177CNCtaLbNgeSV6 qKuu0RieyLiAwgcq1uW6ZkymL1E9W3lGmMijjX5pwjCRgoKAeNwEw0VV+pIzxKwJAXxA 07TQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2Ed3i8j6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r11si10214172pjq.108.2019.06.24.03.16.21; Mon, 24 Jun 2019 03:16:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2Ed3i8j6; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730580AbfFXKQC (ORCPT + 99 others); Mon, 24 Jun 2019 06:16:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:53398 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730025AbfFXKP6 (ORCPT ); Mon, 24 Jun 2019 06:15:58 -0400 Received: from localhost (f4.8f.5177.ip4.static.sl-reverse.com [119.81.143.244]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 65D5E205ED; Mon, 24 Jun 2019 10:15:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1561371357; bh=IxxckGWoavSWiTFLS3AgZL5hr8r6rQT8m7x02K4Eoho=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2Ed3i8j6fgN3jAQYlorn3+Shj/KAqZ7wvaAo3+d3FO0YP5nFsxuajWyVur4P62dcb HolS6/P5Kg2wMr7rNjnbFM1mtQsTYVFOUxtwa0Pi+R/5JpCbg9J440VX+LwDXog/KY Y/XyDHcRNEoCAqrRZ5qlGl+wLrGm0tQ1FVnvt6KI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Eric Long , Baolin Wang , Vinod Koul , Sasha Levin Subject: [PATCH 5.1 038/121] dmaengine: sprd: Fix the incorrect start for 2-stage destination channels Date: Mon, 24 Jun 2019 17:56:10 +0800 Message-Id: <20190624092322.752085308@linuxfoundation.org> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190624092320.652599624@linuxfoundation.org> References: <20190624092320.652599624@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ Upstream commit 3d626a97f0303e9c30d063434b749de3f0f91fb5 ] The 2-stage destination channel will be triggered by source channel automatically, which means we should not trigger it by software request. Signed-off-by: Eric Long Signed-off-by: Baolin Wang Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/dma/sprd-dma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c index 431e289d59a5..0f92e60529d1 100644 --- a/drivers/dma/sprd-dma.c +++ b/drivers/dma/sprd-dma.c @@ -510,7 +510,9 @@ static void sprd_dma_start(struct sprd_dma_chn *schan) sprd_dma_set_uid(schan); sprd_dma_enable_chn(schan); - if (schan->dev_id == SPRD_DMA_SOFTWARE_UID) + if (schan->dev_id == SPRD_DMA_SOFTWARE_UID && + schan->chn_mode != SPRD_DMA_DST_CHN0 && + schan->chn_mode != SPRD_DMA_DST_CHN1) sprd_dma_soft_request(schan); } -- 2.20.1