Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp2490704ybd; Mon, 24 Jun 2019 07:20:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqwOlMF8RkvD2x6IL3JQWc3g8SBzSbgrFKyFyp9H5Tjlcvy0xDg2xWUzZHE30RI3pxmVm5h/ X-Received: by 2002:a63:7f07:: with SMTP id a7mr16010632pgd.26.1561386018391; Mon, 24 Jun 2019 07:20:18 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561386018; cv=none; d=google.com; s=arc-20160816; b=uw2lJiX3U/VWMgGHFJgecSTsdu5rUY5MSYP5OT4iXOGKJhWPLmHvHLdBWJr42BHWB6 0Y2C1w3Rle4JcpQLaGRSnrjYKYsFgZRDr4biHnfj63hNPAkj76gdZH88X9qytMadZy++ cC9t3FUmPTg4VesffmAkDibkJzhJM/+8dn8Unu05GwvuHD0QWA11p3FDeimHlhKHyJbi FVZo/eoJAh8PZSf0PV4TBRbIw7XFnjYP801AVfNwna0ynjLky6y1U0OySsd1N3hPudXn qV/cDBW/vqHdoAG/Ixs9HGq2VsaMPaOwfXyncRQUb9/eNE3HcVjqidPRcY37EWAKI6Cs M1zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=KptglKiorU95pwI/pjmagyuGLuNXr9MKuaB4FPPE9s8=; b=EqmZ22SvYNIm/Hm5+BEcuxSvRrf5x4e0UQQXQcr7KawL+OtbF2dPfE8Pj9P1BxxYXY Tg55Dz8Bg8wePkUbkaIJoaqwjk10Eewbd8i5hFnLpv1kHcRiJ4Sc1lm+3//kPpfityHn UAhN7iQsQugJ9ZBTqaOI6wdyzVGms0WbCh3h8p9AMrzrANdl9Hrenh+IeHL8mzhkDeX5 PAl6IpyfvRfxdSLW6tIrBLsgLflz1CGhzBOoV23frmxzNqzBBRVq5y54P8aYBLZoQwKV 8EExbHRI7FEUygq5rghmXJ26I4SiEqPwA6MulWqACf2UyK+DDI9ADSTX4teLhoNgqOYs gHWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=uJ0CROum; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a130si823592pfa.7.2019.06.24.07.20.02; Mon, 24 Jun 2019 07:20:18 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@lunn.ch header.s=20171124 header.b=uJ0CROum; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731409AbfFXNzP (ORCPT + 99 others); Mon, 24 Jun 2019 09:55:15 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:53376 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728762AbfFXNzO (ORCPT ); Mon, 24 Jun 2019 09:55:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=KptglKiorU95pwI/pjmagyuGLuNXr9MKuaB4FPPE9s8=; b=uJ0CROumKYnIINu/Kn05ZH0uoL GfiyAMb3GcFHu3H/GBB9sorrbrNTlWHcX79EvuuSUHHm3uJb0o6sXAEEY7hTrc/5+lwnEITziu049 oGsn/V/hBpIdbBKKOY5yOnyy8MQTaUqCBiKrLW7orid9XoeakRedtH6uFFHTsz+8OVaY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.89) (envelope-from ) id 1hfPQV-0005Ig-9V; Mon, 24 Jun 2019 15:54:31 +0200 Date: Mon, 24 Jun 2019 15:54:31 +0200 From: Andrew Lunn To: Phong Tran Cc: acme@kernel.org, alexander.shishkin@linux.intel.com, alexander.sverdlin@gmail.com, allison@lohutok.net, ast@kernel.org, bgolaszewski@baylibre.com, bpf@vger.kernel.org, daniel@iogearbox.net, daniel@zonque.org, dmg@turingmachine.org, festevam@gmail.com, gerg@uclinux.org, gregkh@linuxfoundation.org, gregory.clement@bootlin.com, haojian.zhuang@gmail.com, hsweeten@visionengravers.com, illusionist.neo@gmail.com, info@metux.net, jason@lakedaemon.net, jolsa@redhat.com, kafai@fb.com, kernel@pengutronix.de, kgene@kernel.org, krzk@kernel.org, kstewart@linuxfoundation.org, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux@armlinux.org.uk, liviu.dudau@arm.com, lkundrak@v3.sk, lorenzo.pieralisi@arm.com, mark.rutland@arm.com, mingo@redhat.com, namhyung@kernel.org, netdev@vger.kernel.org, nsekhar@ti.com, peterz@infradead.org, robert.jarzmik@free.fr, s.hauer@pengutronix.de, sebastian.hesselbarth@gmail.com, shawnguo@kernel.org, songliubraving@fb.com, sudeep.holla@arm.com, swinslow@gmail.com, tglx@linutronix.de, tony@atomide.com, will@kernel.org, yhs@fb.com Subject: Re: [PATCH V2 10/15] ARM: orion5x: cleanup cppcheck shifting errors Message-ID: <20190624135431.GO31306@lunn.ch> References: <20190623151313.970-1-tranmanphong@gmail.com> <20190624135105.15579-1-tranmanphong@gmail.com> <20190624135105.15579-11-tranmanphong@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190624135105.15579-11-tranmanphong@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 24, 2019 at 08:51:00PM +0700, Phong Tran wrote: > [arch/arm/mach-orion5x/pci.c:281]: (error) Shifting signed 32-bit value > by 31 bits is undefined behaviour > [arch/arm/mach-orion5x/pci.c:305]: (error) Shifting signed 32-bit value > by 31 bits is undefined behaviour > > Signed-off-by: Phong Tran > Reviewed-by: Andrew Lunn Thanks for swapping to the BIT macro. Andrew