Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp2512695ybd; Mon, 24 Jun 2019 07:42:56 -0700 (PDT) X-Google-Smtp-Source: APXvYqxqj6wCTdb5NyuDTEYFbdPzVRm6/G5il/fclMqFMPVIlC1ECsIP55iEwXIgCClHKW4VyaWO X-Received: by 2002:a17:902:2ec5:: with SMTP id r63mr71487256plb.21.1561387376024; Mon, 24 Jun 2019 07:42:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561387376; cv=none; d=google.com; s=arc-20160816; b=XwaYCpiQe8Vsfbylm9ysb5ZzQQZaHrix3zcZ/220GP5UtmoNKTrGP8Ekx160XF4Ecj okdUdFvUZ73TbakH4P3V5SU0GnoliVB/p9WHpR6tddgQVllAksBwyzq9Q6OB4Bybklxx oh1xS9cq5cIKEtNQ4lvW+xfPftD4jjuGsz9kTsQUsnivcNClftmWCnMSljhUxCdV1VWd dWNcuJ87X8KOmAX9hHCzowaErV55/dQ8AzlireBSh6KdAbMwGU4mbT/y0x9BJBmuBPT1 ffkElwvA0E0g6MyJWR1vA4K69ksTzvfhgEptiGhq5q9dGhF4nti8oMhyErx0NW9splk/ Q6AA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:to:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:from; bh=7y0wVb/encs4IjzYP0uwc1EetaaQOXN1Ss0CnmFj7Fs=; b=cFBKHyn/gqRczdW+DLNoobtK0qSF+bh7l/AmFyOha8QHqzi+TvVAiiZy6XRw8aZ+OG jmUImrfmX9wd13m8pt9uADuIFtoWaWAuLkw75pd9k+VXsocuoqC+noHBGOP9NHTvf2H7 c1gN3hQufdYcPFXCmw0CazPaZwzE8OEl9c2UA2YEy8x3ryNn2BllvHq8gDqFYNBRcMF9 XfkrtZKwaGSWLEGp2MIObCZPSBabWqajZVTg9UBhNK51WJESCh5rgVPYlIYhdTVqTEqh GntiYWE/HG8+0ubJtH9jWpAYC089L3pd/dwGPLYQWqOogG7tzK+ZwcjwB4UHXLKXZb1i 072g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k33si10514839pld.359.2019.06.24.07.42.40; Mon, 24 Jun 2019 07:42:56 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729549AbfFXOmU (ORCPT + 99 others); Mon, 24 Jun 2019 10:42:20 -0400 Received: from mx2.suse.de ([195.135.220.15]:50442 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729030AbfFXOmF (ORCPT ); Mon, 24 Jun 2019 10:42:05 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id E2F7CAF7C; Mon, 24 Jun 2019 14:42:03 +0000 (UTC) From: Roman Penyaev Cc: Roman Penyaev , Andrew Morton , Al Viro , Linus Torvalds , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v5 12/14] epoll: support mapping for epfd when polled from userspace Date: Mon, 24 Jun 2019 16:41:49 +0200 Message-Id: <20190624144151.22688-13-rpenyaev@suse.de> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190624144151.22688-1-rpenyaev@suse.de> References: <20190624144151.22688-1-rpenyaev@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org User has to mmap user_header and user_index vmalloce'd pointers in order to consume events from userspace. Also we do not let any copies of vma on fork(). Signed-off-by: Roman Penyaev Cc: Andrew Morton Cc: Al Viro Cc: Linus Torvalds Cc: linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- fs/eventpoll.c | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/fs/eventpoll.c b/fs/eventpoll.c index 1d4a76ff5dff..34239564bdfb 100644 --- a/fs/eventpoll.c +++ b/fs/eventpoll.c @@ -1447,11 +1447,47 @@ static void ep_show_fdinfo(struct seq_file *m, struct file *f) } #endif +static int ep_eventpoll_mmap(struct file *filep, struct vm_area_struct *vma) +{ + struct eventpoll *ep = vma->vm_file->private_data; + size_t size; + int rc; + + if (!ep_polled_by_user(ep)) + return -EOPNOTSUPP; + + size = vma->vm_end - vma->vm_start; + if (!vma->vm_pgoff && size > ep->header_length) + return -ENXIO; + if (vma->vm_pgoff && ep->header_length != (vma->vm_pgoff << PAGE_SHIFT)) + /* Index ring starts exactly after the header */ + return -ENXIO; + if (vma->vm_pgoff && size > ep->index_length) + return -ENXIO; + + /* + * vm_pgoff is used *only* for indication, what is mapped: user header + * or user index ring. Sizes are checked above. + */ + if (!vma->vm_pgoff) + rc = remap_vmalloc_range_partial(vma, vma->vm_start, + ep->user_header, size); + else + rc = remap_vmalloc_range_partial(vma, vma->vm_start, + ep->user_index, size); + if (likely(!rc)) + /* No copies for forks(), please */ + vma->vm_flags |= VM_DONTCOPY; + + return rc; +} + /* File callbacks that implement the eventpoll file behaviour */ static const struct file_operations eventpoll_fops = { #ifdef CONFIG_PROC_FS .show_fdinfo = ep_show_fdinfo, #endif + .mmap = ep_eventpoll_mmap, .release = ep_eventpoll_release, .poll = ep_eventpoll_poll, .llseek = noop_llseek, -- 2.21.0