Received: by 2002:a25:f815:0:0:0:0:0 with SMTP id u21csp2786310ybd; Mon, 24 Jun 2019 12:38:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqxYHWuoWcP/obOK9EZPUco+WuUHNUb5MB/rBXhgfub3gv6+Kc/WZ0iNGOb36WfOwpN3ITU2 X-Received: by 2002:a63:3349:: with SMTP id z70mr8495879pgz.355.1561405126366; Mon, 24 Jun 2019 12:38:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1561405126; cv=none; d=google.com; s=arc-20160816; b=Q4yXfTH8DEsuBLmh8Ba26xcUIjKidv7IVQ17zrClE6Szd4j1++tH8rcjQ1RFFMJVDy PtJsrdePBH7RyS/TEXFYlZZ/9qu3oNJDbpjzmtLS7TQ7p0/8q6EUEZNVOFxlyiC+3CJq O3cQSSoc716whM/bIB+isD3eplbvpIvKkL3s4ae17sWdup8MFpr7EDc5Ls/uGoRFfdQG 7iBs/0LkX5NeZOIBZJdCBup2S2Fs0xBnwNyHwWEC9UCSh769gqGl+CMVVQ5A9dmqT0nL 1J58qT0BN6n1iSYurhPQnCmMg2cWitHS0A1dErwtZNF7yTKzdkFPOvEgu2lwQS1wsmma AokQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=xk9Y9/4d1P0hhiRulYC6/59GayfnrTydVvyulmj2MA0=; b=MmpihVq7avFurbojmDH83sSIp5sSxqgcgeQ5JQidl9qgm3NpLpc+liHkeTNlDJZHpc ZUi4GpvVgSlzyOBiwAmBlNSdPsjKDh7oNVFsZGiwZb7uKKh+zko4hiFubxWQJu3FYDLI T5AiXX9wzZO9ZNcIGF0w4mPPfTj7xvq39DKRyBzdN8Db4xg5DDHA+dkYvzYcp8phxNfQ xu5a5/6sjU4yvVr8J+BsAztPVSlZ4gVgVQkFy2s4/j7oT8lI7SyU4Hol6NBhGU7pHSX6 c1OcZmM5ouB4T0Iyw0ZIt/XAFCbYd3K3ToPQLTzgjtLKzM9NK3upZ6R60GAAnn1z9D+y dfow== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=gJlLLhHa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t5si10880552pgv.164.2019.06.24.12.37.42; Mon, 24 Jun 2019 12:38:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=gJlLLhHa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730354AbfFXPT1 (ORCPT + 99 others); Mon, 24 Jun 2019 11:19:27 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:46194 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729305AbfFXPT1 (ORCPT ); Mon, 24 Jun 2019 11:19:27 -0400 Received: by mail-pg1-f196.google.com with SMTP id v9so7261106pgr.13 for ; Mon, 24 Jun 2019 08:19:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xk9Y9/4d1P0hhiRulYC6/59GayfnrTydVvyulmj2MA0=; b=gJlLLhHaj6Jvm1bCaUN3ZW2zumf00y0LQxCLkUqwaGzxFCYZiFYQ8rTczXQpCRZDpw NtK5q/uM6I5V76gghSg5fmbJ43CHbwtS081cohfzOJ6io4WFLGOcoXgaTyWCbMrjkAsj xY9qHxrZFwQHzIVemFHx4ljFg0oGqYce6edkh2yeRRpwJiU/trCjsIhFgezWhFJcCgqe H4Scl/FXgMov4Q2yD8FeFxw798h6RqiToCrKV5Bs2iobxW0/QAamUc9TkSldXFyswImI Apxtk2c/8886Fs7QUpgFAYPFhvHX896Nq/69H5XW37lFOXvRa0xmPRdWgvt7Lc42nHf+ rPsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xk9Y9/4d1P0hhiRulYC6/59GayfnrTydVvyulmj2MA0=; b=LrRrB6tpx+26roxvc0Hs7MrZ6/5/mQzzTq0rF7U5BBxlRkJO9f8FMaztH/x0lmmagr ZV0YYhUbibjbRn2U4pmkf8H1qyfCvfL2ozX+16GmR9EEOmmz4dSOx3N3M0v+DkWVVp3/ btws6oGVPgcjaZbRyteJkj5NKETFdnFpBJmwJuUteRCQ6/XJdoX1vxu4yjiVXqHiKDE8 OUTtk8TQT6vOKfcOKM01mhRrSroPsvekm1mwkxCbQuqis/X5pdWrIxJqC6i6tTzl1dgE YJF2aCGhsMlP7aIjxav2QXjOjJo8RpaOtD/p5DpJ2iGcGanKY4yCxYu4rc8tLCz8wccc 7vSg== X-Gm-Message-State: APjAAAUxG5iTPOxpcfmneEN2FcOknzqaffND5vhZAz2vHHhO5w8IiSGY 22nYhSugBFGHkkg0N7OGr0ER6g== X-Received: by 2002:a17:90a:ad93:: with SMTP id s19mr25538029pjq.36.1561389566146; Mon, 24 Jun 2019 08:19:26 -0700 (PDT) Received: from localhost ([2620:10d:c091:500::d3ed]) by smtp.gmail.com with ESMTPSA id n2sm10152216pgp.27.2019.06.24.08.19.24 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Mon, 24 Jun 2019 08:19:25 -0700 (PDT) Date: Mon, 24 Jun 2019 11:19:23 -0400 From: Johannes Weiner To: Matthew Wilcox Cc: Linus Torvalds , Andrew Morton , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH] mm: fix page cache convergence regression Message-ID: <20190624151923.GA10572@cmpxchg.org> References: <20190524153148.18481-1-hannes@cmpxchg.org> <20190524160417.GB1075@bombadil.infradead.org> <20190524173900.GA11702@cmpxchg.org> <20190530161548.GA8415@cmpxchg.org> <20190530171356.GA19630@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190530171356.GA19630@bombadil.infradead.org> User-Agent: Mutt/1.12.0 (2019-05-25) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 30, 2019 at 10:13:56AM -0700, Matthew Wilcox wrote: > On Thu, May 30, 2019 at 12:15:48PM -0400, Johannes Weiner wrote: > > Are there any objections or feedback on the proposed fix below? This > > is kind of a serious regression. > > I'll drop it into the xarray tree for merging in a week, if that's ok > with you? Hey, it's three weeks later and we're about to miss 5.2. This sucks, Matthew. You introduced a serious regression to the MM subsystem, whose process and patch routing you largely bypassed. When I encountered the problem and provided a reproducer and a fix, you gave me a hard time on cosmetic grounds. I incorporated all your feedback, and still you show no urgency to get this patch or a fix of your own into mainline. It's your bug, please fix it.